--- Log opened Wed Jan 05 00:00:22 2022
02:20 -!- gnusha [~gnusha@user/gnusha] has quit [Ping timeout: 240 seconds]
02:20 -!- gnusha [~gnusha@user/gnusha] has joined #bitcoin-rust
02:20 -!- Topic for #bitcoin-rust: Discussion of rust-bitcoin, rust-lightning and related crates | For rust-miniscript see ##miniscript | For general bitcoin discussion #bitcoin | Channel logs forthcoming
02:20 -!- Topic set by BlueMatt [~BlueMatt@ircb.bluematt.me] [Thu May 20 08:46:43 2021]
02:20 [Users #bitcoin-rust]
02:20 [ _0x0ff     ] [ darosior   ] [ greypw254   ] [ MatrixBot1234510] [ sanket_cell_] 
02:20 [ achow101   ] [ DeanGuss   ] [ Guest985    ] [ michaelfolkson  ] [ sebx2a      ] 
02:20 [ ariard     ] [ dpc[m]     ] [ jeremyrubin ] [ moneyball_      ] [ stevenroose ] 
02:20 [ arik       ] [ dr_orlovsky] [ jetpack     ] [ mycroft         ] [ stick       ] 
02:20 [ b42        ] [ elichai2   ] [ jkczyz      ] [ notmandatory_   ] [ trev        ] 
02:20 [ belcher    ] [ elsirion_  ] [ jrawsthorne ] [ otoburb         ] [ valwal      ] 
02:20 [ blkncd     ] [ emzy       ] [ kcalvinalvin] [ real_or_random  ] [ willcl_ark  ] 
02:20 [ BlueMatt   ] [ FelixWeis  ] [ koolazer    ] [ RubenSomsen     ] [ yakshaver   ] 
02:20 [ BlueMatt[m]] [ fjahr      ] [ lightningbot] [ sandipndev123   ] 
02:20 [ cloudhead  ] [ gnusha     ] [ MatanHamilis] [ sanket1729      ] 
02:20 -!- Irssi: #bitcoin-rust: Total of 48 nicks [0 ops, 0 halfops, 0 voices, 48 normal]
02:21 -!- Channel #bitcoin-rust created Wed May 19 14:34:56 2021
02:23 -!- Irssi: Join to #bitcoin-rust was synced in 183 secs
03:07 -!- enick_524 [~afilini-m@2001:bc8:1828:245::2] has joined #bitcoin-rust
03:50 -!- darosior [~darosior@194.36.189.246] has quit [Remote host closed the connection]
03:54 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-rust
05:59 -!- enick_524 [~afilini-m@2001:bc8:1828:245::2] has quit [Ping timeout: 268 seconds]
07:12 -!- andytoshi [~apoelstra@user/andytoshi] has joined #bitcoin-rust
07:12 < andytoshi> oops, i was in #rust-bitcoin instead of here
07:12 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has joined #bitcoin-rust
07:12 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-rust
07:12 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has joined #bitcoin-rust
07:12 -!- johncantrell97[m [~johncantr@2001:470:69fc:105::1:3780] has joined #bitcoin-rust
07:12 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-rust
07:12  * andytoshi fixed his autojoin config
07:13 < andytoshi> anyway, i am gonna try to release a rust-secp release today. pls ping me if you want to include anything else
07:13 < andytoshi> elichai2: can i have a re-ack on the pr?
07:13 < andytoshi> https://github.com/rust-bitcoin/rust-secp256k1/pull/347
07:20 < elichai2> andytoshi: re-ACKed, I'm not enthusiastic about how #344 turned out, but it's not the end of the world
07:30 -!- Netsplit *.net <-> *.split quits: trev, RCasatta[m], jeremyrubin, RubenSomsen, dpc[m], stevenroose, greypw254, fjahr, belcher, achow101,  (+25 more, use /NETSPLIT to show all of them)
07:31 -!- Netsplit over, joins: thomaseizinger, BlueMatt[m], achow101, cloudhead, mycroft
07:32 -!- Netsplit over, joins: jeremyrubin, stevenroose, RubenSomsen, belcher, johncantrell97[m, kcalvinalvin, sebx2a, RCasatta[m]
07:32 -!- Netsplit over, joins: real_or_random, dpc[m], emzy, MatanHamilis
07:32 -!- Netsplit over, joins: michaelfolkson, trev, koolazer
07:32 < andytoshi> elichai2: wanna just change the conversion methods to work with u8s instead of i32s?
07:32 -!- Netsplit over, joins: elsirion_, ariard, fjahr, _0x0ff, greypw254, devrandom, jrawsthorne, stick
07:32 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has quit [Ping timeout: 250 seconds]
07:33 -!- johncantrell97[m [~johncantr@2001:470:69fc:105::1:3780] has quit [Ping timeout: 240 seconds]
07:33 -!- Netsplit over, joins: Guest985, otoburb, sanket1729, stick[m], valwal, BlueMatt, MatrixBot1234510
07:33 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has quit [Ping timeout: 260 seconds]
07:33 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has quit [Ping timeout: 250 seconds]
07:33 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Ping timeout: 245 seconds]
07:33 < elichai2> Why not bool? See https://github.com/bitcoin-core/secp256k1/blob/master/include/secp256k1_extrakeys.h#L89-L91
07:34 < elichai2> although bool means true or false, while we have 1 or 0 hmm
07:36 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has quit [Ping timeout: 250 seconds]
07:36 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has quit [Ping timeout: 252 seconds]
07:37 -!- koolazer [~koo@user/koolazer] has quit [Ping timeout: 256 seconds]
07:38 < elichai2> (as in bool inside of the `Parity` struct)
07:40 < andytoshi> elichai2: if you just want bool, you can use the opaque Parity type, which implements PartialEq/Eq so you can compare it with other parities
07:41 < andytoshi> i'm not sure why you would need to understand it further at the granularity of "is it true or false" but then not want to know the numeric value that is used by upstream and encoded in the tx data
07:41 < andytoshi> i guess, my view here is that neither parity is naturally "true" or "false", and that it should be represented instead by a custom enum
07:42 < andytoshi> and the conversion methods have to be there because this particular enum is represented in consensus code as an 8-bit number sometimes
07:42 < andytoshi> or i guess, as a 1-bit mask
07:43 < elichai2> yeah in consensus it can be a single bit, and users will probably need to serialize and store/transmit this value, so it's nice if it is a single bit after serialization and not a full i32
07:43 < andytoshi> my point is that a boolean isn't really a bit
07:43 < andytoshi> i guess, conventionally true is 1 and false is 0
07:43 < elichai2> sadly rust doesn't have a `u1` type, so bool / our enum is all we got
07:43 < andytoshi> yeah :/
07:44 < andytoshi> u1 would be what i want
07:44 < elichai2> right
07:44 < elichai2> we can do `pub enum Bit {One = 1, Zero = 0}` hehe
07:45 < elichai2> but honestly, I don't have an amazing alternative so this really isn't a blocker for a release from my end
07:47 < andytoshi> ok, cool. i agree that what we've done doesn't feel quite right
07:48 < andytoshi> `Bit` feels a bit closer, conceptually, but somehow worse from a usability/discoverability point of view
07:50 -!- koolazer [~koo@user/koolazer] has joined #bitcoin-rust
07:55 -!- johncantrell97[m [~johncantr@2001:470:69fc:105::1:3780] has joined #bitcoin-rust
07:55 < andytoshi> release done
07:58 < andytoshi> ok, have another release PR for secp-sys https://github.com/rust-bitcoin/rust-secp256k1/pull/357
07:59 -!- thomaseizinger [~thomaseiz@2001:470:69fc:105::16b2] has joined #bitcoin-rust
07:59 < elichai2> ACKed
08:01 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has joined #bitcoin-rust
08:03 < andytoshi> thanks. just waiting on CI
08:24 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has joined #bitcoin-rust
08:42 -!- b10c__ [uid500648@user/b10c] has joined #bitcoin-rust
08:49 -!- trev [~trev@user/trev] has quit [Quit: trev]
09:09 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-rust
09:22 -!- stick[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-rust
09:26 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has joined #bitcoin-rust
12:08 -!- trev [~trev@user/trev] has joined #bitcoin-rust
12:34 -!- trev [~trev@user/trev] has quit [Quit: trev]
18:02 -!- b10c__ [uid500648@user/b10c] has quit [Quit: Connection closed for inactivity]
--- Log closed Thu Jan 06 00:00:22 2022