--- Log opened Thu Jan 06 00:00:22 2022 02:43 -!- willcl_ark [~quassel@user/willcl-ark/x-8282106] has quit [Quit: Quit] 03:07 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has joined #bitcoin-rust 03:09 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has quit [Client Quit] 03:11 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has joined #bitcoin-rust 03:13 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has quit [Client Quit] 03:16 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has joined #bitcoin-rust 03:20 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has quit [Client Quit] 03:24 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has joined #bitcoin-rust 03:25 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has quit [Client Quit] 03:31 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has joined #bitcoin-rust 03:31 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has quit [Client Quit] 03:37 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has joined #bitcoin-rust 03:38 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has quit [Client Quit] 03:49 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has joined #bitcoin-rust 03:49 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has quit [Client Quit] 03:51 -!- willcl_ark_ [~quassel@user/willcl-ark/x-8282106] has joined #bitcoin-rust 03:53 -!- willcl_ark_ is now known as willcl_ark 03:54 -!- willcl_ark [~quassel@user/willcl-ark/x-8282106] has left #bitcoin-rust [] 04:31 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-rust 05:11 -!- trev [~trev@user/trev] has joined #bitcoin-rust 06:57 -!- darosior [~darosior@194.36.189.246] has quit [Quit: Ping timeout (120 seconds)] 08:23 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-rust 09:21 -!- trev [~trev@user/trev] has quit [Quit: trev] 11:00 -!- b10c__ [uid500648@id-500648.ilkley.irccloud.com] has joined #bitcoin-rust 14:46 < andytoshi> i'm a bit concerned about this wildcard `use key::*` in https://github.com/rust-bitcoin/rust-secp256k1/pull/361 14:46 < andytoshi> will it expose whatever random symbols exist in `key`? or just the pub ones? 14:49 < BlueMatt[m]> i don't think you can export non-pub things? of course probably better to specify either way, but I don't know that you can. 14:50 < andytoshi> oh, yeah, that makes sense 14:50 < andytoshi> ok, i'm happy (as i'm gonna be...I actually don't really like this wildcard export but don't feel strongly enough to argue it) 15:10 < sanket_cell_> Agreed. I don't like the i32 type. It really forces awkard conversions to bool in rust-bitcoin. 15:12 < sanket_cell_> I was going to add a function to support to and from bool. But did not want complicate the review (or delay the process) 15:22 < andytoshi> i'm curious in what cases you need to convert to bool 15:23 < andytoshi> but ok, i trust you 15:31 < sanket_cell_> It is the last bit of first byte of control block. See #755 (also a blocker for rust-bitcoin release) 15:40 < andytoshi> right ... but a bit is not a boolean 15:41 < andytoshi> also, did we land on i32? i thought we were going to return a u8 15:41 < andytoshi> hmm, yeah, i32 does seem like a shitty choice 15:42 < andytoshi> oh, yeah, i made a comment to this effect, then didn't follow up on it 15:42 < andytoshi> and then we did a major release and it'd be another major release to fix it. sigh 15:44 < andytoshi> if your goal is to use it as a bitmask though, i think a boolean would be even worse than an i32 15:44 < andytoshi> since an i32 is at least a number 15:45 < sanket_cell_> Agreed. 15:46 < sanket_cell_> I don't think it's a big deal have another major release. It's just a mild API inconvenience 15:47 < andytoshi> yeah, i just feel a bit silly, having acked the existing API without considering how it would be used 18:00 -!- b10c__ [uid500648@id-500648.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity] 22:59 -!- trev [~trev@user/trev] has joined #bitcoin-rust --- Log closed Fri Jan 07 00:00:23 2022