--- Log opened Mon Mar 28 00:00:39 2022 00:19 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has quit [Quit: Bridge terminating on SIGTERM] 00:19 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Quit: Bridge terminating on SIGTERM] 00:19 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has quit [Quit: Bridge terminating on SIGTERM] 00:19 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Quit: Bridge terminating on SIGTERM] 00:19 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has quit [Quit: Bridge terminating on SIGTERM] 00:19 -!- junderw[m] [~junderwma@2001:470:69fc:105::1:d922] has quit [Quit: Bridge terminating on SIGTERM] 00:24 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has joined #bitcoin-rust 00:29 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 00:30 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 00:31 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-rust 00:31 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has joined #bitcoin-rust 00:31 -!- junderw[m] [~junderwma@2001:470:69fc:105::1:d922] has joined #bitcoin-rust 00:31 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-rust 00:31 -!- RiccardoCasatta[ [~rcasattam@2001:470:69fc:105::c85] has joined #bitcoin-rust 00:34 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Quit: Reconnecting] 00:35 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:c825] has joined #bitcoin-rust 00:36 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:c825] has quit [Changing host] 00:36 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-rust 00:48 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 00:49 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 01:20 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 01:20 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 01:48 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 01:48 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 02:15 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 02:16 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 02:33 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 02:33 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 03:32 -!- trev [~trev@user/trev] has joined #bitcoin-rust 03:43 -!- emzy [~quassel@user/emzy] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 03:45 -!- emzy [~quassel@user/emzy] has joined #bitcoin-rust 04:05 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has quit [Quit: User was banned] 04:05 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Quit: User was banned] 04:05 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has quit [Quit: User was banned] 04:05 -!- junderw[m] [~junderwma@2001:470:69fc:105::1:d922] has quit [Quit: User was banned] 04:06 -!- RiccardoCasatta[ [~rcasattam@2001:470:69fc:105::c85] has quit [Quit: User was banned] 04:07 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Quit: User was banned] 04:56 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 04:56 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 05:26 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 05:27 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 05:41 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has quit [Remote host closed the connection] 05:41 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has joined #bitcoin-rust 05:45 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 05:45 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 05:48 < elichai2> junderw: Hi!, I'm trying to compile to wasm, and I'm getting `rust-lld: error: unknown file type: secp256k1.o` error, any ideas? 05:49 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has joined #bitcoin-rust 05:52 -!- trev [~trev@user/trev] has quit [Quit: trev] 05:57 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-rust 05:57 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has joined #bitcoin-rust 05:57 -!- junderw[m] [~junderwma@2001:470:69fc:105::1:d922] has joined #bitcoin-rust 05:57 -!- RiccardoCasatta[ [~rcasattam@2001:470:69fc:105::c85] has joined #bitcoin-rust 05:58 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:c825] has joined #bitcoin-rust 06:37 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 06:37 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 06:54 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 06:54 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 07:05 -!- dunxen [~dunxen@gateway/tor-sasl/dunxen] has joined #bitcoin-rust 07:22 < andytoshi> guise, we have 2 PRs left for rust-bitcoin 0.28 07:22 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/899 07:22 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/898 07:23 < andytoshi> both have a bunch of discussion and no ACKs. what's going on here 07:49 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 07:50 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 08:01 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 08:01 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 08:18 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 08:19 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 08:29 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 08:29 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 08:54 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 08:54 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 09:06 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 09:06 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 09:17 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 09:17 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 09:36 < sanket1729> andytoshi: I have ACKEd 898 and 914. Only two PRs remaining 09:46 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 09:47 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 10:10 < andytoshi> ok dope. merged 914. running tests on 898, will merge it when those finish 10:11 < andytoshi> what's up with 899? 10:23 < sanket1729> It is not tagged rc release 10:23 < sanket1729> did not look at it yet 10:24 < sanket1729> 898 appears to be only one PR remaining 10:34 < sanket1729> andytoshi: Should we do a release or a rc.2? 10:35 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 10:35 < andytoshi> let's do a rc.2 10:35 < jeremyrubin> sanket1729: not that you asked but it's always nice to do rc2 10:35 < andytoshi> but hopefully this one has no problems and we can do a real release by fri 10:35 < jeremyrubin> even if but for a couple days 10:36 < andytoshi> yep 10:36 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 10:36 < jeremyrubin> the main annoying thing is that without the Prevouts<'u> patch from rust-bitcoin in miniscript it's a bit annoying to test for me 10:36 < jeremyrubin> but i can review the diff from sapio-miniscript and sign off 10:37 < sanket1729> cool 10:37 < andytoshi> sanket1729: 899 is listed in https://github.com/rust-bitcoin/rust-bitcoin/milestone/10 fwiw 10:38 < sanket1729> I see, reviewing it 10:38 < sanket1729> For some reason, I find serde related code extremely hard to review 10:38 < sanket1729> dr-orlovsky: Are you here? 10:39 < sanket1729> Is 899 required for the release? 10:40 < andytoshi> i also find serde code hard to review. it's very complicated and boilerplate-heavy and i view it as completely ancillary to the library's actual goals 10:41 < andytoshi> and also it has dramatically different behavior when used with different serializers, and this is open-ended and impossible to test 10:43 < sanket1729> Looking at the PR description, this seems like a feature request. 10:44 < sanket1729> Anyways, it not that big 10:44 < sanket1729> Reviewing it now 10:44 < jeremyrubin> ok i reviewed the 2 that you noted andytoshi 10:44 < jeremyrubin> i'm kind of a mild nack on the human readable stuff 10:45 < jeremyrubin> might seem surprising given my advocacy for schemars, but generally i'm looking for the APIs to be *typed* in a usable way, less so the particulars of that typing beyond a certain point 10:46 < jeremyrubin> PSBTs, e.g., in schemars i would want typed as an encoded string because that's what i'd expect users to e.g. copy paste in from various tools 10:47 < jeremyrubin> for witnesses, i agree that a bytearray is a bad JSON representation though, but i generally don't expect to have people inputting witnesses manually anyways, but it do want to at least know what type it is for tooling purposes (e.g., writing APIs against it) 10:47 < jeremyrubin> the "best" JSON format IMO is the one that works easiest with bitcoinjs 10:48 < jeremyrubin> a last point of contention: late stage breaking API changes are really annoying for me and would dramatically slow down my rebasing onto the release vs what i've got already 10:48 < jeremyrubin> but i think i'm not impacted mostly since i already avoid the JSON reprs of PSBTs anyways 10:49 < jeremyrubin> * not API changes exactly -- changing a method name, easy. This is more like an ABI change? 10:51 < jeremyrubin> the format used by bitcoinjs for witness seems to be witness: Buffer[]; 10:53 < jeremyrubin> but it is very happy to, given a plain buffer, use a BuffeReader to read that out 10:53 < jeremyrubin> do with that as you will! 10:55 < jeremyrubin> tl;dr: i never use the human readable reprs for things like PSBT afaict, but if i do use them somewhere, this would make me have breaking bugs that would be annoying to fix / might be in random parts of the code, so i'd prefer not to have these since i never really show users or ask them for witness to be input anyways. I do think that an array of 10:55 < jeremyrubin> hex encoded elements seems reasonable for witnesses though for jsons. 10:58 < jeremyrubin> (and short of any of the above, i definitely won't have time to test those changes out thoroughly before Friday) 10:59 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 11:00 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 11:06 < sanket1729> andytoshi: https://github.com/rust-bitcoin/rust-bitcoin/pull/915 11:16 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 11:17 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 11:31 < andytoshi> dope, i'll review and merge this 11:32 < andytoshi> welll actually let's get a 3rd ack 11:32 < andytoshi> tho as dr-orlovsky says, it's "only" rc2 11:35 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 11:35 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 12:16 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 12:17 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 12:29 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 12:30 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 12:42 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 12:42 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 13:04 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 13:05 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 13:37 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 13:38 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 13:49 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 13:49 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 13:51 < andytoshi> published rc2 14:20 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 14:21 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 14:25 < jeremyrubin> 🎉🎉🎉 14:28 < sanket1729> AWesome 14:42 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 14:43 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 14:47 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 14:49 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 15:08 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 15:09 -!- shesek__ [~shesek@user/shesek] has quit [Read error: Connection reset by peer] 15:30 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 15:30 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 15:35 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 15:35 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 16:03 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 16:03 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 17:20 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity] 17:50 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 17:52 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 17:57 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 17:57 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 18:52 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 18:52 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 19:27 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 19:28 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 20:06 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 20:06 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 20:08 -!- junderw [~junderw@179.170.75.170.lunanode-rdns.com] has quit [Quit: The Lounge - https://thelounge.chat] 20:14 -!- junderw [~junderw@179.170.75.170.lunanode-rdns.com] has joined #bitcoin-rust 20:29 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 20:29 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 21:17 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 21:18 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 21:34 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 21:35 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 22:11 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 22:11 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 22:50 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 22:51 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 23:06 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 23:07 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 23:38 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 23:39 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust --- Log closed Tue Mar 29 00:00:39 2022