--- Log opened Tue Mar 29 00:00:39 2022 00:11 -!- trev [~trev@user/trev] has joined #bitcoin-rust 00:20 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 00:21 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 00:27 < junderw[m]> > the "best" JSON format IMO is the one that works easiest with bitcoinjs 00:27 < junderw[m]> We don't support JSON to Psbt. Right now we only offer (from|to)(Hex|Base64|Buffer) and we expose the constructor which accepts a transaction wrapper (to help enable some alternative forks). 00:27 < junderw[m]> I would be open to discussions regarding a JSON format, but think the binary nature of the format is already well defined enough. 00:27 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 00:29 -!- shesek__ [~shesek@user/shesek] has quit [Read error: Connection reset by peer] 01:13 < RiccardoCasatta[> rust-bitcoin now has more than a thousand stars on github! ⭐️ 01:20 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 01:20 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 01:26 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 01:26 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 01:45 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 01:46 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 02:00 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has quit [Quit: You have been kicked for being idle] 02:13 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 02:13 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 02:20 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 02:22 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 02:30 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 02:30 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 03:06 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 03:06 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 03:29 -!- Jackielove4u [uid43977@user/jackielove4u] has joined #bitcoin-rust 03:34 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 03:35 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 03:37 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 03:37 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 03:53 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 03:54 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 04:07 -!- shesek_ [~shesek@user/shesek] has joined #bitcoin-rust 04:08 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 04:54 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection] 05:30 -!- dunxen [~dunxen@gateway/tor-sasl/dunxen] has quit [Remote host closed the connection] 09:02 < jeremyrubin> junderw[m]: +1 -- hence advocating for sending it over as a base64 string 09:02 < jeremyrubin> that's the most common format 09:03 < jeremyrubin> if you want to present it to a user, easy enough to parse it and then have the actual object 09:07 < junderw[m]> jeremyrubin: Excuse my ignorance, but is the PR in question more geared towards end-users (ie. shown to users of apps that utilize the library) or is it more geared towards app devs (ie. easier debug log printing when adding new features) If the latter, my opinion might change a bit... (https://github.com/bitcoinjs/bitcoinjs-lib/issues/1787#issuecomment-1080362146) 09:08 < junderw[m]> (JS wonderful [Object] vs. {} display in the console caused confusion (I guess)) 09:09 < junderw[m]> (fyi, I only link the issue to show as an example of how the display in console can lead to confusion sometimes... the library does not make use of rust-bitcoin...... yet) 09:17 < junderw[m]> Human readable repr does help when writing tests / creating test vectors though, imo. 09:17 < junderw[m]> I remember working on the psbt test vectors was quite a pain when I wasn't sure my implementation was working... I had to go off of text explanations of what was contained in a big b64 blob. 09:18 < junderw[m]> But yeah, is it worth breaking changes? No imo. 09:53 -!- dunxen [~dunxen@gateway/tor-sasl/dunxen] has joined #bitcoin-rust 09:55 < jeremyrubin> junderw[m]: that's my point, more or less. if you want a human readable representation, that that's a different concern than using serde to make a machine parsable JSON 11:48 -!- trev [~trev@user/trev] has quit [Quit: trev] 15:10 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:c825] has quit [Changing host] 15:10 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-rust 15:14 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Quit: Reconnecting] 15:14 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:c825] has joined #bitcoin-rust 15:15 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:c825] has quit [Changing host] 15:15 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-rust 15:33 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Quit: Reconnecting] 15:33 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:c825] has joined #bitcoin-rust 15:33 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:c825] has quit [Client Quit] 15:33 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:c825] has joined #bitcoin-rust 15:33 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:c825] has quit [Changing host] 15:33 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-rust 15:52 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Quit: Reconnecting] 15:52 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:c825] has joined #bitcoin-rust 15:53 -!- willcl_ark [~willcl-ar@2001:470:69fc:105::1:c825] has quit [Changing host] 15:53 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-rust 16:03 -!- willcl_ark is now known as willcl-ark 16:05 -!- willcl-ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Quit: Reconnecting] 16:05 -!- willcl-ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-rust 16:06 -!- willcl-ark is now known as willcl_ark 16:06 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Client Quit] 16:06 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-rust 19:34 -!- mplsgrant [~mplsgrant@68-168-187-155.fttp.usinternet.com] has joined #bitcoin-rust 19:37 -!- mplsgrant [~mplsgrant@68-168-187-155.fttp.usinternet.com] has quit [Client Quit] 19:37 -!- mplsgrant [~mplsgrant@68-168-187-155.fttp.usinternet.com] has joined #bitcoin-rust 19:43 -!- mplsgrant14 [~mplsgrant@68-168-187-155.fttp.usinternet.com] has joined #bitcoin-rust 19:43 -!- mplsgrant14 [~mplsgrant@68-168-187-155.fttp.usinternet.com] has quit [Client Quit] 21:50 -!- trev [~trev@user/trev] has joined #bitcoin-rust --- Log closed Wed Mar 30 00:00:40 2022