--- Log opened Thu Apr 14 00:00:56 2022 01:16 -!- darosior [~darosior@194.36.189.246] has quit [Remote host closed the connection] 01:17 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-rust 01:20 -!- real_or_random_ [~real_or_r@user/real-or-random/x-4440763] has joined #bitcoin-rust 01:22 -!- real_or_random [~real_or_r@user/real-or-random/x-4440763] has quit [Quit: ZNC 1.8.2 - https://znc.in] 05:41 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has quit [Remote host closed the connection] 05:42 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has joined #bitcoin-rust 07:42 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 07:46 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 07:46 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 09:10 < sanket1729> andytoshi: can you look at release blocking 924 and 929? 924 already has two ACKs, 09:24 < andytoshi> yes, i can do that in a couple minutes 09:24 < andytoshi> sorry for the delay 09:24 < andytoshi> it's been a long week 09:46 < andytoshi> sanket1729: in your opinion should we bother with a nother rc? 09:46 < andytoshi> these PRs do technically break the API and deserve another round ... but OTOH who cares, we know we're close 09:47 < andytoshi> and this is much better than any past release :P 09:47 < andytoshi> and i think we're all tired 09:47 < sanket1729> I am want to get through with it. Party because it will some time before we get another release 09:47 < sanket1729> thorugh with the direct release 09:48 < sanket1729> andytoshi: We have never had rc cycles before. It was a good learning experience, but I think we are over-doing it for this one now 09:49 < andytoshi> ack 09:49 < andytoshi> ok, gimme 10-20 mins 09:49 < sanket1729> cool 09:53 < andytoshi> sanket1729: :/ i think 929 has some problems actually 09:53 < andytoshi> and idk if dr orlovsky is around or willing to contribute to this project rn 09:54 < sanket1729> Can you comment on the PR about the issue? 09:54 < andytoshi> yeah, i did 09:54 < andytoshi> one issue is that `is_finalized` does not make any sense as a name, but whatever, i don't need this method and we can just deprecate it later 09:54 < andytoshi> the other is this || vs && thing which seems like a "real" issue 09:55 < andytoshi> though it could be addressed in a followup pr 09:57 < sanket1729> Yeah, the if condition is a serious issue 09:57 < sanket1729> good catch 09:57 < sanket1729> How do you suggest we proceed? 09:58 < andytoshi> sanket1729: i think we should merge 929 and then open a followup PR which changes the || to && (if you agree we should do this) 09:58 < andytoshi> the is_finalized() thing we can leave alone 09:58 < sanket1729> Cool 09:58 < andytoshi> i'm sure we'll do some more thorough taproot+psbt API change in the future, let's not make any potentially-controversial changes now 09:58 < andytoshi> i can ack and merge 929 now 09:58 < andytoshi> one moment 09:59 < sanket1729> Working on the PR now. It will take some time to get a second ACK for it. Can we borrow elsirion for a moment? 09:59 < andytoshi> i don't thin elsirion is a maintainer on this repo 10:00 < sanket1729> Oh, right 10:01 < andytoshi> kixunil or elichai2 may be available 10:01 < andytoshi> oh, and tcharding 10:03 < andytoshi> ok merged 929 10:03 < andytoshi> sigh 924 now doesn't merge 10:04 < andytoshi> i kinda like it but it isn't _really_ necessary to the release .. it basically cleans up some LeafInfo stuff 10:04 < andytoshi> i guess it exposes the leaf version when you iterate over a taptree, which is potentially necessary 10:08 < sanket1729> It is not necessary. It is nice cleanup 10:15 < sanket1729> andytoshi: I just realized that having the && or || there is irrelevant. 10:15 < sanket1729> && is cleaner and more future proof 10:16 < sanket1729> Because we cannot parse hidden nodes yet. There is no way we can create a tree with hidden nodes 10:21 < andytoshi> heh ok 10:21 < andytoshi> but that sounds pretty tenuous 10:21 < andytoshi> liek, if we later add the ability to parse hidden nodes, we'd have to remember to fix this? 10:22 < sanket1729> Yeah, raised https://github.com/rust-bitcoin/rust-bitcoin/pull/950 10:22 < sanket1729> It passed all CI checks 10:22 < andytoshi> dope, will review and ack shortly 10:22 < sanket1729> I was trying to create failing test vectors, but could not 10:23 < sanket1729> when I realized, this is not possible 10:26 -!- darosior0 [~darosior@194.36.189.246] has joined #bitcoin-rust 10:33 -!- Netsplit *.net <-> *.split quits: BlueMatt, darosior 10:33 -!- darosior0 is now known as darosior 10:37 -!- BlueMatt_ [~BlueMatt@ircb.bluematt.me] has joined #bitcoin-rust 10:49 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 10:49 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 11:05 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] 11:05 -!- shesek__ [~shesek@user/shesek] has joined #bitcoin-rust 11:23 -!- shesek__ [~shesek@user/shesek] has quit [Remote host closed the connection] --- Log closed Fri Apr 15 00:00:56 2022