--- Log opened Wed Apr 20 00:00:00 2022 02:18 -!- b10c [~quassel@user/b10c] has joined #bitcoin-rust 03:17 -!- duderonomy [~duderonom@c-73-158-190-156.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 04:35 -!- wybpip[m] [~wybpipmat@2001:470:69fc:105::1:f452] has joined #bitcoin-rust 04:36 -!- wybpip[m] [~wybpipmat@2001:470:69fc:105::1:f452] has left #bitcoin-rust [] 04:59 -!- elsirion_ [~quassel@gateway/tor-sasl/elsirion] has joined #bitcoin-rust 05:03 -!- elsirion [~quassel@gateway/tor-sasl/elsirion] has quit [Ping timeout: 240 seconds] 07:49 -!- achow101 [~achow101@user/achow101] has quit [Quit: Bye] 07:50 -!- achow101 [~achow101@user/achow101] has joined #bitcoin-rust 08:36 -!- duderonomy [~duderonom@c-73-158-190-156.hsd1.ca.comcast.net] has joined #bitcoin-rust 10:31 < sanket1729_> andytoshi: Are you up for a 4/20 release? KixUnil is also suggesting that we get 927 in. It already has two ACKs 10:32 < sanket1729_> Does not need mention in release notes. So we can also merge the release PR right afterwards 10:33 < andytoshi> sure. will be within the next 20 mins 10:36 < andytoshi> lemme run the gamut of tests on 927, it shouldn't take too much longer 10:46 < andytoshi> 0.28.0 tagged and published 10:46 < sanket1729_> awesome! 10:46 < sanket1729_> finally 10:46 < sanket1729_> We need to wait for 4.20 That's all 10:47 < andytoshi> hahah 10:47 < andytoshi> BTW do we need a MSRV release "no changes, just msrv" 10:47 < andytoshi> i had planned to do this, but now i can't recall what my reasoning was 10:49 < sanket1729_> I think that has a long list of things that fix first. https://github.com/rust-bitcoin/rust-bitcoin/issues/510 10:51 < andytoshi> sanket1729_: so my thinking was that we wouldn't anything in 0.29.0 10:51 < andytoshi> 0.29.0 would just be a dummy release 10:52 < sanket1729_> What's the rationale for it? 10:52 < andytoshi> i think i was confused 10:52 < andytoshi> it makes sense for things like, bumping the major rev of dependencies 10:52 < andytoshi> you want to do a series of tiny major releases so that people can update piecemeal 10:52 < andytoshi> but for a MSRV .... users can update their toolchain whenever they want 10:53 < andytoshi> they can update to 0.28, update their toolchain (and fix whatever issues this plausibly could cause), then go to 0.29.0 (which would require 1.41) 15:01 < jeremyrubin> andytoshi: i think it makes sense to do a neutral MSRV update version 15:02 < jeremyrubin> the worst case is where MSRV is treated as a minor and your semver resolver will automatically bump you to something that doesn't work on your toolchain 15:02 < jeremyrubin> having a dummy release 0.29 means that 0.29 is *just* the breaking change of MSRV swap 15:02 < jeremyrubin> and then 0.30 can be that + other breaking changes 15:03 < jeremyrubin> technically, 0.29.1 could have minor fixes go into it too, but no breaking changes 15:23 < andytoshi> jeremyrubin: the thing is that a MSRV bump isn't breaking unless cargo forces it on you 15:23 < andytoshi> if i'm a user who wants to move to 0.29.0, i can stick with 0.28.0 while i update my toolchain and work out kinks 15:23 < andytoshi> and then go to 0.29 15:24 < andytoshi> i don't need 0.29 to be a neutral release 16:12 < jeremyrubin> correct. 16:12 < jeremyrubin> you just *should* make MSRV bump into any breaking release 16:12 < jeremyrubin> it's just annoying if theres a bunch of features that don't need to be in the MSRV bump that also get it 16:13 < jeremyrubin> so you shouldn't bump MSRV until there's a plan, or do a clean break where it's just MSRV bump 16:13 < jeremyrubin> what's confusing is if you don't use the MSRV feature somewhere in the new code since then it can mysteriously stop working 16:14 < jeremyrubin> so it'd make sense in 0.29 to e.g. commit one function using some feature from that MSRV so you can only use it if you actually have that compiler 16:24 -!- jetpack [~jetpack@2605:2700:1:100e:ddb4:196e:c17a:3b92] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in] 16:24 -!- jetpack [~jetpack@2605:2700:1:100e:ddb4:196e:c17a:3b92] has joined #bitcoin-rust 18:40 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 250 seconds] 19:09 -!- belcher [~belcher@user/belcher] has joined #bitcoin-rust 23:01 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 250 seconds] 23:03 -!- belcher [~belcher@user/belcher] has joined #bitcoin-rust --- Log closed Thu Apr 21 00:00:02 2022