--- Log opened Mon Aug 15 00:00:51 2022 02:54 -!- evanlinj1 [~root@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection] 02:56 -!- evanlinj1 [~root@gateway/tor-sasl/evanlinjin] has joined #bitcoin-rust 02:58 -!- evanlinj1 [~root@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection] 02:58 -!- evanlinj1 [~root@gateway/tor-sasl/evanlinjin] has joined #bitcoin-rust 04:29 -!- Lorenzo [~Lorenzo@189.4.77.141] has joined #bitcoin-rust 04:33 -!- trev [~trev@user/trev] has quit [Remote host closed the connection] 05:30 -!- Lorenzo [~Lorenzo@189.4.77.141] has quit [Quit: Client closed] 05:44 -!- tibo_ [~tibo@fp5a950abc.tkyc110.ap.nuro.jp] has quit [] 07:34 -!- Amnesia [~Amnesia@user/amnesia] has joined #bitcoin-rust 08:14 -!- pablomartin [~pablomart@185.93.182.252] has joined #bitcoin-rust 10:06 -!- pablomartin [~pablomart@185.93.182.252] has quit [Quit: Leaving] 12:26 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has joined #bitcoin-rust 14:00 -!- evanlinj1 [~root@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection] 14:00 -!- evanlinj1 [~root@gateway/tor-sasl/evanlinjin] has joined #bitcoin-rust 14:44 -!- darosior [~darosior@194.36.189.246] has quit [Read error: Connection reset by peer] 14:46 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-rust 14:55 < andytoshi> heh that's a good illustration 14:56 < andytoshi> so, i can no longer build honggfuzz :/ i need https://github.com/google/honggfuzz/commit/90fdf81006614664ef05e5e3c6f94d91610f11b2 from 2 months ago which hasn't made it into cargo-honggfuzz 14:56 < andytoshi> the linux headers changed in some breaking way recently 14:56 < BlueMatt> it seems cargo-honggfuzz is completely unamintained now :( 14:56 < BlueMatt> issues going back a long ways are ignored 14:58 < BlueMatt> should probably ping a maintainer and ask if they want to maintain it 14:59 < andytoshi> ykes, frustrating 14:59 < andytoshi> i wonder what to do then.. 14:59 < BlueMatt[m]> at this point I'm considering having a "zero rust-language dependencies" rule. all dependencies must be installable via apt-get and not be in rust. 15:00 < BlueMatt[m]> but really, we should start by pinging the maintainers 15:00 < BlueMatt[m]> and asking if they have interest in continuing to maintain 15:00 < andytoshi> yeah 15:00 < andytoshi> fwiw this one is not really their fault .. other than that they're AWOL 15:01 < BlueMatt[m]> yea, sure, there's been a few issues on honggfuzz that arent their fault 15:01 < BlueMatt[m]> just unmaintained 15:03 < andytoshi> are you willing to ping the maintainers and offer to take over? 15:03 < andytoshi> i think you're more qualified than any of us 15:04 < andytoshi> i could ask tobin to do it actually, he was a kernel dev in a past life 15:05 < andytoshi> actually http://tobin.cc/resume/ shows a fair bit of directly relevant experience ... maybe i should ask him 15:05 < andytoshi> it's a thankless job ofc, having cargo breaking you from one side and google and linux breaking you from the other 15:06 < jeremyrubin> https://github.com/rust-bitcoin/rust-bitcoin/blob/67e88e732ce6953baf32e248c42829a5a779d31e/src/util/psbt/serialize.rs#L325 15:06 < jeremyrubin> this line seems to in fact be reachable 15:07 < andytoshi> jeremyrubin: oof good catch 15:07 < andytoshi> i think we recently did some refactoring that could lead to that 15:08 < andytoshi> can you open an issue? 15:08 < jeremyrubin> i have the same line in my sapio fork 15:08 < jeremyrubin> example of a psbt that hits it 15:08 < jeremyrubin> cHNidP8BAIkCAAAAAWlZ9F5/nRjE0quO8bE8cfKIiVTKHa/Zu6PKwWfpZDmpAAAAAAD9////Anz3nHYAAAAAIlEg7T17MEFOm47gN7FhZB5g4HjviGW4YxZWReJr1c/w0I+AlpgAAAAAACJRIDspRhxBQj5+aJw088IczFSbyRKB7wofy/SQXnErwCcQAAAAAAABASsAlDV3AAAAACJRIBMUosKNoVNU5tEW2Q/tylLRzabMGIprODHM0LbB8h1/IRaXdf3KRBBZMc8epg7uuU3pr42i3YMFnheNDW10F0cpnxkAHzYIzlYAAIABAACAAAAAgAAAAABRAAAAARcgl3X9ykQQWT 15:08 < jeremyrubin> HPHqYO7rlN6a+Not2DBZ4XjQ1tdBdHKZ8AAQUgT+NhtL213EJgJ51h6FiZYhPgUv48YQKACnnMYpOZPMEBBgAhB0/jYbS9tdxCYCedYehYmWIT4FL+PGECgAp5zGKTmTzBGQAfNgjOVgAAgAEAAIAAAACAAQAAADEBAAAAAQUgrUXPD+fhaOeY7GlxJDZ0pAgUZ0reW+A3wmxMwBAIt14BBgAhB61Fzw/n4WjnmOxpcSQ2dKQIFGdK3lvgN8JsTMAQCLdeGQAfNgjOVgAAgAEAAIAAAACAAAAAAFIAAAAA 15:08 < jeremyrubin> (i can see if i can get a tighter bound on it) 15:08 < andytoshi> yeah .. you can see that the deserialization code has support for incomplete trees but our serializaiton code doesn't.. 15:08 < andytoshi> i'm surprised the fuzzer didn't find this 15:08 < jeremyrubin> i am fuzzer 15:08 < andytoshi> though if you see above, we can no longer fuzz on my computer :| 15:09 < BlueMatt[m]> does anyone give the fuzzer a ton of cpu time? 15:09 < andytoshi> i do, very intermittently 15:09 < andytoshi> like, 2 or 3 times a year i'll run it for a few days because i'll think about it and not have anything else to do 15:09 < andytoshi> somebody gave me instructions to deprioritize it so i could run it 24/7 but then i never did it :( 15:09 < BlueMatt[m]> `nice -n 20`? 15:09 < andytoshi> yeah something like that 15:10 < BlueMatt[m]> jeremyrubin: lol, apparently... 15:11 < jeremyrubin> we should generally probably not let ser/deser code panic 15:11 < andytoshi> well if it was legitimately unreachable it would've been reasonable 15:11 < andytoshi> like, if we enforced at the type boundary that the trees were complete, how would you have written the code differently? 15:13 < jeremyrubin> can the Taptree at that point be finalized? 15:14 < BlueMatt[m]> "are you willing to ping the..." <- as for honggfuzz, I can ping them, dunno if I have time to take over, but I can at least ask if they're maintaining. 15:14 < jeremyrubin> Also i think this is why Serde does serialize trait return result :) 15:15 < M1asdfah[m]> https://github.com/bitcoin-core/btcdeb/blob/master/doc/tapscript-example-with-tap.md when you try to finalize a tx on retest with the follow data the finalization step fails because there is something “wrong with bobs pre image” 15:16 < M1asdfah[m]> But it works with the tap tool so I think there is something wrong with script spending finalization step 15:18 < M1asdfah[m]> Should I make a git issue for this ? 15:20 < M1asdfah[m]> But when you implement the same logic with the tap tool there is not issue 15:20 < M1asdfah[m]> s/not/no/ 15:22 < andytoshi> BlueMatt[m]: ok, thanks, please ping them 15:24 < BlueMatt[m]> Already done 15:29 < M1asdfah[m]> s/follow/following/ 16:40 -!- tibo [~tibo@240d:1a:afa:4000:a57b:3914:aeab:f76e] has joined #bitcoin-rust 17:15 -!- tibo_ [~tibo@fp5a950abc.tkyc110.ap.nuro.jp] has joined #bitcoin-rust 17:18 -!- tibo [~tibo@240d:1a:afa:4000:a57b:3914:aeab:f76e] has quit [Ping timeout: 244 seconds] 19:02 -!- Guest61 [~Guest61@103.166.253.90] has joined #bitcoin-rust 19:08 -!- Guest61 [~Guest61@103.166.253.90] has quit [Quit: Client closed] 19:29 < M1asdfah[m]> https://github.com/rust-bitcoin/rust-bitcoin/issues/1195 19:45 < jeremyrubin> M1asdfah[m]: if you have a look it looks like you're not providing any witness data before finalizing 19:45 < jeremyrubin> you would need to manually input the Witness into the PSBT 19:48 < M1asdfah[m]> So would I just put it in the unsigned_tx then try to finalize the transaction? 20:05 < M1asdfah[m]> "you would need to manually input..." <- wouldn't that be the point of https://github.com/rust-bitcoin/rust-miniscript/blob/9fd9aa46a8df3a7463456e947c94490f4887e74a/src/psbt/finalizer.rs#L38 --- Log closed Tue Aug 16 00:00:52 2022