--- Log opened Wed Oct 19 00:00:52 2022
00:01 -!- junderw3 [~junderw@179.170.75.170.lunanode-rdns.com] has joined #bitcoin-rust
00:08 -!- junderw3 [~junderw@179.170.75.170.lunanode-rdns.com] has quit [Quit: Ping timeout (120 seconds)]
00:08 -!- junderw3 [~junderw@179.170.75.170.lunanode-rdns.com] has joined #bitcoin-rust
00:54 -!- tibo_ [~tibo@fp5a950abc.tkyc110.ap.nuro.jp] has joined #bitcoin-rust
00:58 -!- tibo [~tibo@240d:1a:afa:4000:c840:c6d0:fba6:4f2a] has quit [Ping timeout: 268 seconds]
01:09 -!- b42 [~mmilata@2a01:430:17:1::ffff:586] has joined #bitcoin-rust
06:08 -!- tibo_ [~tibo@fp5a950abc.tkyc110.ap.nuro.jp] has quit []
07:54 -!- angusp [9e8eed9774@2604:bf00:561:2000::1048] has joined #bitcoin-rust
09:11 < andytoshi> jeremyrubin: ah, one other reason was that PackedLockTime has Ord on it, while LockTime does not
09:12 < andytoshi> i still don't think that's a good enough reason to have PackedLockTime, but it may be a long argument if i try to remove it
09:12 < andytoshi> i will propose impl'ing Ord on Transaction, but not on LockTime -- the Transaction impl will convert the LockTime to a u32 before comparing
09:13 -!- orville [~orville@50-242-118-141-static.hfc.comcastbusiness.net] has joined #bitcoin-rust
09:25 -!- orville [~orville@50-242-118-141-static.hfc.comcastbusiness.net] has quit [Ping timeout: 264 seconds]
09:32 -!- orville [~orville@c-67-170-226-157.hsd1.ca.comcast.net] has joined #bitcoin-rust
09:53 -!- pablomartin [~pablomart@185.199.100.60] has joined #bitcoin-rust
11:58 -!- pablomartin [~pablomart@185.199.100.60] has quit [Ping timeout: 246 seconds]
12:39 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection]
12:40 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust
14:15 < jeremyrubin> hmm why shouldn't locktime be ord?
14:15 < jeremyrubin> is it because it's nonsense to have time and height be one before the other?
14:16 < jeremyrubin> it seems like just oversight, I'd say just impl Ord on LockTime as into::<PackedLockTime>() and then ord?
14:16 < jeremyrubin> and make PackedLockTime just a non pub type, don't delete the code itself
14:16 < jeremyrubin> that way any code that is migrating will see identical sort order
14:19 < andytoshi> jeremyrubin: right, there is no sensible total ordering on LockTime
14:20 < andytoshi> it was hardly an "oversight", we had a very long discussion about it, which led to the PackedLockTime/LockTime bifurcation
14:20 < andytoshi> jeremyrubin: if PackedLockTime were non-public what purpose would it serve?
14:21 < andytoshi> and i don't know what you mean by "that way code that is migrating will see identical sort order" ... there was never any Ord impl on LockTime
15:01 < jeremyrubin> if you delete PackedLockTime, then code that used to have it will need to switch to LockTime
15:02 < jeremyrubin> keeping it non-public and keeping it's ord impl as a delegating wrapper would keep LockTime's ord consistent with PackedLockTime
15:04 < jeremyrubin> OTOH i don't particularly know why for this field it's super useful to be able to Ord it, other than for transaction
15:04 < jeremyrubin> I just know i'd be kinda annoyed as a library user if I got a "X is deprecated use Y" and Y does not impl something X does
15:04 < jeremyrubin> (I don't personally do this anywhere I'm aware of, so don't worry about me)
16:01 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection]
16:01 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust
16:35 -!- tibo [~tibo@240d:1a:afa:4000:f125:4326:57b8:f012] has joined #bitcoin-rust
17:42 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection]
17:42 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust
18:00 -!- orville_ [~orville@67.170.226.157] has joined #bitcoin-rust
18:03 -!- orville [~orville@c-67-170-226-157.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds]
18:03 -!- orville_ is now known as orville
18:32 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection]
18:33 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust
18:53 -!- Netsplit *.net <-> *.split quits: orville
18:54 -!- orville [~orville@c-67-170-226-157.hsd1.ca.comcast.net] has joined #bitcoin-rust
19:24 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection]
19:24 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust
21:05 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection]
21:06 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust
21:26 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection]
21:26 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust
23:51 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection]
23:51 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust
--- Log closed Thu Oct 20 00:00:53 2022