--- Log opened Thu Oct 20 00:00:53 2022 00:01 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 00:01 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 00:25 -!- trev [~trev@user/trev] has joined #bitcoin-rust 00:26 -!- trev [~trev@user/trev] has quit [Remote host closed the connection] 00:27 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 00:27 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 01:06 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 01:06 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 01:17 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 01:18 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 02:08 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 02:09 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 02:32 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 02:33 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 02:45 -!- tibo_ [~tibo@fp5a950abc.tkyc110.ap.nuro.jp] has joined #bitcoin-rust 02:49 -!- tibo [~tibo@240d:1a:afa:4000:f125:4326:57b8:f012] has quit [Ping timeout: 272 seconds] 02:59 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 02:59 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 03:16 -!- orville [~orville@c-67-170-226-157.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds] 03:16 -!- orville [~orville@c-67-170-226-157.hsd1.ca.comcast.net] has joined #bitcoin-rust 03:23 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 03:23 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 03:50 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 03:51 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 04:13 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 04:13 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 04:41 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 04:41 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 05:05 -!- tibo_ [~tibo@fp5a950abc.tkyc110.ap.nuro.jp] has quit [] 05:29 -!- trev [~trev@user/trev] has joined #bitcoin-rust 06:21 < andytoshi> jeremyrubin: well, we'll see if we get complaints. but Ord on a locktime is a misfeature and i'm not aware of anybody using it and it's very easy to work around 06:22 < andytoshi> i'd be pretty annoyed as a library user if i tried to compare two times, got an incoherent result, my code was wrong and my users lost money 06:22 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 06:22 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 06:45 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 06:45 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 07:32 < darosior> I just upgraded from rust-bitcoin 0.27 to 0.29, and i'm curious what was the rationale for not allowing nonstandard sighash types. 07:32 < darosior> I'm reading the implementation of `Deserialize` for `EcdsaSig`, and i'm having a hard time understanding this comment https://github.com/rust-bitcoin/rust-bitcoin/blob/938b61bf6632cc32cd352f417928975d4f0050b0/bitcoin/src/util/psbt/serialize.rs#L112-L115. It essentially states "[Using nonstandard sighash types] would cause to have invalid 07:32 < darosior> signatures because [...] the verification would check the signature assuming sighash_u32 as `0x01`". If "the verification" is Bitcoin Core's interpreter that's not how it works: it will pop the last byte of the signature and use that as the hash type. So you can use any nonstandard hashtype as long as you append the same to your signature as you 07:32 < darosior> committed to in the signature. 07:32 < darosior> I don't really care about using exotic hashtypes but i'm curious because it makes rust-bitcoin's PSBT deserializer differ from other deserializers (such as Bitcoin Core's one). 07:34 < andytoshi> darosior: the issue is that our sighash enum does not have any notion of nonstandard sighashtypes, it just coerces them all to SIGHASH_ALL (which is what they semantically are) 07:34 < andytoshi> this has always been true, since we had a sighash enum 07:35 < andytoshi> what changed recently was just that we stopped parsing things that we would've mangled 07:35 < darosior> Oh ok, so "the verification" refers to the verification in rust-bitcoin 07:35 < darosior> Ok 07:37 < andytoshi> yeah 07:37 < andytoshi> iirc we have an issue to fix the sighash enum situation but idk where we landed 07:38 < andytoshi> part of the issue is that ECDSA and Schnorr have different sets of sighash flags, and then PSBT combines them into one field whose meaning is very hard to infer from context, so PSBT needs its own enum 07:42 < andytoshi> darosior: https://github.com/rust-bitcoin/rust-bitcoin/issues/777 i think is the issue about this 07:43 < andytoshi> though there are a bunch of related issues 07:44 < darosior> Ok 👍 07:46 -!- orville [~orville@c-67-170-226-157.hsd1.ca.comcast.net] has quit [Ping timeout: 272 seconds] 07:47 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 07:47 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 07:48 < andytoshi> we had a bunch of rust-bitcoin devs together in atlanta recently, it might've been nice for us to do a triage of all the open issues .. but we were pretty busy having similar meetings about libsecp and miniscript and didn't find time 07:55 -!- trev [~trev@user/trev] has quit [Remote host closed the connection] 08:43 -!- elichai2 [sid212594@id-212594.hampstead.irccloud.com] has joined #bitcoin-rust 08:48 -!- orville [~orville@45.16.96.170] has joined #bitcoin-rust 08:55 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 08:55 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 09:05 -!- orville [~orville@45.16.96.170] has quit [Ping timeout: 260 seconds] 09:26 < jeremyrubin> rust-bitcoin conference time? 09:37 -!- orville [~orville@c-67-170-226-157.hsd1.ca.comcast.net] has joined #bitcoin-rust 09:44 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 09:44 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 10:07 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 10:07 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 10:36 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 10:36 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 10:50 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 10:51 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 10:57 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 10:58 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 11:22 -!- sanket_cell [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has quit [Quit: ZNC 1.8.2 - https://znc.in] 11:22 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has quit [Quit: ZNC 1.8.2 - https://znc.in] 11:23 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-rust 11:23 -!- sanket_cell [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-rust 11:32 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 11:33 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 11:58 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 11:58 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 12:05 -!- greypw2546002 [~greypw254@grey.pw] has quit [Remote host closed the connection] 12:06 -!- greypw2546002 [~greypw254@grey.pw] has joined #bitcoin-rust 13:56 < BlueMatt[m]> remailer-client-a5316ae04831a2@privacysvcs.net LFG 13:56 < BlueMatt[m]> lol oops 13:56 < BlueMatt[m]> LFG 16:23 -!- tibo [~tibo@240d:1a:afa:4000:f8f9:2e6c:bf83:f33b] has joined #bitcoin-rust 16:42 < stevenroose> Is there a reason the bitcoin crate comes with Cargo.lock nowadays? 18:47 * orville me 19:09 < orville> $chan 19:09 * orville $chan 20:33 -!- tibo [~tibo@240d:1a:afa:4000:f8f9:2e6c:bf83:f33b] has quit [Remote host closed the connection] 20:50 < BlueMatt[m]> IIRC to provide a set of “blessed” (and MSRV-compliant) dependencies 21:19 -!- tibo [~tibo@203x114x16x10.ap203.ftth.arteria-hikari.net] has joined #bitcoin-rust 22:39 -!- orville [~orville@c-67-170-226-157.hsd1.ca.comcast.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 23:54 -!- tibo [~tibo@203x114x16x10.ap203.ftth.arteria-hikari.net] has quit [Remote host closed the connection] 23:54 -!- tibo [~tibo@203x114x16x10.ap203.ftth.arteria-hikari.net] has joined #bitcoin-rust 23:59 -!- tibo [~tibo@203x114x16x10.ap203.ftth.arteria-hikari.net] has quit [Ping timeout: 255 seconds] --- Log closed Fri Oct 21 00:00:55 2022