--- Log opened Mon Oct 24 00:00:58 2022
02:44 -!- darosior [~darosior@194.36.189.246] has quit [Read error: Connection reset by peer]
02:44 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-rust
05:11 -!- tibo [~tibo@240d:1a:afa:4000:9cda:2313:e506:1669] has quit []
09:44 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Quit: Bridge terminating on SIGTERM]
09:44 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has quit [Quit: Bridge terminating on SIGTERM]
09:44 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Quit: Bridge terminating on SIGTERM]
09:44 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has quit [Quit: Bridge terminating on SIGTERM]
09:44 -!- wpaulino [~wpaulino@user/wpaulino] has quit [Quit: Bridge terminating on SIGTERM]
09:44 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has quit [Quit: Bridge terminating on SIGTERM]
09:44 -!- arturomf94[m] [~arturomf9@2001:470:69fc:105::2:235] has quit [Quit: Bridge terminating on SIGTERM]
09:44 -!- FelixWeis[m] [~felixweis@2001:470:69fc:105::2:9920] has quit [Quit: Bridge terminating on SIGTERM]
09:44 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has quit [Quit: Bridge terminating on SIGTERM]
09:44 -!- RiccardoCasatta[ [~rcasattam@2001:470:69fc:105::c85] has quit [Quit: Bridge terminating on SIGTERM]
09:48 -!- wpaulino [~wpaulino@user/wpaulino] has joined #bitcoin-rust
09:54 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has joined #bitcoin-rust
09:54 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-rust
09:54 -!- arturomf94[m] [~arturomf9@2001:470:69fc:105::2:235] has joined #bitcoin-rust
09:54 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-rust
09:54 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has joined #bitcoin-rust
09:54 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has joined #bitcoin-rust
09:55 -!- FelixWeis[m] [~felixweis@2001:470:69fc:105::2:9920] has joined #bitcoin-rust
09:55 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has joined #bitcoin-rust
09:55 -!- RiccardoCasatta[ [~rcasattam@2001:470:69fc:105::c85] has joined #bitcoin-rust
10:54 < afilini> this commit https://github.com/rust-bitcoin/rust-bitcoin/commit/23ee0930c75c3c028572c521e0906fd4f95b6b92 removed the "pub extern crate" which means that some crates like base64 aren't exported anymore. i'm guessing this was accidental, right? should i make a pr to re-export those crates?
11:55 < jeremyrubin> imo yes pls
12:58 < andytoshi> afilini: yes pls
12:59 < andytoshi> afilini: and if they are missing in 8.0 you can even add a commit to bump to 8.1 so you can get the re-exports
13:06 < andytoshi> in crates
13:19 -!- Netsplit *.net <-> *.split quits: ariard
13:19 -!- Netsplit over, joins: ariard
14:24 < BlueMatt[m]> > your ack shouldn't count because you didn't specify the commit ID.
14:24 < BlueMatt[m]> I mean if we want to have "trusted github-free acks" we should pgp-sign them or the like. Including the commit id still trusts github the same as using the "remove acks that have a stale commit hash" option in github's ui.
14:34 < andytoshi> BlueMatt[m]: yes, but even if i trust github  i can't tell which particular tip you intended to ack (ok, there was only one in this case, but did you ack the right PR? ;))
14:35 < andytoshi> also we _know_ github's review dismissal logic is completely broken, whereas we don't have evidence that github is completly lying about acks
14:35 < andytoshi> so there is some difference in trust there
14:36 < BlueMatt[m]> heh, yea, i suppose if you forget to refresh and make sure its the same tip before you click ack
14:36 < BlueMatt[m]> oh? I've never seen its dismissal-on-push logic be wrong.
15:32 < andytoshi> really? i swear it's wrong more often than it's right
15:33 < BlueMatt[m]> huh, we use it on rust-lightning and its quite annoyingly right every time I've interacted with it
15:36 < andytoshi> fascinating. i find that 90% of the time it should dismiss reviews, it simply doesn't
15:36 < andytoshi> and some small percentage of the time it dismisses reviews that it shouldn't, but i don't care about that
15:36 < BlueMatt[m]> huh
15:36 < BlueMatt[m]> man github needs to be replaced
15:36 < andytoshi> but basically an ACK without a commit id is meaningless except in special cases (such as a branch that only ever pointed to one commit)
15:36 < andytoshi> lol, yeah
18:10 -!- b10c [~quassel@user/b10c] has quit [K-Lined]
18:10 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [K-Lined]
18:12 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-rust
18:12 -!- b10c [~quassel@static.33.106.217.95.clients.your-server.de] has joined #bitcoin-rust
18:12 -!- b10c [~quassel@static.33.106.217.95.clients.your-server.de] has quit [Changing host]
18:12 -!- b10c [~quassel@user/b10c] has joined #bitcoin-rust
--- Log closed Tue Oct 25 00:00:59 2022