--- Log opened Wed Nov 30 00:00:33 2022
00:56 -!- darosior [~darosior@194.36.189.246] has joined #bitcoin-rust
04:29 -!- tibo [~tibo@fp5a950abc.tkyc110.ap.nuro.jp] has quit []
05:49 < andytoshi> any complaints if i move rust-jsonrpc to rust-bitcoin org now?
05:50 < andytoshi> see https://github.com/apoelstra/rust-jsonrpc/issues/78
06:01 < darosior> Sounds good :)
07:38 < BlueMatt[m]> Do it
08:39 < andytoshi> ooo nice what do we think of minreq HTTP crate?
08:50 < stevenroose> andytoshi: seems interesting
08:52 < stevenroose> sync-only api though, so doesn't replace the ldk impl
08:52 < stevenroose> only our own built-in http one, but I'd be happy to use minreq to replace our own :)
09:13 < BlueMatt[m]> Wonder if they’d consider an option to enable async
09:13 < BlueMatt[m]> Also what’s the msrv
09:14 < BlueMatt[m]> Personally, this whole “don’t write your own http client” thing irks me - it’s 100 LoC, well below the threshold for “don’t nih it” imo
09:37 -!- Jiri[m] [~jirijirij@2001:470:69fc:105::2:c0a7] has quit [Quit: Bridge terminating on SIGTERM]
09:37 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has quit [Quit: Bridge terminating on SIGTERM]
09:37 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has quit [Quit: Bridge terminating on SIGTERM]
09:37 -!- wpaulino [~wpaulino@user/wpaulino] has quit [Quit: Bridge terminating on SIGTERM]
09:37 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has quit [Quit: Bridge terminating on SIGTERM]
09:37 -!- M1asdfah[m] [~M1asdfahm@2001:470:69fc:105::2:f40] has quit [Quit: Bridge terminating on SIGTERM]
09:37 -!- jakwolf[m] [~jakwolfma@2001:470:69fc:105::2:acc8] has quit [Quit: Bridge terminating on SIGTERM]
09:37 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has quit [Quit: Bridge terminating on SIGTERM]
09:37 -!- RiccardoCasatta[ [~rcasattam@2001:470:69fc:105::c85] has quit [Quit: Bridge terminating on SIGTERM]
09:42 -!- jakwolf[m] [~jakwolfma@2001:470:69fc:105::2:acc8] has joined #bitcoin-rust
09:47 -!- BlueMatt[m] [~bluemattm@2001:470:69fc:105::1:5092] has joined #bitcoin-rust
09:47 -!- willcl_ark [~willcl-ar@user/willcl-ark/x-8282106] has joined #bitcoin-rust
09:47 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has joined #bitcoin-rust
09:47 -!- Jiri[m] [~jirijirij@2001:470:69fc:105::2:c0a7] has joined #bitcoin-rust
09:48 -!- dpc[m] [~dpcmatrix@2001:470:69fc:105::1:2020] has joined #bitcoin-rust
09:48 -!- RiccardoCasatta[ [~rcasattam@2001:470:69fc:105::c85] has joined #bitcoin-rust
09:48 -!- M1asdfah[m] [~M1asdfahm@2001:470:69fc:105::2:f40] has joined #bitcoin-rust
09:48 -!- wpaulino [~wpaulino@user/wpaulino] has joined #bitcoin-rust
09:58 < andytoshi> minreq annoyingly does not build with 1.41
09:58 < andytoshi> lemme check on 1.48
09:59 < andytoshi> it's all minor stuff, i think they would accept a PR to "fix" it ... they also don't have a MSRV at all lol
10:01 < andytoshi> nice, builds and tests pass with 1.48, at least with no features enabled
10:01 < BlueMatt[m]> nice
10:02 < andytoshi> i'll PR asking if they'd accept a "MSRV without features is 1.48" PR 
10:02 < andytoshi> with rustls it needs someting higher
10:05 < andytoshi> kek with the "proxy" feature it doesn't compile at all (derives Eq on a structure containing a Proxy object which itself doesn't impl Eq)
10:05 < BlueMatt[m]> oof
10:06 < andytoshi> ok, and a couple of the https features aren't compatible with each other, which might have a simple fix (looks like symbols are defined multiple times, so they just need to pick one to take precedence)
10:07 < andytoshi> *but* if you avoid stepping on that, every individual feature except https-rustls, works with 1.48
10:07 < andytoshi> so i think i should make a PR to fix these things, put a "1.48 msrv except rustls" CI-enforced policy in .. and see how they react
10:07 < andytoshi> if it's positive and they take it, i'd be happy to dig into this crate and try using it
10:07 < BlueMatt[m]> should also ask about async
10:07 < andytoshi> sure
10:08 < andytoshi> maybe i'll let you do that, in a separate issue
10:08 < BlueMatt[m]> if they dont want to support async then I think we're probably back where we started :(
10:08 < andytoshi> yeah, true
10:08 < BlueMatt[m]> I dont think we can ship a "rewrite big chunks of rust-bitcoinrpc" thing without async as an option :/
10:08 < andytoshi> though maybe, like me, they didn't consider that they could somewhat-cleanly feature-gate the async stuff
10:08 < BlueMatt[m]> at least ~all the LDK rust users seem to be using async
10:08 < andytoshi> yeah that makes sense, it's a highly networked project
10:09 < BlueMatt[m]> if that's any indication of where async is in terms of usage in bitcoin
10:09 < andytoshi> all of my shit is local "scan the blockchain and do X" or "talk to a single hww", where async is just extra compleixty
10:11 < BlueMatt[m]> andytoshi: yea, luckily the tokio async read and std tcpstream read are ~the same API, so the only complexity is if you have the `async` tag on the method or not, really. and then you have to macroize everything which is ugly, but not the end of the world
10:11 < BlueMatt[m]> or do async methods and just don't actually ever do anything async in them like LDK does
10:12 < andytoshi> neat
11:00 < andytoshi> stevenroose: free to cut the 0.17.0 release of rust-bitcoincore-rpc? https://github.com/rust-bitcoin/rust-bitcoincore-rpc/pull/253 this basically pulls in some simple fixes from rust-jsonrpc, as well a bunch of bugfixes that were easy/obvious for me to merge
11:01 < andytoshi> or i can do it, if you give me permission and crates access
14:30 -!- appservicebot12 [~afilini-m@2001:bc8:1828:245::2] has quit [Ping timeout: 260 seconds]
14:43 -!- appservicebot12 [~afilini-m@2001:bc8:1828:245::2] has joined #bitcoin-rust
16:05 -!- tibo [~tibo@240d:1a:afa:4000:848d:7bf4:3695:b6e7] has joined #bitcoin-rust
18:04 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity]
21:57 -!- sandipndev123 [sandipndev@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-rust
21:58 -!- notmandatory_ [~notmandat@shindig.notmandatory.org] has joined #bitcoin-rust
21:59 -!- DeanWeen [~dean@nonplayercharacter.me] has joined #bitcoin-rust
22:05 -!- Netsplit *.net <-> *.split quits: b42, sandipndev, DeanGuss, notmandatory
23:25 -!- trev [~trev@user/trev] has joined #bitcoin-rust
23:34 -!- b42 [~mmilata@b42.cz] has joined #bitcoin-rust
--- Log closed Thu Dec 01 00:00:32 2022