--- Log opened Tue Sep 17 00:00:55 2024 00:21 < darosior> yancy: this is a round-up. It seems intentional. Did you try git blaming it? 00:22 < darosior> Doing so shows it was introduced in #2182. Here is a comment explaining the ceiling: https://github.com/rust-bitcoin/rust-bitcoin/pull/2182/files#r1389667566. 01:10 -!- jirijakes [~jirijakes@118.150.148.23] has quit [Ping timeout: 246 seconds] 01:45 -!- pablomartin [~pablomart@91.196.222.127] has joined #bitcoin-rust 04:30 -!- pablomartin [~pablomart@91.196.222.127] has quit [Ping timeout: 252 seconds] 05:55 -!- jirijakes [~jirijakes@118.150.148.23] has joined #bitcoin-rust 12:40 -!- pablomartin [~pablomart@91.196.222.126] has joined #bitcoin-rust 12:59 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 248 seconds] 13:02 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-rust 13:07 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds] 13:44 -!- pablomartin [~pablomart@91.196.222.126] has quit [Read error: Connection reset by peer] 13:44 -!- pablomartin [~pablomart@89.35.25.80] has joined #bitcoin-rust 13:44 -!- pablomartin [~pablomart@89.35.25.80] has quit [Remote host closed the connection] 14:04 < yancy> darosior thanks. I reviewed PR 2182 and a little embarrassing I didn't remember the details of why. Anyway, I created PR 3371 to note that it's a roundup on purpose. 14:18 -!- jirijakes [~jirijakes@118.150.148.23] has quit [Ping timeout: 260 seconds] 19:00 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-rust 22:10 < yancy> Is there a reason that FeeRate does not include traits for addition and subtraction? I vaguly remeber having a discussion someplace (can't find on GH rn) about why multiplication does not makes sense because it would result in sat^2/weight^2 units, although adding two fee_rates should result in sat/weight and be ok. --- Log closed Wed Sep 18 00:00:56 2024