--- Log opened Sun Mar 23 00:00:55 2025 01:51 -!- salvatoshi__ [~salvatosh@92-184-118-123.mobile.fr.orangecustomers.net] has joined #bitcoin-rust 03:03 -!- salvatoshi_ [~salvatosh@92-184-97-97.mobile.fr.orangecustomers.net] has joined #bitcoin-rust 03:05 -!- salvatoshi__ [~salvatosh@92-184-118-123.mobile.fr.orangecustomers.net] has quit [Ping timeout: 260 seconds] 05:46 -!- andytoshi [~apoelstra@user/andytoshi] has quit [Quit: leaving] 07:16 -!- BSaboia [~bsaboia@user/BSaboia] has quit [Ping timeout: 260 seconds] 07:16 -!- BSaboia [~bsaboia@user/BSaboia] has joined #bitcoin-rust 14:18 < yancy> Ademan, what exactly are your test vectors testing that you need Amounts greater than MAX_MONEY? 14:41 < yancy> We did discuss keeping a from_sats_unchecked so that one doesn't neeed to do unwrap() on values clealy less than the invariant although that was argued as not a good enough reason to keep the escape hatch. 16:17 -!- salvatoshi__ [~salvatosh@92-184-97-22.mobile.fr.orangecustomers.net] has joined #bitcoin-rust 16:20 -!- salvatoshi_ [~salvatosh@92-184-97-97.mobile.fr.orangecustomers.net] has quit [Ping timeout: 252 seconds] 16:34 -!- salvatoshi__ [~salvatosh@92-184-97-22.mobile.fr.orangecustomers.net] has quit [Ping timeout: 260 seconds] 16:59 < Ademan_> yancy: the test vectors from bip-119 https://github.com/bitcoin/bips/blob/master/bip-0119/vectors/ctvhash.json 16:59 < Ademan_> (the very first transaction, in fact heh) 17:01 < Ademan_> I guess the question to me is: does enforcing that invariant actually affect any other code? (amount math?) 18:04 -!- proofofkeags [~proofofke@184-96-213-13.hlrn.qwest.net] has joined #bitcoin-rust 18:09 -!- proofofkeags [~proofofke@184-96-213-13.hlrn.qwest.net] has quit [Ping timeout: 252 seconds] --- Log closed Mon Mar 24 00:00:55 2025