--- Log opened Mon Jun 16 00:00:15 2025
06:28 -!- darosior [~darosior@109.205.214.46] has joined #bitcoin-rust
06:30 -!- BSaboia [~bsaboia@user/BSaboia] has quit [Ping timeout: 268 seconds]
07:31 < andytoshi> Ademan: thanks for the PR! yeah, i think this change is correct
07:31 < andytoshi> there is a related clippy lint for calling functions that -take- an AsRef<T> with a reference, and i think we had an argument about that some months ago
07:31 < andytoshi> but i don't remember the details now
07:52 -!- BSaboia [~bsaboia@user/BSaboia] has joined #bitcoin-rust
13:20 < Ademan> np, I wouldn't want to break anything for such a minor change... I think I see the lint you're talking about (it caused a CI failure)
15:37 < andytoshi> i think it'd be worth breakage (though i don't think there is any)
15:37 < andytoshi> it kinda defeats the point of taking AsRef if we don't use it
15:37 < andytoshi> or maybe we are misunderstanding the trait
15:37 < andytoshi> i mean, the as_ref method takes &self
--- Log closed Tue Jun 17 00:00:15 2025