--- Log opened Sun Oct 06 00:00:34 2019
10:56 < jeremyrubin> sipa: care to comment on https://github.com/sipa/bitcoin/pull/116; I think those changes still stand 7 can be rebased
11:06 < sipa> jeremyrubin: my primary concern is how easy it is to review, so i'd like to see a commit history, not just a result
11:06 < sipa> but i'll push my new version soon
11:09 < jeremyrubin> is the new version not on Taproot2 currently?
11:10 < jeremyrubin> I am happy to make the refactoring in multiple steps.
11:11 < jeremyrubin> It's still useful to know if you agree with the result or not
11:14 < sipa> jeremyrubin: i don't care about the result at all
11:14 < sipa> i care about having an easy to review commit history
11:15 < sipa> and i think that's the sole criteria to judge the code by
11:15 < sipa> *criterion
11:27 < jeremyrubin> I disagree, but even by that it stinks ;) https://github.com/sipa/bitcoin/commit/9656f6843dc27941ad9d0bc185eb08508109deeb where the bulk of the changes to verifywitness are introduced is not great to review. it could have been written in an easier to review way, which is what im suggesting
11:28 < jeremyrubin> so if taproot2 is the new version i can insert some commits
11:29 < sipa> i'll try to factor some of the code myself out there
11:29 < sipa> i agree it's too much a sequence of operations without much structure
13:12 < sipa> jeremyrubin: i'm getting rid of the fall-through behaviour in VerifyWitnessProgram to get to the code execution, and moving a bunch of stuff to helper functions
13:13 < sipa> will push in a few hours or so
--- Log closed Mon Oct 07 00:00:34 2019