--- Day changed Tue Jul 24 2018 00:07 -!- froyer [~froyer@124.19.31.4] has joined #c-lightning 00:14 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has joined #c-lightning 00:19 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has quit [Ping timeout: 256 seconds] 00:26 -!- froyer [~froyer@124.19.31.4] has quit [Remote host closed the connection] 01:05 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has joined #c-lightning 01:07 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has joined #c-lightning 01:11 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has quit [Ping timeout: 256 seconds] 01:55 -!- ebx [~ebx@unaffiliated/ebex] has joined #c-lightning 02:58 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has joined #c-lightning 03:23 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 256 seconds] 03:24 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has quit [Remote host closed the connection] 03:24 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has joined #c-lightning 03:26 -!- Drolmer [~Drolmer@unaffiliated/drolmer] has quit [Ping timeout: 276 seconds] 03:27 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has quit [Remote host closed the connection] 03:27 -!- Drolmer [~Drolmer@unaffiliated/drolmer] has joined #c-lightning 03:29 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has joined #c-lightning 03:34 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has quit [Remote host closed the connection] 03:39 -!- froyer [~froyer@185.161.201.12] has joined #c-lightning 03:48 -!- froyer_ [~froyer@126.121.233.220.static.exetel.com.au] has joined #c-lightning 03:48 -!- froyer [~froyer@185.161.201.12] has quit [Read error: Connection reset by peer] 03:50 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has joined #c-lightning 03:55 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has quit [Ping timeout: 256 seconds] 03:56 <@cdecker> Chris_Stewart_5: c-lightning will look at the blockheight when it first starts up, and sync from there 03:57 <@cdecker> Chris_Stewart_5: so if bitcoind was syncing alongside c-lightning, then c-lightning will grab whatever the current blockheight is and scan from there 03:57 <@cdecker> Chris_Stewart_5: You should let bitcoind sync first and then start c-lightning 03:57 -!- tiagotrs [~user@i577B9AD7.versanet.de] has joined #c-lightning 03:57 -!- tiagotrs [~user@i577B9AD7.versanet.de] has quit [Changing host] 03:57 -!- tiagotrs [~user@unaffiliated/tiagotrs] has joined #c-lightning 04:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #c-lightning 04:20 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 244 seconds] 04:33 -!- tiagotrs [~user@unaffiliated/tiagotrs] has quit [Ping timeout: 240 seconds] 04:36 -!- froyer_ [~froyer@126.121.233.220.static.exetel.com.au] has quit [Remote host closed the connection] 04:41 -!- qubenix [~qubenix@185.65.135.179] has joined #c-lightning 04:44 -!- dougsland [~douglas@74-94-155-49-NewEngland.hfc.comcastbusiness.net] has joined #c-lightning 04:44 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has joined #c-lightning 04:49 -!- dougsland [~douglas@74-94-155-49-NewEngland.hfc.comcastbusiness.net] has quit [Ping timeout: 260 seconds] 04:59 -!- grubles [~grubles@unaffiliated/grubles] has joined #c-lightning 05:00 -!- dougsland [~douglas@c-73-234-93-65.hsd1.nh.comcast.net] has joined #c-lightning 05:01 -!- grubles_ [~grubles@unaffiliated/grubles] has quit [Ping timeout: 256 seconds] 05:12 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 05:25 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #c-lightning 05:28 -!- farmerwampum [~farmerwam@88.202.178.98] has joined #c-lightning 05:36 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #c-lightning 05:40 -!- dougsland [~douglas@c-73-234-93-65.hsd1.nh.comcast.net] has quit [Ping timeout: 276 seconds] 05:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 05:53 < bitonic-cjp> test_pay_disconnect FAILED 05:53 < bitonic-cjp> TimeoutError: Unable to find "[re.compile('Peer permanent failure in CHANNELD_NORMAL: lightning_channeld: received ERROR channel .*: update_fee 150000 outside range 1875-75000')]" in logs. 05:53 < bitonic-cjp> I ran 'make check' with TIMEOUT=600 06:00 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has quit [Remote host closed the connection] 06:07 < bitonic-cjp> I'm now searching for the guilty commit. 06:33 < bitonic-cjp> It worked in isolation in the last commit of master - maybe my source tree was not clean the first time? Trying again. 06:42 -!- ebx [~ebx@unaffiliated/ebex] has quit [Remote host closed the connection] 06:47 -!- dougsland [~douglas@c-73-234-93-65.hsd1.nh.comcast.net] has joined #c-lightning 06:50 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has joined #c-lightning 06:55 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has quit [Ping timeout: 264 seconds] 06:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 07:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning 07:19 -!- renepickhardt [577bc45d@gateway/web/freenode/ip.87.123.196.93] has joined #c-lightning 07:25 -!- Amperture [~amp@24.136.5.183] has joined #c-lightning 07:26 < bitonic-cjp> ...and now it succeeds. Weird. 07:31 < renepickhardt> what editor IDE are you using for c-lightning? anyone here has integrated this with eclipse? 07:37 -!- Milkshake61 [4a3bb05f@gateway/web/freenode/ip.74.59.176.95] has quit [Ping timeout: 252 seconds] 08:18 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has joined #c-lightning 08:23 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has quit [Ping timeout: 244 seconds] 08:36 -!- grafcaps [~haroldbr@104.137.194.255] has joined #c-lightning 08:48 <@cdecker> bitonic-cjp: that's what we call a flaky test :-) 08:48 <@cdecker> renepickhardt: emacs + company-mode ^^ 08:49 < renepickhardt> since c is not my strongest language I feel I need some idee so I can jump to declarations and similar features. but yeah I figured people would suggest vim / emacs :( 08:50 < bitonic-cjp> renepickhardt: I use pluma (the MATE fork of gedit), a console window and gitg 08:50 < bitonic-cjp> I use ncc for analyzing the source code. 08:50 < bitonic-cjp> It's ancient, but it works (after some modifications). 08:51 < bitonic-cjp> I've added a Makefile target and some documentation on using ncc in the C-Lightning source tree. 08:51 <@cdecker> Yeah, some of the tooling from eclipse is dearly missed, but after a while you get used to using emacs/vim and have configured your own tooling 08:51 <@cdecker> Still need to try out that ncc target 08:52 < bitonic-cjp> Remember to use my modified ncc (available on Github). 08:52 < renepickhardt> yeah just looked up the man page that seems strong. Do I understand correctly that this can be used instead of debugging in step mode over the code? 08:53 < bitonic-cjp> renepickhardt: ncc is just a tool for static code analysis, not for runtime debugging. 08:53 <@cdecker> I personally like to use doxygen, which also generates call-graphs (really useful), though our source could use some more documentation 08:53 < renepickhardt> well I will give it a try. thanks for the suggestion 08:53 < bitonic-cjp> It allows you to see, for instance, in which functions another function is called, which source file contains a function and things like that. 08:53 <@cdecker> Anytime :-) 08:54 < renepickhardt> @cdecker is that actually wanted? While reading the code currently I could easily add more comments and create a pr but I thought it was on purpose that it is kept so little 08:54 < bitonic-cjp> More advanced analysis might be possible, but this is what the default 'nccnav' offers. 08:55 <@cdecker> renepickhardt: it's kind of hard, with all the refactorings to keep the comments up to date, if not everyone makes a point of documenting 08:56 < renepickhardt> which means I should not commit comments since they will break anyway? 08:57 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 08:58 < bitonic-cjp> I'd guess that code that hasn't changed for a while now (and isn't dead code) isn't likely to change in the near future, so documenting that code doesn't sound like a lost effort to me. 08:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning 09:00 < bitonic-cjp> (Meanwhile: test failed "nodes had bad gossip order" aargh! again? This time it's test_reconnect_normal.) 09:00 < renepickhardt> for example I guess the comment on https://github.com/ElementsProject/lightning/blob/master/gossipd/routing.h#L266 would be more usefull if it mentioned the BOLT spec for ordering keys also for a channel. otherwise it seems pretty random 09:03 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has quit [Quit: Leaving] 09:05 -!- tiagotrs [~user@i577B9AD7.versanet.de] has joined #c-lightning 09:05 -!- tiagotrs [~user@i577B9AD7.versanet.de] has quit [Changing host] 09:05 -!- tiagotrs [~user@unaffiliated/tiagotrs] has joined #c-lightning 09:09 <@cdecker> renepickhardt: improvements like more documentation are always welcome, and hopefully we can get into the groove of actually documenting, I just wanted to say that it might be an uphill battle :-) 09:10 < renepickhardt> also I am pretty amazed by this line https://github.com/ElementsProject/lightning/blob/master/common/utils.c#L8 do I understand it correctly that the tmpctx is the newly biuld ctx? 09:11 < renepickhardt> when this is global and most of channeld is asychronous this seems like it can break channels once there is a lot of traffic on a node. I am pretty sure that this would not reflect the reality but that is what I get from the code 09:11 <@cdecker> That's a global context we allocate other allocations off of, and it gets free'd and reallocated every time we poll in the loop 09:11 <@cdecker> Hence we have a small staging area we keep temporary objects while we handle a message and then free it all at once 09:12 <@cdecker> The daemons are all using async IO, which means that we always are processing a single message, and this makes using a global context safe again 09:12 * cdecker needs to run off for an hour, but will follow up later 09:30 * renepickhardt afk 09:35 -!- renepickhardt [577bc45d@gateway/web/freenode/ip.87.123.196.93] has quit [Ping timeout: 252 seconds] 10:15 -!- delphi [~delphi@2602:306:b8b6:b970:d992:3519:28f0:d0cb] has joined #c-lightning 10:15 -!- delphi is now known as Guest91016 10:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 10:35 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning 10:52 -!- Guest91016 is now known as polydin 10:55 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has joined #c-lightning 10:59 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has quit [Ping timeout: 240 seconds] 11:19 -!- ebx [~ebx@unaffiliated/ebex] has joined #c-lightning 12:07 -githubby:#c-lightning- [lightning] jb55 reopened pull request #1736: doc: update python test requirements in HACKING (master...hacking-python-deps) https://git.io/fN4J1 12:22 -!- CubicEarth [~CubicEart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 12:24 -!- CubicEarth [~CubicEart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #c-lightning 12:42 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 12:44 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning 12:45 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #c-lightning 12:47 -githubby:#c-lightning- [lightning] cdecker opened pull request #1740: Add descriptions to invoices and payments (master...payment-descriptions) https://git.io/fNB6P 14:48 -!- Amperture [~amp@24.136.5.183] has quit [Remote host closed the connection] 14:56 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has joined #c-lightning 15:09 -!- froyer [~froyer@126.121.233.220.static.exetel.com.au] has quit [Remote host closed the connection] 15:19 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 15:20 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning 16:24 -!- froyer [~froyer@pa49-195-153-144.pa.nsw.optusnet.com.au] has joined #c-lightning 16:38 -!- froyer [~froyer@pa49-195-153-144.pa.nsw.optusnet.com.au] has quit [Remote host closed the connection] 16:39 -!- froyer [~froyer@pa49-195-153-144.pa.nsw.optusnet.com.au] has joined #c-lightning 16:42 -!- tiagotrs [~user@unaffiliated/tiagotrs] has quit [Ping timeout: 255 seconds] 16:44 -!- froyer [~froyer@pa49-195-153-144.pa.nsw.optusnet.com.au] has quit [Ping timeout: 244 seconds] 17:25 -!- ebx [~ebx@unaffiliated/ebex] has quit [Ping timeout: 256 seconds] 17:31 -githubby:#c-lightning- [lightning] rustyrussell opened pull request #1742: More testing and decode of temporary failure messages (master...guilt/respond-to-temporary-failure) https://git.io/fNRe8 17:31 -!- froyer [~froyer@124.19.31.4] has joined #c-lightning 18:07 -!- jpe_ [~jpe@200116b8420b1b007e36f4caa2b6fc55.dip.versatel-1u1.de] has joined #c-lightning 18:10 -!- jpe__ [~jpe@200116b8428cf000f1d13b0cf629ac66.dip.versatel-1u1.de] has quit [Ping timeout: 265 seconds] 18:28 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 256 seconds] 18:44 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has joined #c-lightning 19:05 -githubby:#c-lightning- [lightning] nayuta-ueno opened pull request #1743: show log (master...ueno/log_message) https://git.io/fNRJ4 19:05 -githubby:#c-lightning- [lightning] nayuta-ueno closed pull request #1743: show log (master...ueno/log_message) https://git.io/fNRJ4 19:05 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Quit: WeeChat 2.1] 19:06 -!- dougsland [~douglas@c-73-234-93-65.hsd1.nh.comcast.net] has quit [Ping timeout: 240 seconds] 19:13 -githubby:#c-lightning- [lightning] rustyrussell opened pull request #1744: Tell wallet about steal output (master...tell-wallet-about-steal-output) https://git.io/fNRJo 19:14 -githubby:#c-lightning- [lightning] rustyrussell closed pull request #1732: Connectd: split connection control from gossipd (master...connectd) https://git.io/fNlrl 19:35 -!- RubenSomsen [uid301948@gateway/web/irccloud.com/x-ybpfrqkekzxonrir] has quit [Ping timeout: 256 seconds] 19:35 -githubby:#c-lightning- [lightning] nayuta-ueno opened pull request #1745: fix: make devtools-clean (master...work/fix_devtool_clean) https://git.io/fNRUI 19:36 -!- RubenSomsen [uid301948@gateway/web/irccloud.com/x-rpfirxzzilscrfuo] has joined #c-lightning 20:14 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has quit [Ping timeout: 264 seconds] 20:58 -!- froyer [~froyer@124.19.31.4] has quit [Ping timeout: 240 seconds] 20:59 -!- froyer [~froyer@124.19.31.4] has joined #c-lightning 21:42 -!- froyer [~froyer@124.19.31.4] has quit [Ping timeout: 248 seconds] 21:46 < molz> it seems stable release v0.6 is not stable anymore 21:50 -!- froyer [~froyer@124.19.31.4] has joined #c-lightning 22:29 < molz> what does this mean: lightning_gossipd(3516): Bad gossip order from node_announcement: WIRE_NODE_ANNOUNCEMENT before announcement 02a4f7965a9f3f653d25b5b0377a8ed23e3270af056d89d57a3841fd59b38da11e 23:10 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has joined #c-lightning 23:14 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has quit [Ping timeout: 240 seconds]