--- Log opened Wed Feb 20 00:00:54 2019
01:18 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has joined #c-lightning
01:40 < blockstream_bot> [Christian Decker, Blockstream] Will take a look at 2342 today, thanks for all the hard work 
01:59 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 255 seconds]
02:09 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:27 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
02:36 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 256 seconds]
02:39 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
02:44 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 246 seconds]
02:59 -!- booyah [~bb@193.25.1.157] has joined #c-lightning
03:41 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
03:47 < m-schmoock> when I do a lightning-cli stop  it takes suspicously long and i can see a lot  "[lightning_openi] <defunct>" and "[lightning_chann] <defunct>" in the `ps aux` output.
03:47 < m-schmoock> after a while they are gone an i can restart the daemon
03:47 < m-schmoock> is this known/normal?
03:48 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
03:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds]
05:18 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:40 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
06:18 < m-schmoock> update: i think its normal during shutdown to have some zombies until the parent dies
06:48 <@cdecker> The zombies should be reaped by the parent (lightningd) rather quickly. Shutdown does perform some cleanup checks so that might take a while.
06:58 < m-schmoock> jup
08:35 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
09:03 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has quit [Quit: Leaving]
09:43 <@cdecker> m-schmoock: do you know about `git commit --fixup=` and `git rebase -i --autosquash`? They would be really useful for your PRs :-)
09:48 <@cdecker> I'd probably squash your current PR into a single commit, due to not being bisectable and temporarily undoing quite a few things that were changed in the same PR
09:52 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
09:55 -!- Amperture [~amp@24.136.5.183] has joined #c-lightning
09:57 <@cdecker> Ok, I went through your PR #2342 with a fine-toothed comb (which we do for new contributors) and left a lot of comments. It
09:57 <@cdecker> Nothing major, and I really like your PR so far :+1:
10:55 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
11:01 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Ping timeout: 258 seconds]
11:21 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
11:24 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
11:53 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
12:42 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
14:38 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 268 seconds]
14:39 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
14:39 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #c-lightning
14:43 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
14:50 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
16:04 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
16:21 < rusty> niftynei: thanks for review, pushing update now.
16:22 < rusty> In particular, 'amount_msat' is a compromise, because we may deprecate raw numbers later.
16:24 < rusty> Hmm part II needs rebase.  Will wait for Travis on Part I before merge, then do rebase.
16:46 < rusty> niftynei: but I'm not delighted with name either, so suggestions welcome!
17:05 < rusty> (Unf. the rule isn't quite "_msat" field are xxxmsat strings, since there's one existing _msat we already have :(
17:07 < rusty> (max_htlc_value_in_flight_msat in channel list, and fee_base_msat in invoice decode with routehints.
17:09 < rusty> (Pushed rebase)
17:21 <@niftynei> :thumbsup:
17:23 <@niftynei> rusty just saw your comment about deprecating the raw value fields at some point
17:23 < rusty> yeah, might get some pushback though.  The new ones are consistent, at least, the old ones are a mix of satoshi and msatoshi values...
17:24 <@niftynei> that definitely changes my opinion about the names for the 'formatted' fields
17:24 <@niftynei> consistency is nice, i think what i really was looking for was something to clue in that there was some amount of 'formatting' included
17:25 <@niftynei> something to clue in what to expect you'll need to do in terms of parsing (like is this a raw value or something w/ a descriptor attached)
17:26 < rusty> Yeah, we only have internal consistency (mostly) as a guide.  Plus if you use a hacky language 1000msat gets turned into 1000 (eg. atoi in C :)
17:26 < rusty> OTOH being universal it should fail fast, since all fields will be like that.
17:27 <@niftynei> loling at "if you use a hacky language"
17:28 < rusty> PHP probably also does that...
17:28 < rusty> Dunno about javascript.
17:28 <@niftynei> yep makes sense to me. i was more thinking of a world where we always provide both the raw and the formatted, it'd be good to differentiate them but since the eventual? goal is to remove the raws, it's not such a big deal
17:29 <@niftynei> i think that was the longest PR i've ever reviewed :sweat:
17:29 < rusty> I think the raws have caused more confusion than they're worth.  If we'd *always* used msat everywhere, it'd be different I think.
17:29 < rusty> It's also a gentle reminder when interfacing with other things like block explorers.
17:30 < rusty> You happier with msat everywhere so we no longer expose formatted 'sat' strings?  Consistency FTW...
17:30 < rusty> (If so, I'll fold those last fixup patches back appropriately)
17:31 < rusty> niftynei: ^
17:34 -!- mn3monic [jsz@unaffiliated/mn3monic] has quit [Excess Flood]
17:34 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
17:35 -!- mn3monic [jsz@unaffiliated/mn3monic] has joined #c-lightning
17:35 -!- mn3monic [jsz@unaffiliated/mn3monic] has quit [Excess Flood]
17:35 -!- mn3monic [jsz@unaffiliated/mn3monic] has joined #c-lightning
17:42 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
17:54 <@niftynei> ack
17:54 <@niftynei> +1 for msat everywhere
17:55 < rusty> niftynei: great, will refactor and if travis is happy, merge then rebase part III.  Which I *don't* recommend reviewing ;)
17:58 <@niftynei> too late :P
17:58 <@niftynei> well, at least for a first pass 
17:58 < rusty> niftynei: yeach, then don't try a commit-at-a-time review, reocmmend doing it all at ocne, since it's two steps forward, one back..
18:03 <@niftynei> yeah i figured that out ... eventually lol.
18:42 < rusty> niftynei: I fixed two typos in the amount.h header, otherwise identical after the rebase (the comment for json_add_amount_sat still  talked about adding a 'sat' field).  Will rebase part III now :)
20:33 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
21:02 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
21:06 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Client Quit]
23:10 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 246 seconds]
23:52 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
--- Log closed Thu Feb 21 00:00:55 2019