--- Log opened Mon Mar 04 00:00:06 2019
00:08 < t0mix> rusty is the one with moustache? :)
00:18 < m-schmoock> sure he is
00:33 < m-schmoock> kinda looks like rosco from savlonic, just better.
00:58 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
01:20 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has joined #c-lightning
01:43 -!- Letze [uid63391@gateway/web/irccloud.com/x-xjozsbrznrnnwrst] has joined #c-lightning
01:49 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
01:56 < bitonic-cjp> Potential issue in lightningd/plugin.c, add_plugin_dir
01:57 < bitonic-cjp> DIR *d = opendir(dir);
01:57 < bitonic-cjp> Where is it closed? I don't see that anywhere.
02:04 -!- kexkey [~kexkey@68.168.122.228] has quit [Ping timeout: 245 seconds]
02:48 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:59 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
03:17 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Ping timeout: 246 seconds]
04:52 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
04:58 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #c-lightning
05:57 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
06:07 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 244 seconds]
06:08 <@cdecker> jb55: rusty actually has a hook under development that shares DB updates with plugins, so you could actually run a remote DB that just replicates synchronously any change to the DB
06:09 <@cdecker> Good q bitonic-cjp
06:10 < bitonic-cjp> I actually got an opendir related memory error from a user, so I found this.
06:15 < m-schmoock> cdecker: do you think we need a wildcard `setchannelfee '*' ` in order to to be able to set new fees for all channels? We lost the ability to do so, since the database migration will 'freeze' all channel fees to config value at the time of the DB update.
06:16 < m-schmoock> Or would that be bike-shedding?
06:29 -!- booyah [~bb@193.25.1.157] has joined #c-lightning
06:54 -!- kexkey [~kexkey@68.168.122.228] has joined #c-lightning
07:02 -!- Letze [uid63391@gateway/web/irccloud.com/x-xjozsbrznrnnwrst] has quit [Quit: Connection closed for inactivity]
07:20 -!- shesek [~shesek@unaffiliated/shesek] has joined #c-lightning
08:03 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has quit [Quit: Leaving]
08:41 -!- harding [~quassel@li1258-130.members.linode.com] has quit [Ping timeout: 245 seconds]
08:43 -!- harding [~quassel@li1258-130.members.linode.com] has joined #c-lightning
09:59 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
10:14 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
10:59 <@cdecker> Hm, not sure, I'd like to have the fees not be frozen if they weren't set explicitly (so a NULL in the DB to indicate default fees apply, non-NULL for custom fees for this channel)
10:59 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
11:12 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 245 seconds]
11:59 < m-schmoock> cdecker: that was my first proposed and, due to lack of input, also implemented solution. rusty didnt like it and stated explicitly that he is fine with freezing all channel fees for existing channels, hence PR #2394 merged, after I pointed out the fact that we loose the ability to set channel fees for existing channels. Now the "*" "any" / "all" wildcard setchannelfee is my proposal to come
11:59 < m-schmoock> around that.
12:00 < m-schmoock> just tell me, its not like I tried to ask a lot of times for the open issues. I can also implement and maintain several PRs and you choose :D
12:01 <@cdecker> Ok, must've missed that in the discussion, sorry for that
12:01 <@cdecker> In that case the "all" sounds fine to me :-)
12:02 < m-schmoock> :D
12:02 < m-schmoock> I updated the manpage of the config.5.txt to point out that we will loose the ability set fees for all channels
12:03 < m-schmoock> i dont like it either btw
12:03 < rusty> m-schmoock: we can always add it later if there's demand.
12:03 < m-schmoock> rusty: so no "all" option for the moment?
12:04 < rusty> m-schmoock: well, if you're already implemented it, sure.
12:04 < rusty> My main object to the global/local split is db complexity. I prefer to keep the representation simple.
12:06 < m-schmoock> okay, then all is left to do is to figure out why test_setchannelfee_restart fails occasionally on the travis, and get a go on the modifications AMOUNT_MSAT u32 accessors...
12:06 < m-schmoock> rusty: the migrations DB hooks having the *ld pointer are called by the wallet tests with NULL
12:07 < m-schmoock> will require all future migrations to have a early return check or will fail on testing
12:07 < m-schmoock> other than that they work as expected
12:07 < rusty> m-schmoock: ah yes, we should fix the tests in that case, ideally in a separate commit.
12:08 -!- kanzure [~kanzure@unaffiliated/kanzure] has quit [Ping timeout: 246 seconds]
12:09 < m-schmoock> okay, i can open up an issue, but I dont have a good idea on how to solve it in a fine way
12:09 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #c-lightning
12:15 < m-schmoock> rusty: https://github.com/ElementsProject/lightning/issues/2442
12:18 < rusty> m-schmoock: pass ld to db_migrate() instead of NULL?
12:18 < rusty> run-wallet.c:694
12:18 < rusty> db-migrate needs a but more work, but it can allocate a dummy too.
12:19 < rusty> I don't like hacking real code to make tests work, though it's sometimes necessary.
12:31 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Quit: WeeChat 2.4]
12:39 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
12:39 < m-schmoock> rusty: yes that will probably fix it for the wallet unittest
12:40 < m-schmoock> but there is also wallet/test/run-db.c
12:40 < m-schmoock> where we currently dont have a ld pointer
12:40 < m-schmoock> im fine with early return, just wanted to tell you this, as this feature is new and not battle hardened yet
12:53 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
12:56 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #c-lightning
13:19 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 244 seconds]
13:22 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #c-lightning
13:52 -!- raucao [~raucao@skippe2.nine.ch] has quit [Ping timeout: 272 seconds]
13:52 -!- raucao [~raucao@skippe2.nine.ch] has joined #c-lightning
14:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
14:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #c-lightning
14:32 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
14:40 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
15:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
15:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #c-lightning
15:20 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
15:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds]
15:27 -!- makey40 [~jodie@24.215.123.241] has joined #c-lightning
15:50 < m-schmoock> rusty: Maybe just prevent migrate hooks being called without *ld? https://github.com/ElementsProject/lightning/pull/2444
15:55 -!- makey40 [~jodie@24.215.123.241] has quit [Quit: WeeChat 1.0.1]
16:20 -!- makey40 [~jodie@24.215.123.241] has joined #c-lightning
16:32 < rusty> m-schmoock: ah, the Morton technique! I shall implement the test change and push to that PR...
16:35 < m-schmoock> be my guest
16:38 -!- ungenannter [~ungenannt@colin.chaoshosting.de] has quit [Ping timeout: 244 seconds]
16:39 -!- ungenannter [~ungenannt@colin.chaoshosting.de] has joined #c-lightning
17:00 < rusty> m-schmoock: pushed... if travis is OK, happy to apply in a few hours
17:05 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
17:56 < molz> what's tests/test_closing.py::test_closing_torture ? it's taking a long time
18:09 * grubles attempts to build on openbsd 6.4
18:33 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
18:35 < molz> wen windows, grubles ? :P
18:36 < molz> both of my testnet nodes on a same server crashed, not sure when, maybe a week ago
18:36 < molz> updated now they're running
18:46 < grubles> yeah someone asked me about windows the other day
18:47 < grubles> wonder if it's doable with the ubuntu subsystem
18:48 < grubles> molz: got crash logs?
18:54 < molz> grubles, i wouldn't run it on wsl if that's what you're talking about
18:54 < molz> grubles, yea but i guess you don't need the crash logs now? the nodes are ok
19:47 -!- mn3monic [jsz@unaffiliated/mn3monic] has quit [Excess Flood]
19:47 -!- mn3monic [jsz@unaffiliated/mn3monic] has joined #c-lightning
19:55 < grubles> still useful to have i think
20:01 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
20:10 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
20:17 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
20:23 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
20:34 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
22:23 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #c-lightning
23:18 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
23:20 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 255 seconds]
23:22 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds]
23:36 < jb55> just tried to cross-compile to windows using mingw, hitting this: https://jb55.com/s/cba75e41ef5de50e.txt odd...
23:45 < jb55> oh right it builds the configurator as a windows exe and trys to run it... derp
--- Log closed Tue Mar 05 00:00:07 2019