--- Log opened Wed Mar 06 00:00:07 2019 00:34 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 00:44 -!- spinza [~spin@155.93.246.187] has joined #c-lightning 01:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 255 seconds] 01:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning 01:35 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has joined #c-lightning 02:01 -!- kexkey [~kexkey@68.168.122.228] has quit [Read error: Connection reset by peer] 02:25 -!- koting [af9eda12@gateway/web/freenode/ip.175.158.218.18] has joined #c-lightning 02:40 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 02:48 -!- spinza [~spin@155.93.246.187] has joined #c-lightning 03:07 -!- koting [af9eda12@gateway/web/freenode/ip.175.158.218.18] has quit [] 05:56 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 244 seconds] 07:04 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 07:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 07:29 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning 08:00 -!- kexkey [~kexkey@68.168.122.228] has joined #c-lightning 08:26 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #c-lightning 08:30 -!- kexkey [~kexkey@68.168.122.228] has quit [Quit: Scaling pentatonically] 08:31 -!- kexkey [~kexkey@68.168.122.228] has joined #c-lightning 08:45 -!- kexkey [~kexkey@68.168.122.228] has quit [Quit: Scaling pentatonically] 08:58 -!- kexkey [~kexkey@68.168.122.228] has joined #c-lightning 09:02 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has quit [Quit: Leaving] 09:55 -!- kexkey [~kexkey@68.168.122.228] has quit [Quit: Scaling pentatonically] 09:56 -!- kexkey [~kexkey@68.168.122.228] has joined #c-lightning 10:12 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 10:34 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #c-lightning 10:45 -!- kexkey [~kexkey@68.168.122.228] has quit [Quit: Scaling pentatonically] 11:44 -!- mn3monic [~xxwa@unaffiliated/mn3monic] has joined #c-lightning 11:50 -!- kexkey [~kexkey@68.168.122.228] has joined #c-lightning 12:16 -!- kexkey [~kexkey@68.168.122.228] has quit [Read error: Connection reset by peer] 12:17 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 12:35 -!- spinza [~spin@155.93.246.187] has joined #c-lightning 12:40 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning 13:00 -!- kexkey [~kexkey@68.168.122.228] has joined #c-lightning 13:40 -!- Letze [uid63391@gateway/web/irccloud.com/x-lttczruwwyauosee] has joined #c-lightning 13:45 < m-schmoock> cdecker: what do you think about https://github.com/ElementsProject/lightning/pull/2449 I kinda dislike all current soltions (including this PR). Having all DB hooks to early return is bad, because may get forgotton and also the tests may not run correctly because of this. Only calling migrations if *ld is set has the same disadvantage without the boilerplate. Having the test stub just allocating 13:45 < m-schmoock> zero memory may cause the migrations added in the future to run into problems... this stupid issue is really the last obstacle for the setchannelfee pr :/ 14:01 < m-schmoock> we could use as standard stub generated by the db migration before calling the hook whenever *ld was null. with this standard stub simply the testnet config lis loaded (for the moment). this is cleaner and no boilerplate. unittests can simply pass NULL on migrations if they want a generated test stub 14:06 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 14:07 < m-schmoock> or maybe go for the zero allocation and have the next one discover the magic :D 14:28 -!- spinza [~spin@155.93.246.187] has joined #c-lightning 14:30 < m-schmoock> I tried to have a setup_test_stub(*ld) functions in the `lightningd/options.h` but the linker of the unit test dislike it, when I include the config.o file it wants to have everything else :[ 15:05 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds] 15:17 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning 15:17 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 240 seconds] 15:22 -!- booyah [~bb@193.25.1.157] has joined #c-lightning 16:16 < ctrlbreak> m-schmoock : I'm so happy your helping by coding something I'm looking forward to! I wish I had enough experience to be of assistance :-S 16:25 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 16:25 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Client Quit] 16:37 -!- Letze [uid63391@gateway/web/irccloud.com/x-lttczruwwyauosee] has quit [Quit: Connection closed for inactivity] 16:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 17:25 -!- makey40 [~jodie@24.215.123.241] has quit [Ping timeout: 255 seconds] 17:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds] 18:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 18:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning 19:24 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Remote host closed the connection] 19:25 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #c-lightning 19:51 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 19:51 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 20:26 -!- Netsplit *.net <-> *.split quits: fiatjaf, molz, gwillen 20:28 -!- Netsplit over, joins: gwillen 20:53 -!- fiatjaf [~fiatjaf@162.243.220.95] has joined #c-lightning 20:53 -!- molz [~molly@unaffiliated/molly] has joined #c-lightning 21:07 -!- mn3monic [~xxwa@unaffiliated/mn3monic] has quit [Ping timeout: 244 seconds] 21:22 -!- rh0nj [~rh0nj@88.99.167.175] has joined #c-lightning 21:30 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Remote host closed the connection] 21:30 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #c-lightning 22:15 < blockstream_bot> [Tim Ho, Blockstream] Hi, I'm trying to post logs for this issue I filed https://github.com/ElementsProject/lightning/issues/2455 - but there are so many lines in the log file. Any suggestions? Should I paste everything? 22:49 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 246 seconds] 23:25 -!- spinza [~spin@155.93.246.187] has joined #c-lightning --- Log closed Thu Mar 07 00:00:08 2019