--- Log opened Wed May 08 00:00:06 2019 00:39 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 00:57 -!- booyah [~bb@193.25.1.157] has quit [Remote host closed the connection] 01:41 <@cdecker> I'm not sure the direction is actually needed. Can you just exclude the channel without the direction? 01:42 <@cdecker> drexl: you'd probably want to register a webhook and then check for completion and call it yourself if it was already completed, this way you have overlapping coverage and are sure to get notified 01:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 01:57 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has joined #c-lightning 02:10 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 252 seconds] 02:11 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #c-lightning 02:12 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 246 seconds] 02:18 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning 02:31 < m-schmoock> cdecker: are you sure about this that the direction is not needed, then we can update PR https://github.com/lightningd/plugins/pull/18 not to include both directions manually 02:31 < m-schmoock> otherwise the PR works 02:31 <@cdecker> I'll check and review the PR 02:35 < m-schmoock> I think I will make a PR to exclude multiple failing erring_node from the subsequent getroute calls to come along dysfunctional LNBIG or 020e56a13babec99abdc2c4afbe34e1e44230d79b234c059fd4ff1e367765fdb1b (MiltonPusser.lightningnode.eu) 02:36 < m-schmoock> this is so stupid otherwise that pointless gighubs prevent us from routing once they start to behave incorrectly 02:38 < m-schmoock> is it reasonable to penalize nodes a bit that throw a lot of subsequential "WIRE_TEMPORARY_CHANNEL_FAILURE" on different channels? 02:41 < m-schmoock> (will be in the plugin repo rebalance for the moment) 02:41 < m-schmoock> not sure for a long term solution 03:11 <@cdecker> We should probably bias against them, but not exclude them outright 03:22 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 03:23 -!- ulrichard [~richi@dzcpe6300borminfo01-e0.static-hfc.datazug.ch] has quit [Ping timeout: 255 seconds] 03:38 -!- spinza [~spin@155.93.246.187] has joined #c-lightning 04:04 < fiatjaf> the pay plugin uses directions: https://github.com/ElementsProject/lightning/blob/fefe7dfbab079553ac7f394f6ecc81ccaf206b3b/plugins/pay.c#L401 04:08 < fiatjaf> oh, so that was my error: I was excluding a channel but getroute wasn't using it at all, it was in a routehint and was added later by myself. 04:09 < fiatjaf> sorry. 04:15 < fiatjaf> "'exclude' is a JSON array of short-channel-id/direction (e.g. [ "564334x877x1/0", "564195x1292x0/1" ]) which should be excluded from consideration for routing. The default is not to exclude any channels." 04:17 < fiatjaf> apparently the direction is needed indeed: https://github.com/ElementsProject/lightning/blob/aa00e26765076fca0255e842a4e9093423550d55/lightningd/gossip_control.c#L326-L330 04:18 < fiatjaf> but ok, my problem is solved. 04:35 -!- ulrichard [~richi@dzcpe6300borminfo01-e0.static-hfc.datazug.ch] has joined #c-lightning 04:53 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 246 seconds] 04:55 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 255 seconds] 04:55 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #c-lightning 05:00 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #c-lightning 05:01 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 268 seconds] 05:09 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning 05:18 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 246 seconds] 05:18 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 246 seconds] 05:19 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #c-lightning 05:19 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning 05:26 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #c-lightning 05:40 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has joined #c-lightning 05:45 <@cdecker> Oh, sorry for the misinformation, I should have checked 05:53 < m-schmoock> yes, when doing the change in getroute we should bias towards nodes that did not have (ye) multiple failures 05:54 < m-schmoock> for testing in a plugin I can 'bias' in a way that I exclude each nth-time geroute request based on how bad the node performs 05:55 < m-schmoock> not cool, but at least a payment should not be completely blocked by some malfunctioning giant node (which it did several times, i have the logs) 05:56 < m-schmoock> do you think biasing towards nodes with less channels is a reasonable approach? 05:58 <@cdecker> No idea, might be worth checking though 06:03 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning 06:06 < m-schmoock> in the end giant nodes means centralization and centralization means point of failure (as also in this case). also we should not encourage centralization 06:08 < m-schmoock> hm, an AB test would require to use the probe plugin to do 1000 payments with biasing for smaller channels and same amount without :D 06:09 < m-schmoock> is the getroute algo currently already biasin towards channels with higher capacity? 06:55 <@cdecker> m-schmoock: I have a new plugin you might like https://github.com/lightningd/plugins/pull/20 06:56 <@cdecker> It automatically reloads a plugin if it detects a change in its binary, without needing to restart `lightningd` :-) 06:57 <@cdecker> It has some caveats, but I personally find it really useful for developing :-) 07:00 <@cdecker> Also I think I have a fix to the failing argument binding in plugin RPC method calls, it's in my cleanup queue, but once it's merged we should have default arguments working again :-) 07:02 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Read error: Connection reset by peer] 07:11 < m-schmoock> cdecker: <3 I will have a look ! 07:24 <@cdecker> lol, github thinks you're from the future: "m-schmoock commented 7 hours from now" :-) 07:30 < m-schmoock> its because i am, as you can see on my twitter profile: https://twitter.com/SchmoockMichael 07:30 < m-schmoock> :D 07:35 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 07:42 < m-schmoock> cdecker: in the other PR you are from the future as well 07:44 -!- spinza [~spin@155.93.246.187] has joined #c-lightning 08:04 < m-schmoock> uuuuh, found a reproducable gossip_store crash (gossipctl) at startup 08:16 -!- ulrichard [~richi@dzcpe6300borminfo01-e0.static-hfc.datazug.ch] has quit [Remote host closed the connection] 08:53 < m-schmoock> cdecker: see my review :D 09:02 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has quit [Quit: Leaving] 10:40 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #c-lightning 11:09 <@cdecker> OK, addressed te first few points as fixups 11:10 <@cdecker> Please don't merge the PR yet, since I need to autosquash them into the correct commits once we have ACKs 11:32 < m-schmoock> cdecker: I know. I also added another remark about syntax error handling 11:32 < m-schmoock> currently the autoreloader fails to recover from syntax errors 11:34 < m-schmoock> i would only merge if author removed the work in progress himself (when he can :) 11:38 < m-schmoock> also https://github.com/lightningd/plugins/pull/14 is finalized... 11:40 < m-schmoock> just noticed, collaborators cannot merge master on plugins repo anyway ;) 11:41 <@cdecker> Hm, ok should fix that if my review capacity is exceeded :-) 11:41 <@cdecker> Will review asap 11:41 < m-schmoock> np, we need to get workload off you ;) 11:42 < m-schmoock> tell me if we can optimize anything in the workflow 11:42 <@cdecker> Not sure how to fix the issue of syntax errors though 11:42 <@cdecker> Pretty sure we can't proceed if the first run fails 11:42 <@cdecker> BUt after that we could add a preflight check 11:42 < m-schmoock> that wouldnt be a big deal 11:43 <@cdecker> (Run pep8 or plugin.py --help before restarting 11:43 < m-schmoock> yep, i think its fine for a syntax error that got in there during 'runtime' 11:44 <@cdecker> I'll see what I can come up with 11:44 < m-schmoock> we can offload it to a later issue/pr 11:44 < m-schmoock> you decide 11:46 < m-schmoock> ... i need to rest, my arm hurts like crazy. cu l8er 11:47 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Remote host closed the connection] 11:47 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #c-lightning 11:50 <@cdecker> You do that, cu later 11:51 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #c-lightning 12:00 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning 12:10 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds] 12:12 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #c-lightning 12:12 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 248 seconds] 12:24 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #c-lightning 12:31 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning 12:45 < fiatjaf> ok, I'm trying to make a plugin. I just set up the most simple STDIN/STDOUT interface possible and was able to make init/getmanifest working and get my custom rpc commands on lightningd. now when I call my custom method from lightning-cli it doesn't matter what I answer, the reply I get in the shell is always {"code":0,"message":"","data":null} 12:45 < fiatjaf> does anyone know why? 12:47 < fiatjaf> nevermind, just realized I can't return bare strings as the "result". 12:48 < fiatjaf> actually I was returning invalid json. 12:48 < fiatjaf> ignore me. 13:09 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Ping timeout: 258 seconds] 13:17 -!- gnusha [~gnusha@unaffiliated/kanzure/bot/gnusha] has joined #c-lightning 13:17 -!- Topic for #c-lightning: Chat about the C-lightning implementation: https://github.com/ElementsProject/lightning https://lists.ozlabs.org/listinfo/c-lightning Current Version: https://github.com/ElementsProject/lightning/releases/tag/v0.7.0 Logs at http://gnusha.org/c-lightning/ 13:17 -!- Topic set by rusty [~rusty@pdpc/supporter/bronze/rusty] [Fri Mar 1 13:43:22 2019] 13:17 [Users #c-lightning] 13:17 [@cdecker ] [ cubancorona] [ gnusha ] [ Kostenko ] [ Nukeops ] [ StopAndDecrypt] 13:17 [@niftynei ] [ CubicEarth ] [ gwillen ] [ lio17 ] [ qubenix ] [ t0mix ] 13:17 [ achow101 ] [ d3spwn ] [ harding ] [ m-schmoock ] [ queip ] [ takinbo ] 13:17 [ adam3us ] [ designwish ] [ jb55 ] [ michaelsdunn1 ] [ rafalcpp_ ] [ tigermousr ] 13:17 [ Amperture ] [ dmkathayat ] [ jonasschnelli ] [ michaelsdunn1_] [ rh0nj ] [ tweaks ] 13:17 [ belcher ] [ drolmer ] [ jtimon ] [ midnightmagic ] [ roasbeef ] [ Victorsueca ] 13:17 [ berndj ] [ EagleTM ] [ justanotheruser] [ molz ] [ rotarydialer] [ warren ] 13:17 [ blockstream_bot] [ fiatjaf ] [ k3tan ] [ Nebraskka ] [ RubenSomsen ] [ wraithm ] 13:17 [ cncr04s ] [ GAit ] [ kanzure ] [ nibbier ] [ spaced0ut ] 13:17 [ ctrlbreak ] [ ghost43 ] [ keymone ] [ nothingmuch ] [ spinza ] 13:17 -!- Irssi: #c-lightning: Total of 58 nicks [2 ops, 0 halfops, 0 voices, 56 normal] 13:17 -!- Channel #c-lightning created Mon Mar 13 17:49:31 2017 13:17 -!- Irssi: Join to #c-lightning was synced in 48 secs 14:16 < t0mix> anybody around who successfully used plugin "summary" already? 15:04 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 15:11 -!- spinza [~spin@155.93.246.187] has joined #c-lightning 15:26 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 16:41 -!- booyah [~bb@193.25.1.157] has joined #c-lightning 18:15 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 248 seconds] 18:53 -!- jtimon [~quassel@181.61.134.37.dynamic.jazztel.es] has quit [Quit: gone] 21:29 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [] 22:36 -!- ulrichard [~richi@dzcpe6300borminfo01-e0.static-hfc.datazug.ch] has joined #c-lightning 22:38 < m-schmoock> t0mix: here. whats the deal? 22:40 < m-schmoock> you need pylightning module installed or in the PYTHONPATH env variable. thats the most common mistake I guess. 22:43 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 22:53 -!- spinza [~spin@155.93.246.187] has joined #c-lightning 23:04 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning 23:21 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 248 seconds] 23:44 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 255 seconds] --- Log closed Thu May 09 00:00:07 2019