--- Log opened Wed May 15 00:00:13 2019
00:46 -!- Ed0 [~edouard@2001:41d0:401:3100::4897] has joined #c-lightning
01:04 -!- alko89 [~alko@BSN-77-147-172.static.siol.net] has joined #c-lightning
01:07 < alko89> hi, how does one update a lightning node with open channel?
01:21 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has joined #c-lightning
01:33 -!- Amperture [~amp@24.136.5.183] has quit [Ping timeout: 246 seconds]
01:44 < m-schmoock> alko89: if its not incredibly outdated, you can always just 'lightning-cli stop' ... update stuff 'lightningd --daemon'  done
01:45 < m-schmoock> it will update the sqlite database scheme as it detects outdated scheme
01:45 < m-schmoock> tipp: make a backup of you ~/.lightning dir
01:45 < m-schmoock> at least i never had a update problem
01:46 < alko89> ok, great! I have backed up hsm_secret
01:47 < alko89> was wondering if I have to do anything else, except gracefuly stop the node
01:47 < alko89> thanks!
02:04 -!- booyah [~bb@193.25.1.157] has joined #c-lightning
02:27 < m-schmoock> no worries
02:27 < m-schmoock> did it work as expected?
03:03 < m-schmoock> cdecker: is it possible to create an invoice without an amount via the rpc interface? technically it should be, as eclair mobile has such a feature. I need this so I can drain/fill channels precisely substracting/adding the fees on the route without creating like 100 different invoices each try
03:03 < m-schmoock> if i simply use a different amount in the sendpay request, an error will be raised (for good reason)
03:05 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has quit [Quit: Leaving]
03:06 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Quit: %Gone to become more spherical%]
03:07 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #c-lightning
03:10 < alko89> it worked, no issues
03:40 -!- darosior [6dbe8dc1@gateway/web/freenode/ip.109.190.141.193] has joined #c-lightning
03:41 < m-schmoock> darosior: hey, good you tracked it down
03:42 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
03:42 < m-schmoock> additionally, you commited the "gossipd/.gossipd.c.swp" swapfile. please dont :D
03:43 < darosior> m-schmoock: Ooops
03:44 < m-schmoock> thats what reviews are for :D no offense, we are picky for a reason
03:46 < m-schmoock> darosior: the indentation :D. tell your IDE to make tabs visible. I use vim
03:46 < m-schmoock> set list                                                                           
03:46 < m-schmoock> set listchars=tab:>- 
03:46 < m-schmoock> (~/.vimrc)
03:48 < darosior> thanks you are quicker than google ^^
03:48 < m-schmoock> you use vim as well ?
03:48 < m-schmoock> nice
03:49 < darosior> Yes
03:50 < m-schmoock> And I thought I was a lonely dinosaur relic
03:50 < m-schmoock> I can help you out with some tab settings, toggle, and X buffer copy stuff if you need those...
03:51 < darosior> Thank you, I'll ask if I have a question :)
03:55 < m-schmoock> the syntax in our project is a bit unusual, but I always try to stick as most possible to the style I find
03:56 < m-schmoock> For example skipping curly braces {}, I only do this when I inline the condition with the statement. Less space, more readable, less failures when other people editing the same code and forget to add them ... but since we skip braces and indent everywhere, im fine
03:58 < m-schmoock> darosior: https://travis-ci.org/ElementsProject/lightning/jobs/532748732
03:58 < m-schmoock> C is fun
04:02 < m-schmoock> darosior: other topic, do you know a way to create an amount-less invoice like in eclair and such?
04:04 < darosior> m-schmoock: I think there is a plugin for that in lightningd/plugins ?
04:06 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
04:07 < m-schmoock> nope, thats sendinvoiceless. I mean an invoice where the payee can choose the amount
04:08 < m-schmoock> like in eclair wallet when receiving LN, the amount is optional but its still a bolt11 request
04:08 < darosior> Ah I didnt know that
04:08 < darosior> It would be great as a plugin
04:17 < darosior> m-schmoock: The `invoice` RPC command : "The msatoshi parameter can be the string "any", which creates an invoice that can be paid with any amount."
04:18 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has joined #c-lightning
04:47 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has quit [Quit: Leaving]
05:43 < m-schmoock> darosior: whopsie :D thx
05:43 < m-schmoock> rtfm 
05:53 -!- designwish [~designwis@51.ip-51-68-136.eu] has quit [Quit: ZNC - http://znc.in]
05:53 < darosior> ^^
05:54 -!- designwish [~designwis@51.ip-51-68-136.eu] has joined #c-lightning
06:10 < m-schmoock> darosior: still no good :/ https://travis-ci.org/ElementsProject/lightning/jobs/532801784
06:11 < darosior> Yeah, this was firstly `node_arr` that was used not initialized too, I'm on this one
06:13 < m-schmoock> the thing is in line 2224 it assignes to NULL (which it can even unitialized)
06:13 < m-schmoock> but you test later, which you shouldnt, as you cant know if the NULL assigment earlier was actually made
06:14 < m-schmoock> cheap would be to initialize the variable with NULL anyway, but its heavily disencouraged, as we loose valgrind memory access precision
06:16 < m-schmoock> I wnder why that NULL assignment in line 2224 is made anyway
06:18 < m-schmoock> I dont understand this particular code very well, maybe add decker or rusty in the loop
06:22 < darosior> I finally initialized **nodes to NULL and removed the else part
06:22 < darosior> Why do we lose valgrind memory access precision if we do so ?
07:00 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #c-lightning
07:42 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #c-lightning
07:50 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
08:14 -!- ulrichard [~richi@dzcpe6300borminfo01-e0.static-hfc.datazug.ch] has quit [Remote host closed the connection]
08:22 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit []
08:23 -!- queip [~queip@unaffiliated/rezurus] has quit [Quit: bye, freenode]
08:25 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
08:25 -!- Amperture [~amp@24.136.5.183] has joined #c-lightning
08:34 < m-schmoock> darosior: decker will tell you in his review :D
08:35 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-enavimqrwmsgirdu] has quit [Remote host closed the connection]
08:37 < m-schmoock> i think it is still wrong...
08:37 < m-schmoock> it should be sufficient to just check the node_arr variable
08:38 < m-schmoock> but we will get the unitiliazed foo then as well...
08:42 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #c-lightning
08:44 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-awleibpncfpfpwzs] has joined #c-lightning
08:48 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning
08:48 < darosior> Yeah I tested it with just node_arr as well, this one is the only I got working but now some (unrelated) tests wont pass
08:49 -!- darosior [6dbe8dc1@gateway/web/freenode/ip.109.190.141.193] has quit [Quit: Page closed]
08:50 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #c-lightning
09:16 < m-schmoock> nah, this isnt right (yet)
09:21 < m-schmoock> its like all test pipelines are red, this _is_ related
09:21 < m-schmoock> test fail because listnodes doesn behave correctly
10:28 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 268 seconds]
10:36 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Quit: %Gone to become more spherical%]
10:38 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #c-lightning
12:43 -!- darosior [52ff9820@gateway/web/freenode/ip.82.255.152.32] has joined #c-lightning
13:03 < darosior> m-schmoock: I think I finally got it, it was way simpler than what I tried ...
13:14 -!- booyah [~bb@193.25.1.157] has quit [Quit: Konversation terminated!]
14:00 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has quit [Remote host closed the connection]
14:01 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has joined #c-lightning
14:01 < m-schmoock> looks good now :D
14:04 < m-schmoock> darosior: I just acked as code and jenkins look good now, will still try the patch on my master mainnet node
14:04 < m-schmoock> thx
14:04 < m-schmoock> !
14:06 < darosior> \O/
14:07 < m-schmoock> stupid little bug 
14:08 < m-schmoock> YAY it works
14:15 -!- darosior [52ff9820@gateway/web/freenode/ip.82.255.152.32] has quit [Quit: Page closed]
14:27 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Ping timeout: 244 seconds]
14:38 -!- booyah [~bb@193.25.1.157] has joined #c-lightning
14:47 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has quit [Remote host closed the connection]
15:18 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
15:52 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
16:06 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
16:19 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has joined #c-lightning
17:53 -!- nibbier [~quassel@geekbox.info] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
17:59 -!- belcher [~belcher@unaffiliated/belcher] has joined #c-lightning
18:26 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning
19:12 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
19:39 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
20:09 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has quit [Remote host closed the connection]
20:09 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
20:09 -!- k3tan [k3tan@gateway/vpn/protonvpn/k3tan] has joined #c-lightning
20:30 -!- spinza [~spin@155.93.246.187] has joined #c-lightning
22:09 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #c-lightning
22:15 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-awleibpncfpfpwzs] has left #c-lightning []
22:16 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-awleibpncfpfpwzs] has joined #c-lightning
22:30 -!- ulrichard [~richi@dzcpe6300borminfo01-e0.static-hfc.datazug.ch] has joined #c-lightning
23:28 -!- alko89 [~alko@BSN-77-147-172.static.siol.net] has quit [Ping timeout: 246 seconds]
--- Log closed Thu May 16 00:00:14 2019