--- Log opened Fri Jul 05 00:00:02 2019
00:54 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 260 seconds]
00:57 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning
00:57 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 268 seconds]
00:59 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning
01:00 -!- bitonic-cjp [~bitonic-c@92-111-70-106.static.v4.ziggozakelijk.nl] has joined #c-lightning
01:43 -!- reallll [~belcher@unaffiliated/belcher] has joined #c-lightning
01:46 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]
01:52 -!- reallll is now known as belcher
02:53 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
03:00 -!- spinza [~spin@102.132.245.16] has joined #c-lightning
03:05 -!- lxer [~lx@95.91.214.128] has joined #c-lightning
03:09 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
03:19 -!- spinza [~spin@102.132.245.16] has joined #c-lightning
03:30 -!- darosior [5ba5be47@91-165-190-71.subs.proxad.net] has joined #c-lightning
04:35 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds]
04:38 <@cdecker> MrHash: Did you specify `--network=liquid`, in bitcoin mode we don't parse elements formatted blocks :-)
04:38 <@cdecker> And yes, the branch requires a bit of cleanup (and review) before making it into `master`.
04:38 <@cdecker> Specifically I haven't settled on how to specify the asset tag for the fee-currency
05:59 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds]
06:07 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning
06:27 -!- belcher [~belcher@unaffiliated/belcher] has joined #c-lightning
06:43 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #c-lightning
07:48 < darosior> cdecker: I noticed the use of `fixup!` comments in others' PRs, under which conditions should we prefer them to a rebase ?
07:49 < jb55> darosior: those just mark commits so that they can be squashed into adjacent commits using rebase --autosquash
07:50 < darosior> jb55: Thanks
07:52 < jb55> darosior: I prefer to only keep fixup commits on my local branch, and squash+push -f when I want to push a new patch set
07:52 < jb55> darosior: you can always view the diff of the two branches anyways... so pushing fixup commits is a bit weird to me
08:06 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
08:07 -!- rh0nj [~rh0nj@88.99.167.175] has joined #c-lightning
08:21 <@cdecker> darosior: I usually do fixups during the reviwe process, still rebasing the entire stack from time to time, to avoid conflicts.
08:21 <@cdecker> The fixups are mainly used to call out how review comments have been addressed and to ease the burden on reviewers
08:22 <@cdecker> Also `git range-diff` is really nice with fixups since it really calls out any changes that happened inbetween reviews
08:23 <@cdecker> I have some tooling that will provide those things in a web ui, I just need time to actually get them out the door and link to them in the PRs
08:23 < darosior> Ok, thanks !
08:41 -!- cryptoso- [~cryptosoa@gateway/tor-sasl/cryptosoap] has quit [Quit: %bye%]
08:41 -!- cryptosoap [~cryptosoa@gateway/tor-sasl/cryptosoap] has joined #c-lightning
08:45 < jb55> cdecker: sounds interesting, is the code up anywhere?
08:46 <@cdecker> Hm, not yet
08:46 <@cdecker> But this is the account that will run the bot https://github.com/bitcoin-bot
09:45 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 260 seconds]
09:48 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning
11:09 -!- darosior [5ba5be47@91-165-190-71.subs.proxad.net] has quit [Remote host closed the connection]
12:25 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds]
12:32 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning
12:43 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 248 seconds]
12:51 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning
13:07 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds]
13:09 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning
13:51 -!- darosior [5ba5be47@91-165-190-71.subs.proxad.net] has joined #c-lightning
14:02 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
14:10 -!- spinza [~spin@102.132.245.16] has joined #c-lightning
14:30 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 252 seconds]
15:14 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 248 seconds]
15:19 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning
15:54 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
16:04 -!- spinza [~spin@102.132.245.16] has joined #c-lightning
16:09 -!- lxer [~lx@95.91.214.128] has quit [Ping timeout: 245 seconds]
17:01 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #c-lightning
17:06 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 258 seconds]
17:11 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning
17:43 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 245 seconds]
18:15 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
18:34 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
18:37 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
19:46 -!- cryptosoap [~cryptosoa@gateway/tor-sasl/cryptosoap] has quit [Quit: %bye%]
19:48 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 260 seconds]
19:49 -!- cryptosoap [~cryptosoa@gateway/tor-sasl/cryptosoap] has joined #c-lightning
19:49 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning
20:54 -!- darosior [5ba5be47@91-165-190-71.subs.proxad.net] has quit [Ping timeout: 260 seconds]
21:20 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
21:26 -!- spinza [~spin@102.132.245.16] has joined #c-lightning
21:45 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 245 seconds]
21:45 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning
22:52 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
22:53 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
--- Log closed Sat Jul 06 00:00:07 2019