--- Log opened Wed Dec 11 00:00:33 2019
00:16 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
00:20 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 245 seconds]
00:28 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
00:32 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 240 seconds]
00:40 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
00:40 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Client Quit]
00:41 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
00:46 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 276 seconds]
00:49 -!- kabaum [~kabaum@2001:9b1:efd:9b00::281] has joined #c-lightning
01:00 < vasild> What about "the strlen() check" when utf8 chars are involved?
01:06 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
01:10 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 245 seconds]
01:14 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
01:19 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 268 seconds]
01:20 < darosior> fiatjaf: just by me (approximatively half a meter :p), in France why ?
01:21 < darosior> vasild: When the unicode Koala is copy/pasted it is counted as 4 characters (as expected).
01:33 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
01:35 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Client Quit]
01:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 260 seconds]
01:47 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
01:47 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-nfufoseoysnzgsxq] has left #c-lightning []
01:47 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-nfufoseoysnzgsxq] has joined #c-lightning
02:15 < vasild> darosior: right, so it means that this description is wrong: "Up to 32 UTF-8 characters to tag your node"
02:16 < vasild> you can't have 32 Koalas ;(
02:18 < darosior> Hmmm right it's actually 32 bytes, and a Koala is 4 ^^
02:18 < darosior> I've a PR which touch this doc, will push a commit
02:29 -!- k3tan172 is now known as k3tan
02:32 < vasild> darosior: should the doc be adjusted or the code (to support 32 _characters_)?
02:33 < vasild> https://github.com/lightningnetwork/lightning-rfc/blob/master/07-routing-gossip.md#the-node_announcement-message says `32*byte`:`alias`, so I guess it is the doc
02:34 < darosior> Yep as I said above I've corrected the doc
02:35 < darosior> vasild: https://github.com/ElementsProject/lightning/pull/3328/commits/2a44c42ecaf1e548b36a6b56537f5143270fdfc6
02:37 < darosior> Thanks for the report
02:40 < vasild> darosior: I was going to submit this as PR: https://paste.gg/p/anonymous/bf4623ed4e0843959d1f1d4bfeff4c2a
02:41 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
02:41 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
02:41 < vasild> but you were quicker :)
02:41 < darosior> :)
02:42 < darosior> Yep saw this last night when I was confused with unicode
02:45 < vasild> https://github.com/ElementsProject/lightning/pull/3328/files#diff-5a542b0b5d584cc56b65063c8b13e410R258 this also needs a change: \fBcommit-time\fR='MILLISECONDS  -->  \fBcommit-time\fR=\fIMILLISECONDS\fR
02:45 < vasild> a separate PR?
02:45 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 245 seconds]
02:48 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
02:51 < darosior> Yeah, weird that make doc-all didnt detect that.. I'd suggest to delete the line and re-run make doc-all
02:51 < darosior> About the sperate PR as you want, I can also include your commit to mine
02:53 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
02:54 < vasild> I think easier to include the 'MILLISECONDS fixup in your PR, its really a minor change, no need to open separate PR for it and your PR is already closely related.
02:58 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 250 seconds]
02:59 < darosior> Ok then
03:06 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
03:11 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 276 seconds]
03:13 -!- reallll [~belcher@unaffiliated/belcher] has joined #c-lightning
03:17 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds]
03:19 < darosior> Do you have a commit I can cherry-picK?
03:21 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection]
03:21 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
03:31 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #c-lightning
03:40 < vasild> darosior: https://github.com/darosior/lightning/pull/1 :)
03:40 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
03:45 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 268 seconds]
03:47 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning
03:49 -!- Victor_sueca is now known as Victorsueca
03:50 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
03:53 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
03:57 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 265 seconds]
04:10 -!- MrHash [~mrhash@host31-54-194-75.range31-54.btcentralplus.com] has quit [Ping timeout: 265 seconds]
04:14 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
04:19 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 250 seconds]
04:27 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
04:28 -!- Amperture [~amp@65.79.129.113] has quit [Remote host closed the connection]
04:30 -!- Amperture [~amp@65.79.129.113] has joined #c-lightning
04:32 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 265 seconds]
04:39 < darosior> Nice thx :)
04:52 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
04:55 < fiatjaf> darosior, I meant to ask what was its id
04:57 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 268 seconds]
05:07 -!- Amperture [~amp@65.79.129.113] has quit [Remote host closed the connection]
05:09 -!- Amperture [~amp@65.79.129.113] has joined #c-lightning
05:15 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
05:20 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 268 seconds]
05:22 < fiatjaf> I just want to see the emote
05:36 -!- Amperture [~amp@65.79.129.113] has quit [Remote host closed the connection]
05:36 < darosior> fiatjaf: 03678b4f041fbfbeebcafc076469df75decf81da20a53bd490172e83ce532df1fa
05:37 -!- Amperture [~amp@65.79.129.113] has joined #c-lightning
05:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection]
05:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
05:40 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
05:44 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 240 seconds]
05:50 -!- Amperture [~amp@65.79.129.113] has quit [Remote host closed the connection]
05:51 -!- Amperture [~amp@65.79.129.113] has joined #c-lightning
05:51 -!- Amperture [~amp@65.79.129.113] has quit [Remote host closed the connection]
05:53 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
05:57 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 240 seconds]
06:14 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
06:19 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 250 seconds]
06:45 -!- reallll is now known as belcher
07:00 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
07:01 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning
07:14 -!- mdunnio [~mdunnio@38.126.31.226] has joined #c-lightning
07:38 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
07:51 < fiatjaf> GOODBYE BLOCKCHAIN ??
08:18 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 276 seconds]
08:31 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack]
08:44 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning
08:47 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning
09:29 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
10:03 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #c-lightning
10:12 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
10:13 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning
10:14 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-nfufoseoysnzgsxq] has left #c-lightning []
10:14 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-nfufoseoysnzgsxq] has joined #c-lightning
10:42 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
10:42 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning
11:39 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning
11:41 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
11:47 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
11:56 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning
12:03 -!- tigermousr [~tigermous@unaffiliated/tigermousr] has quit [Ping timeout: 246 seconds]
12:05 -!- tigermousr [~tigermous@unaffiliated/tigermousr] has joined #c-lightning
12:34 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning
12:36 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 260 seconds]
13:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 260 seconds]
13:52 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
14:09 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
14:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
14:45 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:07 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
15:15 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #c-lightning
15:55 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds]
18:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Quit: Leaving]
18:30 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-nfufoseoysnzgsxq] has left #c-lightning []
18:30 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-nfufoseoysnzgsxq] has joined #c-lightning
19:59 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
20:19 -!- Kostenko [~Kostenko@2001:8a0:729a:3f00:c298:ebb2:64cf:151] has quit [Read error: Connection reset by peer]
21:11 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
21:18 -!- Kostenko [~Kostenko@2001:8a0:729a:3f00:c298:ebb2:64cf:151] has joined #c-lightning
--- Log closed Thu Dec 12 00:00:34 2019