--- Log opened Thu Jan 23 00:00:17 2020
00:03 -!- Netsplit over, joins: nothingmuch, fiatjaf, Kostenko, blockstream_bot
00:03 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning []
00:03 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning
00:45 -!- asoltys [~adam@115.96.198.104.bc.googleusercontent.com] has joined #c-lightning
00:58 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
01:13 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
02:26 -!- felixweis [sid154231@gateway/web/irccloud.com/x-dwybcsuvqtnhdgjd] has joined #c-lightning
02:34 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds]
02:55 -!- belcher [~belcher@unaffiliated/belcher] has joined #c-lightning
03:14 < vasild_> cdecker: wrt https://github.com/ElementsProject/lightning/pull/3397#issuecomment-576749616 "I'll add a cleanup that just does the endiannes conversion" -- what about this: 1. introduce an error code type (e.g. typedef int32_t errcode), 2. change all error code macros to constants (e.g. replace `#define CONNECT_NO_KNOWN_ADDRESS 400` with `const errcode CONNECT_NO_KNOWN_ADDRESS = 400;`), constants in 
03:14 < vasild_> general play better with gdb, 3. Change command_fail() and everybody else who takes error codes to take the new type `errcode` instead of `int`, 4. Introduce towire_errcode() and use it for interprocess communication (and remove the then unneeded towire_int())?
03:15 -!- vasild_ is now known as vasild
03:23 < zmnscpxj> vasild_: +1
03:24 < zmnscpxj> vasild: +1
03:25 < zmnscpxj> How about `double` though?
03:25 < vasild> Cool! I will take into that, time permitting, maybe over the weekend
03:25 < vasild> yes, next step would be to ditch towire_double()
03:25 < vasild> I do not know how yet
03:26 < zmnscpxj> We could revert back to just sending a `uint32_t` that maps `0`->`UINT32_MAX` to `0.0`->`1.0`, which is how it was done prior to `towire_double`/`fromwire_double`
03:27 < zmnscpxj> Ugly and loses precision arbitrarily but should be fine for most purposes, it is not as if fuzzing is a little random and the exact number is not that material, a ballpark approximation is fine
03:27 < vasild> yes, if that suffices and gets some ACKs, sounds like a good approach, another one would be to send a string like "12.23127368172123" and parse it
03:28 < zmnscpxj> NACK on string, parse overhead bad, and printing IEEE floats is not as straightforward as you might assume (though most `printf` `%f` impls work fine, could just depend on that ----- bleah)
03:28 < vasild> good (for the NACK), I did not like it either :)
03:29 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds]
03:29 < vasild> a map to 0->UINT64_MAX would increase the precision, and double it 8 bytes anyway
03:30 < zmnscpxj> yes but is overprecise IMO.  Well what we get from the JSON-RPC is a string anyway, not a double, so maybe ---- ~~~~~
03:30 < zmnscpxj> Strong *shrug*
03:31 < vasild> :)
04:22 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning
04:44 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 246 seconds]
05:22 -!- jonatack [~jon@213.152.162.79] has joined #c-lightning
06:19 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Quit: Leaving]
06:42 <@cdecker> vasild: I found that we have quite a couple of towire/fromwire things that don't do the endianness conversion, so I thought it doesn't make a lot o sense to add it for one case but not the other
06:42 <@cdecker> tl;dr: I gave up ^^
07:10 -!- jonatack [~jon@213.152.162.79] has quit [Ping timeout: 268 seconds]
07:27 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
07:28 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #c-lightning
07:40 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 240 seconds]
08:14 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning []
08:14 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning
09:00 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning
10:13 -!- Kostenko [~Kostenko@2001:8a0:7292:eb00:955f:ca16:a373:2da1] has quit [Remote host closed the connection]
11:20 -!- Amperture [~amp@65.79.129.113] has quit [Ping timeout: 272 seconds]
11:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
11:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
12:24 -!- orlovsky [~dr-orlovs@194.230.155.171] has quit [Quit: Textual IRC Client: www.textualapp.com]
12:25 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has joined #c-lightning
13:18 -!- Netsplit *.net <-> *.split quits: queip, tigermousr, ctrlbreak
13:20 -!- warren_ [~warren@fedora/wombat/warren] has quit [Ping timeout: 268 seconds]
13:22 -!- Netsplit over, joins: ctrlbreak
13:24 -!- warren [~warren@fedora/wombat/warren] has joined #c-lightning
13:33 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
13:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds]
13:50 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 248 seconds]
13:58 -!- jonatack [~jon@213.152.161.138] has joined #c-lightning
14:01 -!- tigermousr [~tigermous@unaffiliated/tigermousr] has joined #c-lightning
14:01 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning
14:15 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
14:56 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
16:14 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
16:27 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning []
16:28 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning
18:01 -!- Kostenko [~Kostenko@2001:8a0:7292:eb00:955f:ca16:a373:2da1] has joined #c-lightning
19:25 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
22:14 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Remote host closed the connection]
22:15 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
22:21 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
22:37 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Ping timeout: 240 seconds]
23:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
23:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
--- Log closed Fri Jan 24 00:00:19 2020