--- Log opened Mon Jan 27 00:00:23 2020
00:35 -!- orlovsky [~dr-orlovs@194.230.147.90] has joined #c-lightning
00:36 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Ping timeout: 240 seconds]
00:45 -!- orlovsky [~dr-orlovs@194.230.147.90] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
00:51 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has joined #c-lightning
01:30 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
01:48 -!- Amperture [~amp@65.79.129.113] has quit [Remote host closed the connection]
02:00 -!- belcher [~belcher@unaffiliated/belcher] has joined #c-lightning
02:12 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has joined #c-lightning
02:26 -!- orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #c-lightning
02:29 -!- dr-orlovsky [~dr-orlovs@194.230.147.90] has quit [Ping timeout: 260 seconds]
02:54 -!- orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
02:56 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #c-lightning
03:02 <@cdecker> darosior: bad how?
03:02 < darosior> Not that much
03:02 < darosior> We never checked for it elsewhere ^^
03:03 < darosior> https://github.com/ElementsProject/lightning/pull/3442
03:07 <@cdecker> Ah I see, thanks for fixing it so quickly ^^
03:09 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds]
03:10 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning []
03:10 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning
03:41 -!- jonatack [~jon@213.152.162.154] has joined #c-lightning
06:08 -!- jonatack [~jon@213.152.162.154] has quit [Ping timeout: 265 seconds]
08:07 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning
10:42 < darosior> I think I have a false positive Valgrind warning about uninitialized values use, is there any known ways to get around them ?
10:44 <@cdecker> darosior: on Travis? Can you share the link?
10:45 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning
11:15 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning []
11:15 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning
11:18 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
11:43 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
11:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
11:47 < vasild> darosior: a valgrind suppression?
11:58 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
12:02 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Ping timeout: 240 seconds]
12:03 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
12:25 -!- masterdonx2 [~masterdon@45.248.79.86] has joined #c-lightning
12:26 -!- MasterdonX [~masterdon@45.248.79.86] has quit [Read error: Connection reset by peer]
12:33 < darosior> cdecker, vasild: sorry, was AFK. It happens both locally and on Travis. It's about the "used" fields of the global "plugin" struct in #3443. They are initialized here https://github.com/ElementsProject/lightning/pull/3443/files#diff-bec1003dea639a96bf8e5028b4150f52R1022-R1026, but Valgrind will always signal them as uninitialized. I said "false
12:33 < darosior> positive", but it's surely a mistake on my side I've overlooked..
12:34 < darosior> "test_shutdown_reconnect" with VALGRIND=1 triggers it.
12:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
12:39  * vasild looking...
12:40 < darosior> Thank you
12:53 < vasild> navigating the source on github is a bit difficult, but it looks like that the call to rpc_conn_read_response(), shown in this backtrace https://travis-ci.org/ElementsProject/lightning/jobs/642519760#L24545 is happening before new_plugin() has been called?
12:54 < vasild> but that would be strange - could the plugin argument to rpc_conn_read_response() be uninitialized?
12:57 < vasild> darosior: could you split this in 2 separate lines:
12:57 < vasild> if (plugin->rpc_used && plugin->rpc_used == tal_count(plugin->rpc_buffer))
12:57 < vasild> to:
12:58 < vasild> if (plugin->rpc_used)
12:58 < vasild>   if (plugin->rpc_used == tal_count(plugin->rpc_buffer))
12:58 < vasild> and then we see if valgrind complains about the first or the second line
12:59 < darosior> "navigating the source on github is a bit difficult, but it looks like that the call to rpc_conn_read_response(), shown in this backtrace https://travis-ci.org/ElementsProject/lightning/jobs/642519760#L24545 is happening before new_plugin() has been called?" ==> That's not possible, the conn is instanciated *after* new_plugin()
12:59 < darosior> "if (plugin->rpc_used && plugin->rpc_used == tal_count(plugin->rpc_buffer))" ==> Already tried and Valgrind does complain
13:00 < darosior> About the first
13:00 < vasild> to rule if it is upset about "plugin->rpc_used" or is upset about "tal_count(plugin->rpc_buffer)"
13:00 < vasild> aha, so it is upset about "plugin->rpc_used"
13:00 < darosior> It's about the former I thing
13:00 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Ping timeout: 268 seconds]
13:00 < vasild> ok, then did somebody else write to plugin->rpc_used after it was intialized to 0?
13:01 < vasild> int x; int y = 0; ... y = x; ... no complain yet ... ; if (y) -- it will complain here about uninitialized y
13:01 < darosior> Hmm it's only writtent in rpc_conn_read_response()
13:01 < darosior> (And subsequent functions)
13:02 < darosior> "nt x; int y = 0; ... y = x; ... no complain yet ... ; if (y) -- it will complain here about uninitialized y" But y *is* initialized in this case, isn't it ?
13:02 < darosior> Ah noo
13:03 < darosior> Ok
13:03 < darosior> Thanks will bare that in mind and retry
13:04 < vasild> every bit it marked as initialized or not and the uninitialized bits from x will be assigned to y, so it will start to hold some uninitialized bits too
13:05 < darosior> Ok, thanks
13:05 < vasild> but the problem is that we don't get the complain during that assignment because yet nothing depends on it
13:05 < vasild> plugin->rpc_used += plugin->rpc_len_read;
13:05 < vasild> just before the complain
13:06 < vasild> maybe also do if (plugin->rpc_len_read) { printf("foowhatever"); } and see if it complains about it too
13:06 < vasild> if it does then the uninitialized bits come from plugin->rpc_len_read
13:07 < darosior> Trying now, seems to be a good track
13:07 < vasild> actually there are some valgrind macros to assert that the memory is intialized instead of doing some stupid "if (variable) { dummy action; }"
13:07 < darosior> You just fixed it.
13:07 < darosior> With a Github review.
13:08 < darosior> ^^
13:08 < vasild> \o/
13:08 < vasild> plugin->rpc_len_read is the problem?
13:08 < darosior> Yep
13:10 < darosior> Thanks !
13:17 < vasild> yw
13:17 < vasild> VALGRIND_CHECK_MEM_IS_DEFINED() is the macro
13:17 < vasild> https://valgrind.org/docs/manual/mc-manual.html#mc-manual.clientreqs
13:18  * vasild zZzZ
13:49 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning
13:49 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 265 seconds]
14:36 <@cdecker> A bit late to the party, but we have `memcheck` which triggers valgrind's uninitialized checks if you'd want to make sure some memory is initialized correctly
14:52 < darosior> Ok, thanks
15:38 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds]
15:54 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
16:17 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
16:17 < fiatjaf> what does "features": 028200 mean?
16:34 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning
16:34 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
16:36 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
16:54 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
17:03 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
17:11 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
17:28 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
17:30 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
17:43 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
18:00 < fiatjaf> mpp + payment_secret?
18:46 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...]
18:48 -!- dr-orlovsky [~dr-orlovs@77-58-192-184.dclient.hispeed.ch] has joined #c-lightning
19:25 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning []
19:25 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning
19:29 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
20:14 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
21:34 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
22:04 -!- r32a [31b1eff9@c49-177-239-249.eburwd21.vic.optusnet.com.au] has joined #c-lightning
22:06 < r32a> Question with regards to the API. currently lightning-listinvoices returns everything or just 1. Is there anyway to expand this capability to get more query options?
22:17 < r32a> nevermind I found a nice plugin that should do what i want
22:20 -!- treehug88 [~textual@pool-173-56-90-115.nycmny.fios.verizon.net] has quit [Ping timeout: 265 seconds]
22:37 -!- r32a [31b1eff9@c49-177-239-249.eburwd21.vic.optusnet.com.au] has quit [Remote host closed the connection]
22:58 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
23:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
23:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
--- Log closed Tue Jan 28 00:00:22 2020