--- Log opened Thu Mar 12 00:00:23 2020 00:44 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 00:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning 01:11 < darosior> niftynei: re RPC methods version https://github.com/ElementsProject/lightning/pull/3400 01:15 < darosior> We talked about it with cdecker for the Bitcoin backend interface 01:15 < darosior> Turns around it was a bad idea 01:23 < m-schmoock> Hey, someone can explain to me why contrib/pyln-testing/pyln/testing/utils.py line 831 channel can be fixed to '1x1x1' regardless of actual channels scids? I looked into listchannels, actual channel IDs (when testing) are somethign like 103x1x1 ... 01:23 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning [] 01:24 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning 01:24 < m-schmoock> background: the test function ln.pay() transfers money to a directly connected peer without routing 01:25 < m-schmoock> I just dont understand how that can work, and why tests not fail 01:26 < m-schmoock> (but it works) 01:26 <@cdecker> It's a single hop payment: the node_id is used to identify the next (first) hop from the sender, the scid is not actually being used since the onion contains no instructions for the first hop to continue (which would be encoded as a valid scid) 01:27 < m-schmoock> :D thanks, those nasty details 02:00 -!- jonatack [~jon@37.164.69.25] has quit [Read error: Connection reset by peer] 02:05 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning 02:18 -!- Maitor [~goban@gateway/tor-sasl/maitor] has quit [Ping timeout: 240 seconds] 02:21 -!- Maitor [~goban@gateway/tor-sasl/maitor] has joined #c-lightning 02:34 < m-schmoock> cdecker: any chance we can also get this into the 0.8.2 release? https://github.com/ElementsProject/lightning/pull/3572 02:35 < m-schmoock> or are features freezed already? 02:36 <@cdecker> Marked it for 0.8.2, but finaly call is by our Release Captain niftynei 02:36 < m-schmoock> also, we might think about going from 1.5 to 2.0 fee spike margin already 02:36 <@cdecker> Nah, feature freeze is just a couple of days around the release itself 02:36 < m-schmoock> since we would not be std complaint and it looks like this is what the protocl spec will go for 02:36 <@cdecker> Currently the first RC is scheduled for April 10th :-) 02:36 < m-schmoock> ah ok 02:37 < m-schmoock> shall I make a PR for the 1.5 -> 2.0 tx fee spike margin? 02:37 < m-schmoock> ah righ , just saw its marked for 0.8.2 :D 02:37 < m-schmoock> *nice* 02:50 < darosior> Arf one of the jobs for https://github.com/ElementsProject/lightning/pull/3570 is still timeouting after many restarts :/ 02:50 < darosior> Too many functional tests? 03:20 < darosior> Hmm seems to be due to some failures I can't reproduce either with or without valgrind 03:50 < m-schmoock> lol, decent price action -QQQQo_O 03:51 -!- lxer [~lx@ip5f5bf497.dynamic.kabel-deutschland.de] has joined #c-lightning 04:13 -!- belcher [~belcher@unaffiliated/belcher] has joined #c-lightning 04:36 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #c-lightning 04:50 < m-schmoock> I have a compile issue with a recent master commit #ac5cba224 (tried by bisect). My build fails with: 04:50 < m-schmoock> ccan/ccan/autodata/autodata.h:83:36: error: redefinition of ‘autodata_hooks_1016’ 04:50 < m-schmoock> 83 | #define AUTODATA_VAR__(name, line) autodata_##name##_##line 04:50 < m-schmoock> | ^~~~~~~~~ 04:50 < m-schmoock> ideas? 04:51 <@cdecker> Is there a missing include guard somewhere? Or are you including a .c file directly? 04:54 < m-schmoock> let me re-check 04:56 < m-schmoock> hm, without my branch rebased on this commit, a clean master build, the problem disapears :/ maybe its me 05:13 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:18 < m-schmoock> cdecker: found it, unclose comment which raised error in other file 05:18 < m-schmoock> C is so... stockholm :D 05:18 < m-schmoock> on top of that the issue only raised at a certain recent commit 05:19 < m-schmoock> hmm... or not 05:19 < m-schmoock> nope 05:19 <@cdecker> Agreed on the swedisch part :-) 05:31 < m-schmoock> hm... not sure im happy with the cause I found to this issue 05:31 < m-schmoock> I had a u32 (a feerate) 05:32 < m-schmoock> I used to do ` feerate * 2 ` 05:32 < m-schmoock> which cause the error when compiling, but using feerate + feerate works 05:32 < m-schmoock> not good, theres something else broken 05:35 < m-schmoock> somehow this is all not reproducible 05:35 < m-schmoock> damn 05:36 < m-schmoock> when I remove a comment, it works, then not again 05:37 < m-schmoock> I think its with the comment 06:00 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 06:10 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning 06:17 -!- Kostenko [~Kostenko@2001:8a0:7299:1300:9318:2d6f:2006:e26b] has quit [Ping timeout: 256 seconds] 06:32 -!- Kostenko [~Kostenko@2001:8a0:729a:5c00:c3b9:b700:36f7:752c] has joined #c-lightning 07:22 -!- jasan [~jasan@tunnel509499-pt.tunnel.tserv27.prg1.ipv6.he.net] has joined #c-lightning 07:26 -!- jasan [~jasan@tunnel509499-pt.tunnel.tserv27.prg1.ipv6.he.net] has quit [Client Quit] 07:27 -!- jasan [~jasan@tunnel509499-pt.tunnel.tserv27.prg1.ipv6.he.net] has joined #c-lightning 07:41 < m-schmoock> cdecker: added this ontop of receivable https://github.com/ElementsProject/lightning/pull/3589 . will set RFC #470 feespike factor from 1.5 to 2 08:47 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #c-lightning 08:47 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 08:49 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Client Quit] 09:15 -!- belcher [~belcher@unaffiliated/belcher] has joined #c-lightning 09:33 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning [] 09:33 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning 09:39 -!- gojiHmPFPN [~textual@185.213.155.164] has joined #c-lightning 10:55 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 11:03 -!- gojiHmPFPN [~textual@185.213.155.164] has quit [Quit: Textual IRC Client: www.textualapp.com] 11:23 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #c-lightning 12:40 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning 12:41 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 12:43 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 12:43 -!- vasild_ is now known as vasild 13:15 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has joined #c-lightning 13:25 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has joined #c-lightning 14:09 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning 14:15 -!- jasan [~jasan@tunnel509499-pt.tunnel.tserv27.prg1.ipv6.he.net] has quit [Quit: Bye] 14:43 -!- dr-orlovsky [~dr-orlovs@xdsl-188-155-161-135.adslplus.ch] has quit [Ping timeout: 255 seconds] 14:54 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 268 seconds] 14:55 -!- achow101 [~achow101@unaffiliated/achow101] has joined #c-lightning 15:01 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #c-lightning 15:32 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 16:01 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 16:02 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #c-lightning 16:19 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 16:30 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning 16:33 -!- lxer [~lx@ip5f5bf497.dynamic.kabel-deutschland.de] has quit [Ping timeout: 256 seconds] 16:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 16:49 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 265 seconds] 16:57 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.] 17:06 -!- achow101 [~achow101@unaffiliated/achow101] has joined #c-lightning 17:08 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 17:09 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Read error: Connection reset by peer] 17:09 -!- rusty1 [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 17:47 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has left #c-lightning [] 17:47 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zkjjaoqsjfattawp] has joined #c-lightning 17:47 < rusty1> niftynei: no idea why configure is re-running; but it looks like ccan/config.h depends on config.vars, which is wrong. 17:48 -!- dr-orlovsky [~dr-orlovs@194.230.155.227] has joined #c-lightning 17:51 < rusty1> niftynei: re: compatibility. For the moment we can get away with versions, but I think we should add a version string to getmanifest. For normal uses there's getinfo.version, but perhaps we should make life a bit easier by allowing getinfo to take an option and just return that, ie.. 'lightning-cli getinfo version'? 18:13 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning 18:21 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 18:28 -!- dr-orlovsky [~dr-orlovs@194.230.155.227] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:53 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 18:57 <@niftynei> re: config re-running, deleting the libwally compilation block fixed it. it's on my 'to investigate' list 18:58 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Ping timeout: 240 seconds] 19:11 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning 19:43 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds] 19:57 -!- rusty1 [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.] 22:03 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Quit: Bye] 22:12 -!- achow101 [~achow101@unaffiliated/achow101] has joined #c-lightning 22:55 -!- achow101_ [~achow101@unaffiliated/achow101] has joined #c-lightning 22:56 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 268 seconds] 23:30 -!- achow101_ [~achow101@unaffiliated/achow101] has quit [Quit: Bye] 23:31 -!- achow101 [~achow101@unaffiliated/achow101] has joined #c-lightning --- Log closed Fri Mar 13 00:00:24 2020