--- Log opened Tue Jun 09 00:00:45 2020 00:16 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning 00:16 -!- zmnscpxj__ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Remote host closed the connection] 00:36 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning 01:05 < zmnscpxj_> niftynei: are you online? 01:31 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.7.1] 01:31 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning 01:43 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning 01:45 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 01:51 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has joined #c-lightning 01:52 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has quit [Client Quit] 02:17 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-txhnryyccoeyadae] has left #c-lightning [] 02:17 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-txhnryyccoeyadae] has joined #c-lightning 02:30 -!- Ron-Na [~quassel@60-251-129-61.HINET-IP.hinet.net] has quit [Quit: No Ping reply in 180 seconds.] 02:30 -!- cryptosoap [~cryptosoa@gateway/tor-sasl/cryptosoap] has quit [Quit: %bye%] 02:30 -!- cryptoso- [~cryptosoa@gateway/tor-sasl/cryptosoap] has joined #c-lightning 02:31 < zmnscpxj_> Need help with anyone who actually understands fundchannel_complete and fundchannel_cancel. 02:31 < zmnscpxj_> It looks to me, that because of the function funding_success in lightningd/opening_channel.c, if I run fundchannel_cancel while a fundchannel_complete is running, fundchannel_cancel can fail 02:32 < zmnscpxj_> and fundchannel_complete will finish successfully 02:32 < zmnscpxj_> but my understanding of the fundchannel_cancel semantics was that it should definitely cancel the funding attempt, no questions asked, no special cases 02:32 < zmnscpxj_> meaning it should actually error the channel in that case 02:33 < zmnscpxj_> instead of saying "Try fundchannel_cancel again." 02:36 -!- RonNa [~quassel@60-251-129-61.HINET-IP.hinet.net] has joined #c-lightning 03:05 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Remote host closed the connection] 03:07 -!- jonatack [~jon@184.75.214.163] has joined #c-lightning 03:14 -!- jonatack [~jon@184.75.214.163] has quit [Remote host closed the connection] 03:16 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning 03:22 < darosior> zmnscpxj_: It's actually racy, see test_funding_cancel_race() in tests/test_connection.py which descrbes well the behavior 03:22 * zmnscpxj_ groans 03:24 < zmnscpxj_> so workaround is to wait for all `fundchannel_complete` to definitely succeed or definitely fail first before doing cleanup? 03:24 < zmnscpxj_> that works...? 04:32 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 04:40 < darosior> I think so, anyway (assuming you're talking about fundmulti) you need to wait for all to succeed either or you'd not have the commitment tx signed for an output ? 04:41 < zmnscpxj_> yes but if one of them fails you could just fail at that point 04:41 < zmnscpxj_> except doing fundchannel_cancel while other sparks are doing fundchannel_complete runs into the race condition 04:41 < zmnscpxj_> oh well 05:23 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 05:24 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning 05:40 -!- pretyflaco [~k3m@185.213.155.170] has joined #c-lightning 05:45 -!- pretyflaco [~k3m@185.213.155.170] has quit [Read error: Connection reset by peer] 05:59 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Ping timeout: 240 seconds] 06:00 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has joined #c-lightning 06:06 -!- pretyflaco [~k3m@185.213.155.168] has joined #c-lightning 06:18 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:52 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has joined #c-lightning 07:12 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:22 -!- pretyflaco [~k3m@185.213.155.168] has quit [Ping timeout: 240 seconds] 07:46 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has joined #c-lightning 07:48 -!- pretyflaco [~k3m@185.213.155.170] has joined #c-lightning 07:50 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has quit [Client Quit] 07:57 -!- gojiHmPFPN [~textual@c-73-47-220-190.hsd1.ma.comcast.net] has joined #c-lightning 08:20 < darosior> Ah ok I understand (didn't checked the message) 09:13 -!- pretyflaco [~k3m@185.213.155.170] has quit [Ping timeout: 246 seconds] 09:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning 09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:23 -!- vasild_ is now known as vasild 09:27 -!- pretyflaco [~k3m@185.104.184.187] has joined #c-lightning 09:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 09:39 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #c-lightning 10:05 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has quit [Ping timeout: 264 seconds] 10:25 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning 10:35 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-txhnryyccoeyadae] has left #c-lightning [] 10:35 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-txhnryyccoeyadae] has joined #c-lightning 10:59 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Quit: leaving] 11:21 -!- fiatjaf1 [~fiatjaf@2804:7f2:2a84:fb44:ea40:f2ff:fe85:d2dc] has joined #c-lightning 11:24 -!- fiatjaf [~fiatjaf@177.42.90.101] has quit [Ping timeout: 265 seconds] 12:07 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 12:09 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #c-lightning 12:37 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has joined #c-lightning 12:58 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has left #c-lightning [] 13:09 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 13:09 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning 13:40 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning 13:40 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 16:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds] 16:14 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning 16:38 -!- berndj [~berndj@azna.co.za] has quit [Quit: ZNC - http://znc.in] 16:38 -!- berndj [~berndj@azna.co.za] has joined #c-lightning 17:22 -!- pretyflaco [~k3m@185.104.184.187] has quit [Ping timeout: 246 seconds] 17:28 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning 18:47 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 18:47 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-txhnryyccoeyadae] has left #c-lightning [] 18:47 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-txhnryyccoeyadae] has joined #c-lightning 19:04 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning 19:21 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 19:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds] 19:21 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #c-lightning 19:21 < zmnscpxj_> do we have a command to tell a peer "no, this channel_id will never confirm" that isn't fundchannel_cancel? 19:22 < zmnscpxj_> fundchannel_cancel fails if we locally think we are not funding 19:22 < zmnscpxj_> but failing fundchannel_complete automatically makes us think we are not funding anymore 19:22 < zmnscpxj_> so future fundchannel_cancels do not send this "no, this channel_id will never confirm" error message 19:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning 19:40 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has quit [Read error: Connection reset by peer] 19:45 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 19:46 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 265 seconds] 19:55 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning 20:26 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning 21:02 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 21:04 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning 21:05 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Client Quit] 21:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning 21:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:24 -!- vasild_ is now known as vasild --- Log closed Wed Jun 10 00:00:46 2020