--- Log opened Fri Jul 24 00:00:28 2020
00:18 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #c-lightning
00:24 -!- jonatack [~jon@194.187.251.155] has joined #c-lightning
02:15 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 256 seconds]
02:16 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #c-lightning
02:16 -!- k3tan [~pi@unaffiliated/k3tan] has quit [Ping timeout: 265 seconds]
02:16 -!- k3tan [~pi@unaffiliated/k3tan] has joined #c-lightning
02:34 -!- MasterdonX [~masterdon@198.204.231.150] has joined #c-lightning
02:34 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
02:35 -!- masterdonx2 [~masterdon@213.183.57.61] has quit [Ping timeout: 260 seconds]
02:38 -!- zmnscpxj [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Remote host closed the connection]
02:41 -!- jonatack [~jon@194.187.251.155] has quit [Ping timeout: 244 seconds]
02:48 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning
02:51 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-xadswhvwruqyrqgr] has left #c-lightning []
02:51 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-xadswhvwruqyrqgr] has joined #c-lightning
03:08 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Ping timeout: 240 seconds]
03:31 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning
03:53 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer]
03:53 -!- reallll [~belcher@unaffiliated/belcher] has joined #c-lightning
04:11 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:25 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack]
04:29 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning
04:50 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
04:50 -!- reallll is now known as belcher_
05:09 -!- vincenzopalazzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has quit [Quit: Leaving]
06:31 -!- grubles [~user@gateway/tor-sasl/grubles] has quit [Ping timeout: 240 seconds]
06:38 -!- grubles [~user@gateway/tor-sasl/grubles] has joined #c-lightning
06:45 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning
06:46 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 258 seconds]
06:54 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #c-lightning
07:09 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Read error: Connection reset by peer]
07:28 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
07:31 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning
07:36 < darosior> zmnscpxj_: reading https://github.com/ElementsProject/lightning/issues/3858 this is literally chronologically all the realisations I went through while working on https://github.com/ElementsProject/lightning/issues/3354 :-). I'm all in for a v2 as long as it doesn't break compat with v1
07:37 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has quit [Quit: Leaving]
07:38 < darosior> iirc the final thought that made me go for the `bitcoin-cli`-style interface was the cache and that `bcli` would need a database as well (not finished reading though, will post a real answer there)
07:39 < darosior> What I would love also (v3 maybe?) is to make use of notification for a more optimized polling
07:40 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in]
08:16 < zmnscpxj_> "break compat" in what manner?
08:19 < zmnscpxj_> e.g. #3870 changes interface of `sendrawtransaction` to expose `allowhighfees` argument, since it implements scorched-earth fees, potentially raising fees above "reasonable fee" limits
08:32 < darosior> Adding new calls that we'd rely on, but I didn't finish reading everything when I posted
08:33 < darosior> Replied, this is more random thoughts though
08:33 < zmnscpxj_> the hard part is the short-channel-id, not so much the synch
08:34 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
08:35 < zmnscpxj_> maybe `getchaininfo` can have a `plugin_protocol_version` which  gates access to newer calls
08:35 < zmnscpxj_> if `getchaininfo` does not return `plugin_protocol_version` it is implied as 0.
08:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
08:36 < zmnscpxj_> And newer versions need to return `1` `2` etc
08:43 < darosior> I had a PR which implemented this: iirc it violated the JSONRPC to have a version field in each request
08:44 < zmnscpxj_> if we assume bitcoin-interface plugins are not restartable, then `getchaininfo` would be a single call..?
08:44 < zmnscpxj_> ah
08:44 < zmnscpxj_> wait
08:44 < darosior> here it is https://github.com/ElementsProject/lightning/pull/3400
08:45 < zmnscpxj_> one of our goals as well is that different plugins can provide different parts of the backend interface
08:45 < zmnscpxj_> :(
08:47 < darosior> Yep that was the rationale for the per-call versioning
08:47 < zmnscpxj_> uuuuugh
08:48 < zmnscpxj_> okay, so a basic thought is that we can try some kind of `getutxobyscid`, and if not exist, fall back on `getrawblockbyheight`.
08:49 < zmnscpxj_> But if we want a "electrum only" mode, we want to avoid calling into `getrawblockheight` at all.
08:50 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection]
08:50 < zmnscpxj_> `getutxobyscid` is implementable by `blockchain.transaction.id_from_pos`
08:50 < zmnscpxj_> in Electrum
08:50 < zmnscpxj_> but not in BIP158 or `bitcoind`
09:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
09:02 -!- vincenzopalazzo [~vincent@host-87-20-89-251.retail.telecomitalia.it] has joined #c-lightning
09:42 -!- vincenzopalazzo [~vincent@host-87-20-89-251.retail.telecomitalia.it] has quit [Remote host closed the connection]
09:46 < darosior> I think in any case we are going to need a cache. In this case, we can completely dissociate the nature of the call made by lightningd from the nature of the calls made by bcli
09:46 < zmnscpxj_> if we force caches at the plugin, means plugin has to know how to parse the blocks
09:49 < darosior> Yep, but I thought we passed this step ? I understood your proposition as the plugin would abstract any backend for lightningd
09:50 < zmnscpxj_> yeah, but was thinking as well how we could avoid that if we can :P
09:50 < zmnscpxj_> sigh
09:50 < zmnscpxj_> or just go `getutxobyscid` >.<
09:57 < darosior> "or just go `getutxobyscid` >.<" => Actually that's I think the best interface for lightningd with bcli, but now the plugin needs to fetch blocks however it wants, cache the data and serve it instantly to lightningd: that's quite good I think but kinda of a breaking change (and a lot more complexity on the plugin)
09:58 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Ping timeout: 240 seconds]
10:08 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
10:10 < zmnscpxj_> indeed
10:10 < zmnscpxj_> sigh
10:46 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds]
11:00 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-xadswhvwruqyrqgr] has left #c-lightning []
11:01 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-xadswhvwruqyrqgr] has joined #c-lightning
11:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
11:25 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
11:26 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning
11:34 -!- grubles [~user@gateway/tor-sasl/grubles] has quit [Ping timeout: 240 seconds]
11:34 -!- grubles [~user@gateway/tor-sasl/grubles] has joined #c-lightning
11:46 < darosior> zmnscpxj_: Ok I think I have something: we can have a specific `getmanifest`, since this one is specific to each plugin (ie lightningd-wise each call). We add a version field in the getmanifest, if the plugin registering the block source is version 1 bingo, otherwise we stick to the raw block parsing. This can be cleaned up in 3 versions. (Modern
11:46 < darosior> Soft Fork Activation-but-for-our-Bitcoin-backend :p)
11:46 < darosior> See https://github.com/ElementsProject/lightning/issues/3858#issuecomment-663678853
12:10 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
12:11 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning
13:22 -!- cdecker changed the topic of #c-lightning to: Chat about the C-lightning implementation: https://github.com/ElementsProject/lightning https://lists.ozlabs.org/listinfo/c-lightning  Current Version: https://github.com/ElementsProject/lightning/releases/tag/v0.9.0rc3 Logs at http://gnusha.org/c-lightning/
13:58 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
14:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection]
14:41 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
14:56 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
15:16 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Remote host closed the connection]
15:16 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
15:17 -!- grubles [~user@gateway/tor-sasl/grubles] has quit [Quit: leaving]
15:44 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning
15:48 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 246 seconds]
17:29 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning
18:19 -!- zmnscpxj__ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
18:20 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Ping timeout: 240 seconds]
18:30 -!- liberliver1 [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has joined #c-lightning
18:33 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has quit [Remote host closed the connection]
18:33 -!- liberliver1 is now known as liberliver
18:36 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
18:37 -!- rh0nj [~rh0nj@88.99.167.175] has joined #c-lightning
19:08 -!- Netsplit *.net <-> *.split quits: queip, bitauger, justanotheruser, liberliver, k3tan
19:08 -!- Netsplit *.net <-> *.split quits: qubenix, roasbeef, zmnscpxj__, adam3us, ghost43, cryptosoap, @niftynei, jonasschnelli, @cdecker, berndj,  (+43 more, use /NETSPLIT to show all of them)
19:14 -!- Netsplit over, joins: RubenSomsen, fjahr, felixweis, harding, jonatack, kanzure, midnight, drolmer, nothingmuch, _0x0ff (+46 more)
19:15 -!- Netsplit *.net <-> *.split quits: nothingmuch, m-schmoock, RubenSomsen, nibbier, fjahr, roasbeef, @niftynei, harding, Nebraskka, darosior,  (+20 more, use /NETSPLIT to show all of them)
19:15 -!- Netsplit *.net <-> *.split quits: drolmer, warren, Ed0
19:16 -!- Netsplit *.net <-> *.split quits: qubenix, zmnscpxj__, ghost43, cryptosoap, jonasschnelli, @cdecker, vasild, blockstream_bot, fiatjaf, Letze,  (+13 more, use /NETSPLIT to show all of them)
19:19 -!- Netsplit over, joins: kanzure, ksedgwic, Victorsueca, instagibbs, zmnscpxj__, jonatack, drolmer, fiatjaf, harding, wraithm (+35 more)
19:20 -!- Netsplit over, joins: gwillen, willcl_ark, _0x0ff, nothingmuch
19:21 -!- Netsplit over, joins: achow101, @cdecker, jonasschnelli, tigermousr
19:21 -!- mol [~mol@unaffiliated/molly] has joined #c-lightning
19:22 -!- berndj [~berndj@ns1.linksynergy.co.za] has joined #c-lightning
19:22 -!- RubenSomsen [sid301948@gateway/web/irccloud.com/x-gasdhhiyorhasrtn] has joined #c-lightning
19:23 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-xadswhvwruqyrqgr] has left #c-lightning []
19:23 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-xadswhvwruqyrqgr] has joined #c-lightning
20:34 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
20:34 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
20:44 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
20:46 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
21:15 -!- mdunnio [~mdunnio@208.59.170.5] has joined #c-lightning
21:22 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 244 seconds]
21:54 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
22:25 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
22:33 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
23:02 -!- zmnscpxj__ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Remote host closed the connection]
23:02 -!- zmnscpxj__ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
23:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds]
23:49 -!- vincenzopalazzo [~vincent@host-87-20-89-251.retail.telecomitalia.it] has joined #c-lightning
--- Log closed Sat Jul 25 00:00:29 2020