--- Log opened Tue Aug 25 00:00:59 2020 00:08 -!- jonatack [~jon@37.166.120.102] has quit [Ping timeout: 240 seconds] 00:23 -!- jonatack [~jon@37.166.201.6] has joined #c-lightning 00:23 -!- jonatack [~jon@37.166.201.6] has quit [Client Quit] 00:23 -!- jonatack [~jon@37.166.120.102] has joined #c-lightning 00:28 -!- jonatack [~jon@37.166.120.102] has quit [Ping timeout: 256 seconds] 00:44 -!- liberliver [~Thunderbi@2a01:c22:a428:cc00:a2af:bdff:fe37:2d32] has joined #c-lightning 01:09 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 01:10 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #c-lightning 01:22 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 01:31 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #c-lightning 01:40 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning 01:40 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 02:02 -!- kexkey [~kexkey@89.36.78.166] has quit [Read error: Connection reset by peer] 02:05 -!- vincenzopalazzo [~vincent@host-82-55-18-31.retail.telecomitalia.it] has joined #c-lightning 02:07 < vincenzopalazzo> cdecker: Hello, I'm look inside your revision on PR 3899 and I don't understand what you mean with the following revision https://github.com/ElementsProject/lightning/pull/3899#discussion_r475634240 02:07 < vincenzopalazzo> Can you clarify this to me? 02:09 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 02:16 -!- vincenzopalazzo [~vincent@host-82-55-18-31.retail.telecomitalia.it] has quit [Ping timeout: 260 seconds] 02:23 -!- vincenzopalazzo [~vincent@host-79-26-113-47.retail.telecomitalia.it] has joined #c-lightning 02:32 <@cdecker> I think if the caller doesn't specify a status we should match either `complete` or `failed`, and not just interpret that as `complete` 02:32 <@cdecker> Defaulting to `complete` is a bit strange to me, but might actually be safer. I'm curious what others think about this 02:33 < zmnscpxj__> should probably just require this parameter, like delinvoice does 02:33 < vincenzopalazzo> Yep! I agree and I understand 02:35 < vincenzopalazzo> The delete payment command make a irreversible change inside the DB (without backup), and is very important that the user doesn't try to run the command without the correct parameter :-) I missed this thinks during the developing 02:35 < vincenzopalazzo> Sorry about that! 02:43 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zzgbwiizjmpgirfq] has left #c-lightning [] 02:43 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zzgbwiizjmpgirfq] has joined #c-lightning 02:45 <@cdecker> No problem at all, that's what reviews are there for :-) 03:00 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 03:05 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #c-lightning 03:42 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.] 03:50 -!- felixweis [sid154231@gateway/web/irccloud.com/x-tjakxxqoraoowpeh] has quit [Ping timeout: 244 seconds] 03:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning 03:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:58 -!- vasild_ is now known as vasild 04:00 -!- felixweis [sid154231@gateway/web/irccloud.com/x-jlmbxhhtbxlzhkla] has joined #c-lightning 04:01 -!- zmnscpxj__ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Remote host closed the connection] 04:13 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 04:13 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #c-lightning 05:05 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 05:48 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 05:49 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 05:54 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning 06:16 -!- kexkey [~kexkey@89.36.78.166] has joined #c-lightning 08:00 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning 09:37 -!- zmnscpxj__ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning 10:30 -!- reallll [~belcher@unaffiliated/belcher] has joined #c-lightning 10:33 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 258 seconds] 10:53 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zzgbwiizjmpgirfq] has left #c-lightning [] 10:54 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zzgbwiizjmpgirfq] has joined #c-lightning 10:59 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 11:10 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 11:12 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 11:30 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 11:32 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 12:01 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 12:01 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 12:12 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 12:15 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 12:32 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #c-lightning 12:39 -!- shesek [~shesek@unaffiliated/shesek] has joined #c-lightning 12:54 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 12:59 -!- reallll is now known as belcher 13:04 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 13:07 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 13:31 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.] 13:31 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 13:50 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 14:16 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 14:17 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 15:08 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 15:09 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 15:10 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning 15:14 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 15:15 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.] 15:15 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 15:21 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 15:21 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning 15:30 -!- liberliver1 [~Thunderbi@2a01:c22:ac03:6800:a2af:bdff:fe37:2d32] has joined #c-lightning 15:32 -!- liberliver [~Thunderbi@2a01:c22:a428:cc00:a2af:bdff:fe37:2d32] has quit [Ping timeout: 272 seconds] 15:32 -!- liberliver1 is now known as liberliver 15:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning 15:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:58 -!- vasild_ is now known as vasild 16:08 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 16:08 -!- sr_gi [~sr_gi@static-144-88-225-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer] 16:08 -!- sr_gi [~sr_gi@static-144-88-225-77.ipcom.comunitel.net] has joined #c-lightning 16:08 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 16:30 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 16:32 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 16:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds] 16:59 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 17:02 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 17:05 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 17:10 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 17:11 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 17:49 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 256 seconds] 17:50 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #c-lightning 18:00 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 18:06 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 18:07 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 18:22 -!- zmnscpxj__ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Quit: Leaving] 18:23 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 18:24 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 18:38 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning 18:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #c-lightning 18:59 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Read error: Connection reset by peer] 19:02 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 19:03 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 19:10 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 19:11 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 19:14 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zzgbwiizjmpgirfq] has left #c-lightning [] 19:14 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zzgbwiizjmpgirfq] has joined #c-lightning 20:01 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 20:02 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 20:16 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 20:17 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 21:20 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 21:23 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 21:27 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 21:28 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning 21:39 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 22:09 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 22:10 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 22:18 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 22:18 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 22:35 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.] 23:07 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 23:08 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning 23:31 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection] 23:34 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning 23:34 -!- melande [~melande@gateway/tor-sasl/melande] has joined #c-lightning --- Log closed Wed Aug 26 00:00:59 2020