--- Log opened Tue Nov 10 00:00:12 2020
00:18 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zzgbwiizjmpgirfq] has left #c-lightning []
00:18 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zzgbwiizjmpgirfq] has joined #c-lightning
00:19 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has joined #c-lightning
00:49 -!- Spall [8b3b93e8@139.59.147.232] has quit [Remote host closed the connection]
00:49 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
00:50 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning
01:01 -!- early` [~early@static.38.6.217.95.clients.your-server.de] has quit [Quit: Leaving]
01:02 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
01:08 -!- early [~early@static.38.6.217.95.clients.your-server.de] has joined #c-lightning
01:55 -!- reallll is now known as belcher
02:04 -!- kexkey [~kexkey@static-198-54-132-89.cust.tzulo.com] has quit [Ping timeout: 246 seconds]
02:08 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
02:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
02:12 -!- vasild_ is now known as vasild
02:29 < m-schmoock> fiatjaf: gave you a review on #4187 . good feature :D
02:37 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #c-lightning
02:41 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #c-lightning
03:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
03:04 < fiatjaf> m-schmoock: I don't know how to write a test for it
03:05 < fiatjaf> perhaps we must write functions for encoding and decoding error packets to pyln.proto
03:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #c-lightning
03:06 < m-schmoock> well at least we can have a test plugin that response in such way and we catch for the specific error and by this expect the code not to raise any other errors
03:07 -!- nibbier [~quassel@mx01.geekbox.info] has joined #c-lightning
03:27 < m-schmoock> fiatjaf: you want me to look into testcasing this?
03:30 < m-schmoock> also, you can resolve review tasks and remakrs, seems (for some reason) I cant on my own reviews. maybe only the reviwed person can :)
03:32 < m-schmoock> niftynei: do we need/want to fix the crash and the hang in #4175 and #4176 for the next release?
03:42 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
04:03 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #c-lightning
04:12 < fiatjaf> m-schmoock: I'm trying to write some basic test
04:12 < fiatjaf> without doing all the decoding stuff, just seeing if lightningd gets the response
04:13 < fiatjaf> but I don't know how to run the tests
04:13 < fiatjaf> I've installed a python virtualenv, installed all the requirements.txt and the pyln.* modules
04:14 < fiatjaf> but my plugin is failing to run
04:14 < fiatjaf> oh, wait, the other plugins seem to be running fine
04:16 < fiatjaf> nevermind, it was not marked as executable
04:21 < fiatjaf> well
04:22 < fiatjaf> lightningd crashes if I return an invalid onion
04:22 < fiatjaf> I don't know how to test this
04:22 < fiatjaf> so I give up
04:23 < fiatjaf> I also have memory leaks
04:27 < fiatjaf> so I give up
04:42 -!- jasan [~j@n.bublina.eu.org] has joined #c-lightning
06:11 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
06:11 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #c-lightning
07:04 -!- sr_gi [~sr_gi@static-120-201-229-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer]
07:05 -!- sr_gi [~sr_gi@static-120-201-229-77.ipcom.comunitel.net] has joined #c-lightning
07:06 -!- kexkey [~kexkey@static-198-54-132-169.cust.tzulo.com] has joined #c-lightning
07:08 -!- jasan [~j@n.bublina.eu.org] has quit [Quit: jasan]
07:30 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
07:31 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
08:20 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
08:26 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
08:42 <@niftynei> m-schmoock, do you have a fix for them?
08:43 <@niftynei> yes, we want them to be fixed. no, they don't seem like severe enough bugs to hold up shipping the RC1 today
08:44 <@niftynei> it'd be awesome to get a fix for them in before the final version cut
08:45 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zzgbwiizjmpgirfq] has left #c-lightning []
08:45 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zzgbwiizjmpgirfq] has joined #c-lightning
08:51 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
08:51 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning
09:02 < m-schmoock> niftynei: kk. ill try to have a look
09:02 < m-schmoock> i cant add github labels to issues, hence no 0.9.2 yet
09:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning
09:18 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning
09:18 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
09:56 -!- jasan [~j@n.bublina.eu.org] has joined #c-lightning
10:01 -!- jasan [~j@n.bublina.eu.org] has quit [Client Quit]
10:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning
10:14 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Remote host closed the connection]
10:15 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #c-lightning
10:37 -!- polydin [~george@136.49.254.169] has joined #c-lightning
11:19 <@niftynei> m-schmoock, tagged
11:35 -!- ark3 [59205054@89.32.80.84] has joined #c-lightning
11:43 -!- ark3 [59205054@89.32.80.84] has quit [Remote host closed the connection]
11:47 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has quit [Ping timeout: 240 seconds]
11:55 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
12:12 -!- jonatack [~jon@213.152.162.5] has quit [Quit: jonatack]
12:22 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
12:30 -!- jonatack [~jon@88.124.242.136] has joined #c-lightning
12:35 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 260 seconds]
12:36 -!- jonatack [~jon@185.206.225.59] has joined #c-lightning
14:06 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
14:06 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #c-lightning
14:08 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
14:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
14:12 -!- vasild_ is now known as vasild
16:03 -!- jonatack [~jon@185.206.225.59] has quit [Quit: jonatack]
16:03 -!- jonatack [~jon@88.124.242.136] has joined #c-lightning
16:09 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 272 seconds]
16:10 -!- jonatack [~jon@213.152.162.69] has joined #c-lightning
16:45 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
16:51 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zzgbwiizjmpgirfq] has left #c-lightning []
16:51 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-zzgbwiizjmpgirfq] has joined #c-lightning
17:43 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 264 seconds]
17:53 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
18:12 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
18:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
19:53 -!- reallll [~belcher@unaffiliated/belcher] has joined #c-lightning
19:56 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
20:36 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
20:46 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
20:46 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #c-lightning
20:58 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
21:07 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning
21:49 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
21:54 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
22:27 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #c-lightning
23:18 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
23:25 -!- zmnscpxj__ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
23:34 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has joined #c-lightning
--- Log closed Wed Nov 11 00:00:13 2020