--- Log opened Mon Nov 16 00:00:18 2020
00:08 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has joined #c-lightning
00:16 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds]
01:27 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
01:29 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
01:50 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds]
02:04 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has joined #c-lightning
02:08 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
02:12 <@cdecker> HelloShitty: The reserve value is used to keep your peer honest. The update mechanism used in the current lightning protocol punishes peers if they attempt to commit an old (revoked) state, by claiming their funds (they forfeit them by attempting to cheat). So if the peer doesn't have any funds on his side, there is no way to punish him, or in
02:12 <@cdecker> other words, cheating is free for a peer that doesn't own any balance, so we force them to have 1% of the funds that could be used for punishments
02:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
02:12 -!- vasild_ is now known as vasild
02:13 <@cdecker> This is in direct contrast to other update mechanisms such as eltoo, where we don't punish the cheater, instead we simply override its attempt, and it'll still cost the cheater some on-chain funds.
02:15 <@cdecker> RE: dust limit:Every HTLC added to a commitment transaction may end up on-chain, and therefore require on-chain settlement, involving on-chain transactions. This can come with considerable costs (on-chain transaction fees), and therefore it is sometimes desirable to not actually add an output, instead just keeping track in the accounting until the
02:15 <@cdecker> HTLC is removed again. This is useful if the amount we stand to lose by "just" keeping track in our internal accounting, rather than being able to enforce it, is less than the cost we'd have if we had to settle on-chain
02:35 -!- belcher_ is now known as belcher
03:07 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-mxowwcwnuzktweyq] has joined #c-lightning
03:08 < m-schmoock> cdecker: about the backup plugin: the cli init parameter BACKEND_URL can it be also be stuff like ssh://user@host/  syntax ?
03:08 < m-schmoock> so it just scp/rsyncs somewhere else?
03:09 < zmnscpxj_> not "just", as it does so in a manner that is (theoretically) atomic
03:12 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Remote host closed the connection]
03:12 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #c-lightning
03:15 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Remote host closed the connection]
03:16 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #c-lightning
03:32 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
03:47 -!- sr_gi [~sr_gi@static-120-201-229-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer]
03:50 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #c-lightning
03:50 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
03:50 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #c-lightning
03:54 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
03:54 < m-schmoock> Hey, whats this blockstream_bot and when it pastes some BROKEN log messages, can it include the git revision affected?
03:55 < zmnscpxj_> it is a bridge between some blockstream slack channel and this I believe?
03:55 < zmnscpxj_> so it is just quoting whoever wrote on the blockstream slack channel
03:55 < m-schmoock> Ah ok. Few days it pasted     ```2020-11-13T10:21:31.507Z **BROKEN** database: Accessing a null column 12 in query SELECT  id channel_htlc_id, msatoshi, cltv_expiry, hstate, payment_hash, payment_key, routing_onion, $ailuremsg, malformed_onion, origin_htlc, shared_secret, received_time FROM channel_htlcs WHERE direction= ? AND channel_id= ? AND hstate != ?```
03:56 < m-schmoock> which I found suspicous "$ailuremsg"  some expanding issueS?=
03:56 < m-schmoock> maybe related to the recent change with the onion failure PR from fiatjaf 
03:56 < m-schmoock> has it been addressed?
03:56 < zmnscpxj_> not sure
03:57 < m-schmoock> if so, these things must be fixed for release :D
04:01 -!- jonatack [~jon@109.202.103.170] has quit [Ping timeout: 256 seconds]
04:03 < m-schmoock> wow, the plugin travis is pretty broken :D fails on anything but changes it needs to test ^^
04:03 -!- jonatack [~jon@88.124.242.136] has joined #c-lightning
04:05 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 264 seconds]
04:07 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #c-lightning
04:10 <@cdecker> Yeah, I haven't had much time lately to look into it :-(
04:17 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:27 <@cdecker> Doh, the issue with the mpp_adaptive test in the payment optimization was a `)` that was misplaced by 2 characters...
04:32 -!- queip [~queip@unaffiliated/rezurus] has joined #c-lightning
04:44 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
04:51 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-lsntjcdlexygkbwj] has left #c-lightning []
04:51 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-lsntjcdlexygkbwj] has joined #c-lightning
04:53 < m-schmoock> cdecker: gave you a review on plugin #156 basically okay and works. not sure if you want to remove the sqlite3 check by intention
04:54 <@cdecker> Thanks :+1: The sqlite3 check would be nice to keep around, however before the `init` call we don't know what wallet we are using, so we can't really warn until we have already written some changes.
04:59 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #c-lightning
06:42 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 264 seconds]
06:43 < m-schmoock> cdecker: k will review #4195 this evening ... 
07:08 -!- zmnscpxj__ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
07:11 -!- zmnscpxj_ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Ping timeout: 240 seconds]
07:38 -!- jonatack [~jon@88.124.242.136] has joined #c-lightning
07:43 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 256 seconds]
07:43 -!- jonatack [~jon@213.152.161.149] has joined #c-lightning
08:06 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning
08:08 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
08:50 < m-schmoock> unfortunately the tests were not really successfull. we can discuss this evening ...
09:37 <@cdecker> You mean testing of the changes to the pay plugin?
10:38 <@niftynei> Hello all, looking to get an RC2 cut ASAP.
10:38 <@niftynei> currently we've got two candidate PRs outstanding.
10:38 <@niftynei> - #4192. niftynei is addressing extant valgrind errors
10:39 <@niftynei> - #4195. has ongoing discussion.
10:43 -!- kexkey [~kexkey@static-198-54-132-155.cust.tzulo.com] has joined #c-lightning
10:44 -!- jasan [~j@n.bublina.eu.org] has joined #c-lightning
10:47 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #c-lightning
10:49 <@cdecker> niftynei, I'm pretty sure #4195 can proceed even without quantifying the performance improvements. It reduces channel contention and time to completion in all cases I can think of, we just don't have the proof for it :-)
10:50 <@cdecker> Thta being said, I'd definitely be interested in starting some tests, for example with a fake-MPP recipient plugin
10:50 <@cdecker> That way we could quantify the improvement, and run a large variety of parameter optimizations to get the best performing pay plugin possible
10:55 < jasan> one plugin to rule them all
10:55  * jasan hides
10:58  * cdecker starts building the MOAP (mother of all plugins) mhuhahahaha
11:00 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has quit [Ping timeout: 264 seconds]
11:01 < jasan> :-D
11:03 <@niftynei> ok. sounds like it's just me and valgrind holding up RC2 then :P
11:40 -!- jonatack [~jon@213.152.161.149] has quit [Ping timeout: 240 seconds]
11:43 -!- jonatack [~jon@213.152.161.149] has joined #c-lightning
11:46 <@cdecker> That's an interesting one indeed, looks like the addrhint was freed somewhere?
11:46 <@cdecker> Specifically, it seems like the `connect->addrhint` still has an alias pointer to it
11:55 <@niftynei> right, so in the PR, the `tal_free(connect->addrhint)` is incorrect. (the addrhint is *also* added to connect->addrs)
11:57 <@niftynei> removing tal_free(addrhint) fixes that problem, but it's revealed another issue that i'm not really sure how to fix.
11:58 <@niftynei> i'll add more details on the PR
11:58 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
12:00 < jasan> huh
12:00 < m-schmoock> cdecker: you want me to ack #4195 just for the record? 
12:00 < m-schmoock> other than the loop and the bad luck on phoenix payment today it loogs good
12:00 < m-schmoock> *looks
12:01 < rusty> Hello everyone!  https://meet.jit.si/CLightning-Open-Meeting a usual?
12:01 < m-schmoock> jup
12:05 -!- csknk [~csknk@unaffiliated/csknk] has joined #c-lightning
12:05 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
12:06 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #c-lightning
12:11 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
12:11 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #c-lightning
12:12 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
12:28 -!- kexkey [~kexkey@static-198-54-132-155.cust.tzulo.com] has quit [Quit: Do, don't don't]
12:51 -!- jasan [~j@n.bublina.eu.org] has quit [Quit: Bye!]
12:51 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds]
12:54 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Ping timeout: 272 seconds]
12:59 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-lsntjcdlexygkbwj] has left #c-lightning []
12:59 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-lsntjcdlexygkbwj] has joined #c-lightning
13:30 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #c-lightning
13:51 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving]
14:08 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
14:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
14:12 -!- vasild_ is now known as vasild
14:21 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #c-lightning
14:21 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
14:36 -!- nothingmuch [~nothingmu@unaffiliated/nothingmuch] has quit [Quit: ZNC - https://znc.in]
14:36 -!- nothingmuch [~nothingmu@unaffiliated/nothingmuch] has joined #c-lightning
14:44 -!- shesek [~shesek@unaffiliated/shesek] has joined #c-lightning
15:01 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds]
15:45 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #c-lightning
16:00 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
16:09 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #c-lightning
16:23 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Remote host closed the connection]
16:31 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
16:33 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Client Quit]
16:36 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
16:57 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
16:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
17:40 -!- zmnscpxj__ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Ping timeout: 240 seconds]
18:50 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #c-lightning
18:53 -!- zmnscpxj__ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has joined #c-lightning
19:29 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
19:54 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #c-lightning
19:57 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
20:20 -!- nothingmuch_ [~nothingmu@unaffiliated/nothingmuch] has joined #c-lightning
20:20 -!- nothingmuch [~nothingmu@unaffiliated/nothingmuch] has quit [Quit: ZNC - https://znc.in]
20:41 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Ping timeout: 272 seconds]
20:52 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
20:52 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
21:09 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has joined #c-lightning
21:13 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Ping timeout: 260 seconds]
21:14 -!- zmnscpxj__ [~zmnscpxj@gateway/tor-sasl/zmnscpxj] has quit [Ping timeout: 240 seconds]
21:16 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds]
21:17 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-lsntjcdlexygkbwj] has left #c-lightning []
21:17 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-lsntjcdlexygkbwj] has joined #c-lightning
21:22 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
21:23 -!- fjahr [sid374480@gateway/web/irccloud.com/x-idmozsqtyjsaymjn] has quit [Ping timeout: 272 seconds]
21:24 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #c-lightning
21:25 -!- fjahr [sid374480@gateway/web/irccloud.com/x-zejehgvppaebqwly] has joined #c-lightning
21:32 -!- fjahr [sid374480@gateway/web/irccloud.com/x-zejehgvppaebqwly] has quit [Ping timeout: 272 seconds]
21:37 -!- fiatjaf [~fiatjaf@2804:7f2:2a86:8e94:ea40:f2ff:fe85:d2dc] has quit [Ping timeout: 272 seconds]
21:39 -!- fjahr [sid374480@gateway/web/irccloud.com/x-bftuodvmfdbwrhhw] has joined #c-lightning
21:46 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds]
21:51 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #c-lightning
22:21 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds]
22:28 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
22:38 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #c-lightning
22:43 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #c-lightning
22:44 -!- sword_smith [sword_smit@bitcoinfundamentals.org] has quit [Remote host closed the connection]
22:48 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
22:48 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
23:22 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Ping timeout: 272 seconds]
23:56 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has joined #c-lightning
--- Log closed Tue Nov 17 00:00:03 2020