--- Log opened Sat Nov 28 00:00:29 2020
01:59 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #c-lightning
02:04 -!- kexkey [~kexkey@static-198-54-132-121.cust.tzulo.com] has quit [Ping timeout: 260 seconds]
02:43 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]
02:47 < m-schmoock> darosior: 932425e isn't good. afaik we should be using l2.daemon.wait_for_logs([])   (plural s!)  as it does not enforce the log order
02:52 < m-schmoock> will comment on GH
03:01 < darosior> m-schmoock: yeah, but not in this case as it's possible the line is *already* in logs and the test becomes racy
03:01 < darosior> So wait_for(lambda: is_in_log(regex)) covers that pretty well
03:01 < darosior> That's what i used in the initial tests
03:12 < m-schmoock> darosior: wait_for has a sliding window, it will not wait for already waited for occurences. Im sure you know. So if it can be the case that this was logged before, we can and should wait for it earlier
03:13 < m-schmoock> I try to make as least usage as possible for 'is_in_logs'. And If I do I try to use an offset log pointer to make itn stable
03:15 < darosior> I don't get it ? Here is a concrete example. This https://github.com/lightningd/plugins/blob/0cbee3fc48c244e30577f7be1f281ca55cb31c19/feeadjuster/test_feeadjuster.py#L83-L126 would be flaky if i were not using wait_for(lambda: is_in_log(regex)) for covering the case it's already in the logs instead of wait_for_logs
03:17 < m-schmoock> let me try ...
03:29 < m-schmoock> Yes, using is_in_log works here, since we are checking for dedicated numbers (0.2, 3.x, 6.x, 0.1, ...) that only appear once in a test run.
03:29 < m-schmoock> however this can be done like this :   https://github.com/m-schmoock/plugins/commit/0d6b97f6f886a1c7a79212df6453f2409e89e78c  
03:29 < m-schmoock> which is also not flaky ;)
03:30 < m-schmoock> tests execute same speed. tried both version 100 times. no flakes same execution speed
03:31 < m-schmoock> hin: "wait_for_logs" also looks in the past logs starting from the last call of "wait_for_log(s)" 
03:32 < m-schmoock> the thing with using "is_in_logs" is that it can become flaky more easily when code is changed. thats just my experience though.
03:34 < darosior> Right, your version is cleaner then :)
03:36 < m-schmoock> darosior: wait_for(lambda: is_in_log...   is only good as long there is no overlap in the concrete occurences. if that assumption changes due to someone change the parameter  (i.e. numbers to:  0.2 , 6.x, 0.2, 6.x ... ) this will become a flaky or meaningless test
03:36 < m-schmoock> aside the readability ;)
03:59 < darosior> I know, but in this case we wanted to explicitly test by scid!
05:02 < m-schmoock> my change also includes the scids
05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection]
05:38 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
05:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
05:40 < m-schmoock> cdecker: we can merge https://github.com/lightningd/plugins/pull/160
05:45 < m-schmoock> ... still a trailing semicolon and two unused imports :D  let me clean this python nits for the whole repo in a cleanup ... 
05:46 < m-schmoock> flake8 --ignore=E501,E731,W503 `find . -name *.py` | wc       # gives me 728 lines :D
05:53 <@cdecker> Sorry, saw yor github comment first and merged it already :-(
05:54 <@cdecker> On the positive side: it's merged 🎉🚀
06:42 < m-schmoock> yep. no prob. its better to do a large cleanup for the flake8 nits
06:50 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-lsntjcdlexygkbwj] has left #c-lightning []
06:50 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-lsntjcdlexygkbwj] has joined #c-lightning
08:51 -!- shesek [~shesek@unaffiliated/shesek] has joined #c-lightning
09:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds]
10:13 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds]
10:14 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #c-lightning
10:15 -!- liberliver [~Thunderbi@144.49.211.130.bc.googleusercontent.com] has joined #c-lightning
10:30 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
10:30 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #c-lightning
12:43 -!- helloshitty [~psysc0rpi@bl20-171-222.dsl.telepac.pt] has quit [Remote host closed the connection]
14:09 -!- belcher_ is now known as belcher
14:57 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-lsntjcdlexygkbwj] has left #c-lightning []
14:57 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-lsntjcdlexygkbwj] has joined #c-lightning
15:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds]
16:43 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning
17:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #c-lightning
17:38 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
17:38 -!- vasild_ is now known as vasild
17:51 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds]
18:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning
18:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds]
18:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning
19:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 265 seconds]
19:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #c-lightning
19:31 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
19:32 -!- rh0nj [~rh0nj@88.99.167.175] has joined #c-lightning
19:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds]
19:55 -!- reallll [~belcher@unaffiliated/belcher] has joined #c-lightning
19:57 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
21:13 -!- reallll [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
21:14 -!- belcher [~belcher@unaffiliated/belcher] has joined #c-lightning
22:24 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
22:31 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #c-lightning
22:52 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #c-lightning
23:06 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-lsntjcdlexygkbwj] has left #c-lightning []
23:07 -!- blockstream_bot [blockstrea@gateway/shell/sameroom/x-lsntjcdlexygkbwj] has joined #c-lightning
23:35 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #c-lightning
23:36 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
--- Log closed Sun Nov 29 00:00:30 2020