--- Log opened Tue Jul 20 00:00:11 2021 00:39 -!- jarthur [~jarthur@2603-8080-1540-002d-8911-e5b6-6ab4-72d3.res6.spectrum.com] has quit [Quit: jarthur] 04:17 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 06:26 -!- openoms [~quassel@gateway/tor-sasl/openoms] has quit [Remote host closed the connection] 06:26 -!- openoms [~quassel@gateway/tor-sasl/openoms] has joined #c-lightning 08:05 -!- Victorsueca [~Victorsue@90.165.120.190] has joined #c-lightning 11:01 < nathanael> hmm `lightning-cli listforwards settled` should work imo - synopsis according to the manpage: listforwards [status] [in_channel] [out_channel] - i get an error saying it needs a short_channel_id 12:39 < vincenzopalazzo> I think that the order of the parameter is wrong, or maybe the description? However, this PR should be contains a solution https://github.com/ElementsProject/lightning/pull/4668 13:09 -!- rich- is now known as yakshaver_ 13:11 -!- yakshaver_ is now known as yakshaver 14:32 < rusty> nathanael: nice catch, yes, doc is wrong. Unf it was in previous release so changing order to match docs is a breaking change (vs. changing docs). Commented on PR vincenzopalazzo 14:33 < vincenzopalazzo> rusty: Ops, I will close the PR and open a new one. i missed to check the changelog, sorry 14:34 < rusty> vincenzopalazzo: I used git blame to get commit 8a8f81175d, then git describe --contains 8a8f81175d returned v0.10.0rc1~166 14:35 < rusty> I mean, we *could* change order, but it's messy :( I agree that status first is probably nicest. lightning-cli listforwards status=settled is less nice. 14:38 < vincenzopalazzo> rusty: Yes agree to have the status before, but if something is already in production is better to leave it as is. angry people are bad for API change are bad :) 14:39 < rusty> We have a 2-release / 6 month window for deprecating old APIs. And we can detect this (status and short-channel-id are easy to distinguish). But it's a bit messy. nathanael, vincenzopalazzo: thoughts? 14:40 < rusty> (API changes are painful in the short term, but bad APIs are painful forever!) 14:41 < vincenzopalazzo> rusty: the first think that this quotes need to be in a book (API changes are painful in the short term, but bad APIs are painful forever!) 14:41 < vincenzopalazzo> for the api, I think we can open an issue and change it later? 14:42 < vincenzopalazzo> in another major version? like 0.11.0 14:42 < rusty> Well, if we change it right now, it's only been that way for one release. 14:42 < rusty> (And that means *today*, since we are about to release rc1!) 14:42 < rusty> niftynei: ? 14:43 < vincenzopalazzo> this is also true 14:44 < rusty> Let me quickly hack something together for review, while we think if this is worthwhile... 14:45 < vincenzopalazzo> So, I will reopen the PR 15:09 < rusty> vincenzopalazzo: untested, but something like this? https://0bin.net/paste/aEXqITFF#t1vJmCnoeWKneWjpU6GbLswFBWqFooRZ5ffYftJC47F 15:09 < rusty> (gtg, my kids are waking up!) 15:17 < vincenzopalazzo> ack, to deprecate the API and move on with a API change. i you want I can work on your draft and integrate it in the PR? 16:26 < rusty> vincenzopalazzo: please do! 16:27 < rusty> (Test might be nice, ofc! :) 16:56 -!- belcher_ [~belcher@user/belcher] has joined #c-lightning 16:59 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 258 seconds] 17:04 -!- Victorsueca [~Victorsue@90.165.120.190] has quit [Ping timeout: 255 seconds] 17:30 -!- Victorsueca [~Victorsue@90.165.120.190] has joined #c-lightning 17:30 -!- Victorsueca [~Victorsue@90.165.120.190] has quit [Remote host closed the connection] 18:16 -!- openoms [~quassel@gateway/tor-sasl/openoms] has quit [Ping timeout: 244 seconds] 18:18 -!- openoms [~quassel@gateway/tor-sasl/openoms] has joined #c-lightning 18:19 < rusty> openoms / openoms[m]: around? 19:08 -!- rusty [~rusty@103.93.169.121] has quit [Remote host closed the connection] 20:50 -!- jarthur [~jarthur@2603-8080-1540-002d-0c88-90bf-c374-a374.res6.spectrum.com] has joined #c-lightning 20:54 < openoms> @rusty is this about changing listforwards? 20:58 < openoms[m]> apps using it would be RTL through c-lightning-REST https://github.com/Ride-The-Lightning/c-lightning-REST 20:58 < openoms[m]> and Spark Wallet / Sparko 22:20 -!- rusty [~rusty@103.93.169.121] has joined #c-lightning 22:31 -!- rusty [~rusty@103.93.169.121] has quit [Ping timeout: 252 seconds] 22:31 -!- rusty [~rusty@103.93.169.121] has joined #c-lightning 23:05 -!- jarthur [~jarthur@2603-8080-1540-002d-0c88-90bf-c374-a374.res6.spectrum.com] has quit [Quit: jarthur] 23:28 -!- openoms [~quassel@gateway/tor-sasl/openoms] has quit [Remote host closed the connection] 23:29 -!- openoms [~quassel@gateway/tor-sasl/openoms] has joined #c-lightning 23:39 -!- Aditya [~Aditya@182.68.103.31] has joined #c-lightning 23:39 < rusty> Aditya: welcome! 23:40 < Aditya> Thank you!, I am glad to be a part of this group. --- Log closed Wed Jul 21 00:00:12 2021