--- Log opened Sun Aug 08 00:00:32 2021 00:52 -!- Shing [~Shing@45.131.194.35] has quit [Quit: Client closed] 02:45 -!- darosior [~darosior@194.36.189.246] has quit [Ping timeout: 245 seconds] 02:46 -!- darosior [~darosior@194.36.189.246] has joined #c-lightning 02:48 -!- ufotofu [~ufotofu@user/ufotofu] has quit [Ping timeout: 256 seconds] 02:51 -!- berndj [~berndj@ns1.linksynergy.co.za] has quit [Ping timeout: 256 seconds] 02:53 -!- _niftynei [~niftynei@2600:1700:d0e:284f:7a73:6d66:5569:a371] has quit [Ping timeout: 250 seconds] 02:54 -!- roasbeef [~roasbeef@104.131.26.124] has quit [Ping timeout: 252 seconds] 02:56 -!- niftynei [~niftynei@2600:1700:d0e:284f:14f4:8238:2d28:af2b] has joined #c-lightning 03:01 -!- niftynei [~niftynei@2600:1700:d0e:284f:14f4:8238:2d28:af2b] has quit [Ping timeout: 256 seconds] 03:04 -!- berndj [~berndj@ns1.linksynergy.co.za] has joined #c-lightning 03:04 -!- ufotofu [~ufotofu@user/ufotofu] has joined #c-lightning 03:11 -!- berndj [~berndj@ns1.linksynergy.co.za] has quit [Excess Flood] 03:13 -!- berndj [~berndj@ns1.linksynergy.co.za] has joined #c-lightning 03:24 -!- rusty [~rusty@103.93.169.121] has joined #c-lightning 03:27 -!- Victorsueca [~Victorsue@90.165.120.190] has joined #c-lightning 03:28 -!- k3tan [~pi@user/k3tan] has quit [Ping timeout: 240 seconds] 03:29 -!- roasbeef [~roasbeef@104.131.26.124] has joined #c-lightning 03:55 -!- k3tan [~pi@user/k3tan] has joined #c-lightning 04:26 -!- rusty [~rusty@103.93.169.121] has quit [Ping timeout: 256 seconds] 08:44 -!- jasan [~j@tunnel625336-pt.tunnel.tserv1.bud1.ipv6.he.net] has joined #c-lightning 08:45 * jasan waves to mschmoock! :) 08:46 -!- jasan [~j@tunnel625336-pt.tunnel.tserv1.bud1.ipv6.he.net] has quit [Client Quit] 09:50 -!- shing [~shing@c-71-197-149-235.hsd1.wa.comcast.net] has joined #c-lightning 10:39 < darosior> Got an issue with `wallet_find_utxo` on rc2. Maybe a bug, maybe i'm the bug. Will investigate further but wanted to let you know first 10:58 < shing> I made a new notification for channel closings. I've looked around in closing_control.c and closingd.c, but not sure exactly where i should be calling my `notify` method for the channel close. Any pointers? 10:59 < shing> I was planning on only creating the notifications, but I need to implement them somewhere in the code so i can create a test to make sure that it's working correctly 11:29 < darosior> Interesting so one of my UTXOs is mistakenly marked as having a CSV. But it's a P2WPKH. 11:29 < darosior> cdecker: ^ 11:38 -!- rusty [~rusty@103.93.169.121] has joined #c-lightning 11:42 -!- rusty [~rusty@103.93.169.121] has quit [Ping timeout: 250 seconds] 11:45 < cdecker[m]> That's in `listfunds`? We usually don't add any outputs that are still covered by a CSV in the `outputs` table (only adding them when ONCHAIND is done with them, after collecting into a p2wkh iirc). Though that might have changed with recent changes 11:46 -!- FelixWeis [sid154231@id-154231.stonehaven.irccloud.com] has quit [Ping timeout: 240 seconds] 11:47 < cdecker[m]> Shing: when would you want to notify about a close? There's the user calling close, the time we negotiated a close with a peer, the time we decide to timeout and go unilateral, or the time the close settles on-chain. Depending on that we can likely find a good place for it 11:51 -!- FelixWeis [sid154231@stonehaven.irccloud.com] has joined #c-lightning 11:53 -!- shing [~shing@c-71-197-149-235.hsd1.wa.comcast.net] has quit [Quit: Client closed] 13:17 -!- shing [~shing@c-71-197-149-235.hsd1.wa.comcast.net] has joined #c-lightning 13:19 < shing> cdecker I'm working on this issue:https://github.com/ElementsProject/lightning/issues/3662, which mentions mutual close by us/peer and unilateral due to htlc expiration and unilateral due to fees explicitly. My plan was to create those 4 close types/reasons as a baseline, and then we can add more as we need 13:29 -!- shing49 [~shing@45.131.194.70] has joined #c-lightning 13:30 -!- shing [~shing@c-71-197-149-235.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds] 13:34 -!- shing49 [~shing@45.131.194.70] has quit [Quit: Client closed] 13:35 -!- shing [~shing@45.131.194.70] has joined #c-lightning 17:30 -!- rusty [~rusty@203.221.41.134] has joined #c-lightning 21:40 -!- belcher_ [~belcher@user/belcher] has joined #c-lightning 21:44 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 250 seconds] 21:58 -!- Netsplit *.net <-> *.split quits: early, AdityaSharma[m]1, cdecker[m], FelixWeis 21:59 -!- Netsplit over, joins: FelixWeis, early, AdityaSharma[m]1, cdecker[m] 22:01 -!- Netsplit *.net <-> *.split quits: warren 22:01 -!- warren_ [~warren@fedora/wombat/warren] has joined #c-lightning 22:02 -!- merkle_noob[m] [~merklenoo@2001:470:69fc:105::bad0] has quit [Ping timeout: 252 seconds] 22:03 -!- cdecker[m] [~cdeckerma@2001:470:69fc:105::2e8e] has quit [Ping timeout: 272 seconds] 22:04 -!- Netsplit *.net <-> *.split quits: michaelfolkson, kanzure, qubenix, _aj_ 22:04 -!- _aj__ [aj@cerulean.erisian.com.au] has joined #c-lightning 22:05 -!- kanzure_ [~kanzure@user/kanzure] has joined #c-lightning 22:05 -!- kakolainen[m] [~kakolaine@2001:470:69fc:105::34f9] has quit [Ping timeout: 240 seconds] 22:05 -!- AdityaSharma[m]1 [~M1adityam@2001:470:69fc:105::c473] has quit [Ping timeout: 272 seconds] 22:05 -!- kon[m] [~konnixbit@2001:470:69fc:105::b9af] has quit [Ping timeout: 245 seconds] 22:06 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Ping timeout: 240 seconds] 22:06 -!- openoms[m] [~openomsma@2001:470:69fc:105::c2f] has quit [Ping timeout: 252 seconds] 22:06 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has quit [Ping timeout: 252 seconds] 22:06 -!- michaelfolkson [~michaelfo@138.68.143.20] has joined #c-lightning 22:06 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has quit [Ping timeout: 276 seconds] 22:07 -!- qubenix [~qubenix@user/qubenix] has joined #c-lightning 22:23 -!- rusty [~rusty@203.221.41.134] has quit [Ping timeout: 240 seconds] 22:24 -!- AdityaSharma[m]1 [~M1adityam@2001:470:69fc:105::c473] has joined #c-lightning 22:31 -!- kakolainen[m] [~kakolaine@2001:470:69fc:105::34f9] has joined #c-lightning 22:34 -!- kon[m] [~konnixbit@2001:470:69fc:105::b9af] has joined #c-lightning 22:35 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #c-lightning 22:36 -!- openoms[m] [~openomsma@2001:470:69fc:105::c2f] has joined #c-lightning 22:38 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has joined #c-lightning 22:38 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has joined #c-lightning 22:49 -!- merkle_noob[m] [~merklenoo@2001:470:69fc:105::bad0] has joined #c-lightning 22:58 -!- cdecker[m] [~cdeckerma@2001:470:69fc:105::2e8e] has joined #c-lightning 23:08 -!- belcher_ is now known as belcher 23:32 -!- shing [~shing@45.131.194.70] has quit [Quit: Client closed] 23:35 -!- rusty [~rusty@103.93.169.121] has joined #c-lightning 23:49 < darosior> cdecker: yes it's returned by listfunds, that surprised me as well. The output is present in listfunds but wasn't returned by wallet_find_utxos, turns out deep_enough() was returning false because of a mixed up condition wrt to the CSV (will propose a patch). Still it's weird that my coin had a CSV while it's a P2WPKH.. 23:49 < darosior> But good it made me find a bug :p --- Log closed Mon Aug 09 00:00:08 2021