--- Log opened Mon Sep 20 00:00:13 2021
00:24 -!- jonatack [jonatack@user/jonatack] has joined #c-lightning
00:49 -!- rusty [~rusty@203.221.41.134] has quit [Ping timeout: 252 seconds]
02:31 -!- rl-d [~administr@186.16.240.62] has joined #c-lightning
02:41 < jasan> cdecker[m]: see my https://github.com/ElementsProject/lightning/pull/4793 - that is what I need to do to compile the latest master on Alpine Linux, could it be related to issuos on OpenBSD, nathanael?
02:41 < nathanael> jasan: thanks - will check it out and get back soon
02:44 < cdecker[m]> The aio header sounds strange, we're not using aio anywhere else in the project, what definitions caused you to add that one?
02:44 < cdecker[m]> Just curious because I hadn't seen that one before
02:46 < jasan> cdecker[m]: will re-produce the errors, yes, forgot to include them in the comment...
02:49 < nathanael> jasan: i applied your diff and still get these errors: https://tmp.dalliard.ch/61485921432bcfda.txt
02:49 < nathanael> but thanks anyway
02:50 < jasan> nathanael: thank you for trying!
02:50 < nathanael> np
02:50 < nathanael> it looks like on openbsd it has something to do with sigaction
02:51 < jasan> right
02:51 < jasan> did you try adding to lightningd/lightningd.h the line        #include <signal.h> ?
02:52 < nathanael> will try
02:52 < jasan> and then just `make` again (no need to configure)
02:52 < nathanael> +1
02:52 < jasan> or gmake (? GNU Make on OpenBSD)
02:52 < nathanael> yeah its gmake ;)
02:53 < nathanael> i sometimes do gmake clean before a gmake
02:53 < nathanael> is that normally unnecessary?
02:53 < jasan> yes, unnecessary
02:53 < nathanael> ok thx
02:53 < jasan> but if you pull changes from master, you should ,/configure and gmake (without clean) should catch up and recognize what has changed
02:54 < jasan> in case not, I have a "fresh-compile" magic for c-lightning
02:54 < nathanael> hmm, when is clean necessary?
02:54 < nathanael> share the magic :P
02:54 < jasan> yes, a moment
02:56 < jasan> nathanael: https://termbin.com/qcmd
02:56 < nathanael> jasan: now i got 'plugins/libplugin-pay.c:1:10: fatal error: 'aio.h' file not found' - will try without the aio.h include
02:56 < jasan> nathanael: sure :)
02:56 < nathanael> weird that it didn't get that error before
02:56 < jasan> nathanael: it did not get to that file at all
02:56 < nathanael> thx for sharing
02:56 < nathanael> aaaah got it
02:56 < jasan> it erred before trying to compile that file
02:59 < nathanael> jasan: success (it seems)
03:00 < nathanael> my diff looks like this: https://tmp.dalliard.ch/61485bc2848f782f.txt
03:02 < jasan> nathanael: amazing!
03:03 < nathanael> jasan: did you try without adding the aio.h include?
03:03 < jasan> I am going to track down that aio.h - there was a reason I was adding it, maybe it can be replaced for something more general (and OBSD compatible)
03:03 < nathanael> ah perfect
03:04 < jasan> nathanael: what is your handle on github?
03:04 < nathanael> jasan: don't have github...
03:04 < jasan> fair enough
03:05 < nathanael> someone has to add the two sys/socket.h includes - pretty sure they are needed to build on openbsd
03:06 < jasan> nathanael: OK, I have noted your diff in the Alpine Linux build fix PR and will include it in my PR
03:06 < nathanael> jasan: could it be that when you add the two socket.h includes you don't need the aio?
03:07 < nathanael> thanks a lot!
03:07 < nathanael> (i have no idea what aio is, but just an idea...)
03:07 < jasan> nathanael: maybe... I am slow, compiling on 1 CPU at a time and the CPU is set to the lowest frequency :)
03:07 < jasan> me neither, it was just in the man page so I grabbed it and included...
03:08 < nathanael> ok easy, no hurry, let me know (or i will look at the pr too)
03:09 < nathanael> btw. i am also compiling with 1 cpu
03:09 < nathanael> but didn't change the frequency (i guess)
03:40 < jasan> cdecker[m]: How can I mention nathanael in the commit message if they have no github? Would Signed-off-by be appropriate?
03:41 < jasan> nathanael: ah, I see you have some commits smuggled into repository :)
03:41 < cdecker[m]> `Proposed-by` is customary, since `Signed-off-by` means they verified and endorse it.
03:42 < jasan> cdecker[m]: OK, thanks.
03:47 < jasan> cdecker, nathanael: fixed now without aio.h (using <sys/types.h> instead)
03:49 < jasan> nathanael: please try to compile a2e081f4760ebaba8bdd46381b5e650a06da31e0
03:49 < jasan> on OpenBSD
03:49 < jasan> https://github.com/ElementsProject/lightning/pull/4793/commits/a2e081f4760ebaba8bdd46381b5e650a06da31e0
04:14  * jasan will try to pull-in some kids (classmates) from the Chaincode Labs class for excursion tonight (meeting @ 20:00 UTC).
04:21 < cdecker[m]> Great, thanks jasan , I'm also working on Macos and FreeBSD builds in the CI, so we should catch these earlier in the future
04:24 < jasan> cdecker[m]: +1, my honor, sir
04:25 < cdecker[m]> Oh no, now we're using nobility titles here too, m'lord xD
04:28 < jasan> ;-)
04:29 < jasan> BTW, it would look great if we included <monetary.h> in c-lightning
04:29  * jasan is just kidding
04:30 < jasan> (it is one of alternatives to <sys/types.h>
04:32 < AdityaSharma[m]> > * <@jasan:libera.chat> will try to pull-in some kids (classmates) from the Chaincode Labs class for excursion tonight (meeting @ 20:00 UTC).
04:32 < AdityaSharma[m]> Are you also enrolled in the LN seminar?
04:32 < jasan> AdityaSharma[m]: no, just Bitcoin now
04:33 < jasan> bit will get there hopefully
04:36 < AdityaSharma[m]> jasan: Awesome, the material is really good 👍️
04:36 < nathanael> ack a2e081f from jasan ;)
04:36 < jasan> nathanael: thank you!
04:36  * jasan is going to note it in the PR...
04:37 < cdecker[m]> Oh man, I wish we could give those lectures in person again, it's awesome to discuss with students (and not talking to a wall)
04:38  * cdecker[m] is on CI duty, hoping to get as many PRs merged as possible before this evening's meeting
04:42 < jasan> cdecker[m]: Please also notice https://github.com/ElementsProject/lightning/pull/4794 whose CI of the same commit succeeded on my fork
04:43 < jasan> but feel free to close it, I just stumbled over it, thought first that the files need to be added to .gitignore, ... best way to learn
04:44 < cdecker[m]> Nope, I had a similar fix in my `cleanups` branch. Will get yours through CI and merge.
04:44 < jasan> OK, thanks.
04:45 < cdecker[m]> On the longer run we should likely see if we want to revert the policy of checking in derived files altogether. They tend to cause huge merge conflicts, pollute diffs and obfuscate the actual changes, and they are continually out of date anyway...
04:45 < cdecker[m]> Maybe a good topic to raise in today's meeting
04:47 < nathanael> cdecker[m]: why was that policy put in the first place? for me it would be logical not to put derived files into git
04:47 < nathanael> *put in in the first place
04:48 < jasan> nathanael: I guess because there were previously derived files processed by python scripts and c-lightning should not really require Python to build...
04:48 < nathanael> ah yes right thx
04:48 < cdecker[m]> It was because some new devs complained about having to install some python dependencies iirc, and the idea was to make the repo as self-contained as possible, but that ship has sailed a long time ago. We have since built incremental machinery to check if files where updated correctly, but that requires dev intervention to fix, rather than saying the fix is to run the bloody tools we wanted to avoid...
04:49 < jasan> yes
04:49 < cdecker[m]> But a dev environment without python is pretty useless as it is, since the testing framework is built on python, so why single out the template and wire generation?
04:50  * jasan hides, was not complaining, does not know how to answer the rhetorical question
04:51 < nathanael> i didn't try building c-lightning without python cause it was listed as a dependency to build on openbsd
04:51 < cdecker[m]> Not criticizing, just wondering if we should revisit this policy now that we know about the pain with and without it :-)
04:52 < jasan> cdecker[m]: I guess it has something to do with GNU Autoconf style of things. People are used to have source packages where they do not need to generate anything.
04:52 < nathanael> my comment was about a dev environment where you probably also build c-lightning, does it really work without python?
04:52 < jasan> So IMHO the git repository should not contain the generated files, but there should be release source tarballs that do.
04:53 < nathanael> or is python only used for the generation of manpages and the testsuite?
04:53 < cdecker[m]> nathanael: that's the theory, and we test it in CI https://github.com/ElementsProject/lightning/blob/master/.github/workflows/ci.yaml#L52
04:55 < nathanael> cdecker[m]: ah thx
04:56 < jasan> If there was a "source tarball" stage, easily run after cloning the git repo, which would require Python, but the following build stage would not... I think the point is to disentangle unrelated things.
04:59 < jasan> nathanael: Generally your point is right, there should only be sources in the repository, not generated files. But there is this beautiful history (and human culture!) which would get lost if everything was done right...
04:59  * jasan runs
05:01 < nathanael> jasan: well said. but i guess i understand the other side too. not depending on python. but the tests are as important (if not more important) than the code itself, and they depeond on python anyway
05:01 < nathanael> *depend
05:04 -!- rl-d [~administr@186.16.240.62] has quit [Read error: Connection reset by peer]
05:43 < jasan> cdecker[m]: https://github.com/ElementsProject/lightning/pull/4793 is missing just a higher-power ACK now
05:44 < cdecker[m]> Merged ^^
05:45 < jasan> wow, thanks!
05:45 < cdecker[m]> Will rebase #4782 on top of #4794 once that gets merged, that should get one step further ^^
05:46 < cdecker[m]> Actually quite nice to have people in the chat, coordinating pull requests ^^
05:56 < nathanael> my ack has power too :P
05:59 -!- rl-d [~administr@186.16.240.62] has joined #c-lightning
06:21 < jasan> nathanael: yes, it does, bit I thought not for bot because I wrote it from my account
06:21 < jasan> :s/bit/but/
06:23 < cdecker[m]> It's rather that the comment was using quotes, while the bot looks for `^ACK [commit]$` so the `>` prefix for the quote caused it not to trigger
06:23 < nathanael> ah ups jasan didn't realise you were talking about the bot, my bad
06:24 < jasan> cdecker[m]: does that mean I can ACK my own commit?
06:24 < nathanael> cdecker[m]: so someone could ack his own pull request?
06:24 < nathanael> ;)
06:24 < jasan> :)
07:00 -!- sr_gi [~sr_gi@static-43-117-230-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer]
07:01 -!- sr_gi [~sr_gi@static-43-117-230-77.ipcom.comunitel.net] has joined #c-lightning
07:02 < michaelfolkson> Is pylightning defunct? Subsumed/replaced by pyln-client?
07:03 < darosior> Yes
07:03 < michaelfolkson> Thanks
07:04 < michaelfolkson> We should probably make that clear on the Pypi page https://pypi.org/project/pylightning/
07:05 < michaelfolkson> Though probably needs to be a maintainer (Rusty, Christian)
07:06 < michaelfolkson> I guess I could open a PR for the repo https://github.com/ElementsProject/lightning/tree/master/contrib/pylightning
07:12 < jasan> cdecker[m]: https://github.com/ElementsProject/lightning/pull/4794 is also ready
07:25 < darosior> michaelfolkson: yep i think so :)
07:31 < michaelfolkson> Do you know what the "object" in the UnixDomainSocketRpc class represents? https://github.com/ElementsProject/lightning/blob/master/contrib/pyln-client/pyln/client/lightning.py#L280
07:32 < michaelfolkson> Tried to create a UNIX socket and failed
07:39 < vincenzopalazzo> michaelfolkson: I think that this class contains the minimum requirements to talk with a unix socket. What you are trying to do? Did I misunderstand your question?
07:42 < michaelfolkson> vincenzopalazzo: Trying to create a connection to a c-lightning node from a Python client and changing the code to try to get it to work
09:59 -!- achow101 [~achow101@user/achow101] has quit [Quit: Bye]
10:01 -!- achow101 [~achow101@user/achow101] has joined #c-lightning
10:29 -!- valwal7 [~valwal@70.107.207.192] has joined #c-lightning
10:29 -!- valwal [~valwal@70.107.207.192] has quit [Ping timeout: 260 seconds]
10:29 -!- valwal7 is now known as valwal
10:31 < vincenzopalazzo> michaelfolkson: what is the error that you receive?
10:45 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity]
11:53 < cdecker[m]> Small little agenda for the meeting in ~1h: https://hackmd.io/@cdecker/Sy-9vZIQt
11:54 < cdecker[m]> Let me know if you'd like to add something to it, thought I'd share the release status and add a common topic of discussion ^^
12:03 < vincenzopalazzo> ooh this is cool Christian Decker 
12:10 < vincenzopalazzo> I don't know if it can be interesting, but on this PR https://github.com/ElementsProject/lightning/pull/4782 there are undocumented proprieties that I'm working on to document it but there are some of them that I don't know the meaning, maybe can be helpful to talk today or have some review on it can be enough
12:11 < cdecker[m]> Yep, saw them too (and forgot to submit my comments again...)
12:13 < vincenzopalazzo> Oh cool, the gfithub UI it is frustrating when there are a lot of change inside it :/ maybe we need to review the method how we generate the sha256stamp too at some point
12:15 < vincenzopalazzo> but thank Christian Decker  I only miss the doc of proprieties and after that, we have the main page check also in the CI :) (another frustrating thing when we add a new feature :-P )
12:31 < michaelfolkson> cdecker[m]: Maybe skip this week as there seems a lot to discuss with the release but a short section at the beginning revisiting progress on items from the last meeting (e.g. the Python dependency problem) might generally be worth it
12:33 < vincenzopalazzo> michaelfolkson: concept ack, maybe in the first part
12:42 < cdecker[m]> Good idea michaelfolkson , will prep a recap for next time. The release progress is mostly there for progress, don't intend to go through in detail.
12:44 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
12:52 -!- rusty [~rusty@103.93.169.121] has joined #c-lightning
12:56 < rl-d> how to join meeting?
12:58 < cdecker[m]> Just need to find the meeting link ^^
12:58 < nathanael> https://meet.jit.si/CLightning-Open-Meeting
13:26 -!- rl-d [~administr@186.16.240.62] has quit [Read error: Connection reset by peer]
13:31 -!- rl-d [~administr@186.16.240.62] has joined #c-lightning
13:54 -!- Jackielove4u [uid43977@user/jackielove4u] has joined #c-lightning
14:06 -!- rl-d_ [~administr@186.16.240.62] has joined #c-lightning
14:08 -!- rl-d [~administr@186.16.240.62] has quit [Quit: Lost terminal]
14:33 < rusty> BTW, for me, it's 40 seconds for clean build (ccache), vs 60 seconds for build with generating all the files.
14:36 < vincenzopalazzo> rusty: if you send me the command in these day I will test it on my raspberry pi
14:36 < vincenzopalazzo> well it run java, it is ok for big building stage :-P 
14:58 -!- rusty [~rusty@103.93.169.121] has quit [Ping timeout: 264 seconds]
16:32 -!- rusty [~rusty@tro1759202.lnk.telstra.net] has joined #c-lightning
16:33 < rusty> vincenzopalazzo: 1. make distclean && ./configure --enable-developer --enable-experimental-features && time make
16:33 < rusty> 2. make maintainer-clean && ./configure --enable-developer --enable-experimental-features && time make
16:44 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity]
17:24 -!- rusty [~rusty@tro1759202.lnk.telstra.net] has quit [Ping timeout: 264 seconds]
17:34 -!- rusty [~rusty@203.221.41.134] has joined #c-lightning
18:17 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 268 seconds]
18:29 -!- belcher [~belcher@user/belcher] has joined #c-lightning
19:54 -!- rl-d_ [~administr@186.16.240.62] has quit [Ping timeout: 246 seconds]
19:56 -!- rl-d [~administr@186.16.235.184] has joined #c-lightning
22:40 -!- rusty [~rusty@203.221.41.134] has quit [Ping timeout: 252 seconds]
23:52 -!- rusty [~rusty@103.93.169.121] has joined #c-lightning
--- Log closed Tue Sep 21 00:00:13 2021