--- Log opened Sat Sep 25 00:00:17 2021 02:03 -!- kexkey [~kexkey@static-198-54-132-107.cust.tzulo.com] has quit [Ping timeout: 252 seconds] 02:04 -!- kexkey [~kexkey@static-198-54-132-171.cust.tzulo.com] has joined #c-lightning 05:20 -!- qubenix [~qubenix@66.172.11.228] has quit [Quit: quit] 05:20 -!- qubenix [~qubenix@user/qubenix] has joined #c-lightning 06:28 < cdecker[m]> `getmanifest` is a function that is buil into the pyln library, and returns metadata to `lightningd` upon startup. This sounds like either helpme is doing something crazy to hook into the startup or you're running out of memory or CPU resources, which can also delay it from returning 06:29 < nathanael> cdecker[m]: gitignore looks almost perfect, i still have 'devtools/features' as an untracked file 06:30 < cdecker[m]> Right, forgot about that one. Happy to accept a simple PR for that one, otherwise happy to do it on Monday 06:30 < nathanael> no hurry 06:31 < vincenzopalazzo> Christian Decker: I can do it, I have the code open in my emacs right now, that I'm pull out some autogen file from my PR that fixes make check 06:33 < vincenzopalazzo> Christian Decker: Small question, the prefix misc mean? I like your prefixed commit :) it tell where looking for 06:35 < cdecker[m]> `misc` just means miscelanous, so it doesnt fit anywhere else :-) 06:35 < cdecker[m]> I prefix things so they are easy to pick out by reviewers that concentrate on certain subsystems 06:40 < vincenzopalazzo> I got it. Yeah it point you in the place where you need to see the change. 06:40 < vincenzopalazzo> here we go, https://github.com/ElementsProject/lightning/pull/4817 06:41 < vincenzopalazzo> Sorry if I missed this line during the review of your PR, but I thought that it doesn't need to include in the .gitingnore 07:11 < cdecker[m]> No problem. Got CI backed up trying to fix my CI additions, so it'll take a moment to get the green all-clear 😜 07:55 < vincenzopalazzo> pip it is able to make strange stuff 08:11 < cdecker[m]> Yeah, I'm working on locking the dependencies using a requirements.lock file which lists explicit versions, so we don't get into the endless resolution loop. It's discouraged for libraries, but encouraged for apps, which I think matches out CI use case 08:21 < vincenzopalazzo> Christian Decker: I agree, at the end of the day the CI it is an app with a few minutes of life :-) 08:50 -!- raj [~raj_@103.77.139.176] has joined #c-lightning 10:00 -!- Raj_ [~Raj@2602:ffb6:4:e396:f816:3eff:fe47:ca2a] has joined #c-lightning 10:11 -!- raj [~raj_@103.77.139.176] has quit [Quit: Leaving] 10:27 -!- raj [~raj_@103.77.139.176] has joined #c-lightning 10:28 < mschmoock> cdecker[m]: How do you feel about adding some IP address detection in our code (with subsequent node_announcement updates) instead of adding DNS support to the protocol? Another thought I had was adding the IP address a node connected from in the init message of the responder so that when we see multiple matching IPv4 addresses we know we need to send an update. Pro: more plug and play Con: ugly 10:28 < mschmoock> :D 10:29 -!- raj [~raj_@103.77.139.176] has quit [Client Quit] 10:40 -!- raj [~raj_@103.77.139.176] has joined #c-lightning 10:59 -!- belcher [~belcher@user/belcher] has quit [Read error: Connection reset by peer] 11:06 -!- raj [~raj_@103.77.139.176] has quit [Quit: Leaving] 11:12 -!- belcher [~belcher@user/belcher] has joined #c-lightning 11:14 -!- qubenix [~qubenix@user/qubenix] has quit [Quit: quit] 11:17 -!- qubenix [~qubenix@user/qubenix] has joined #c-lightning 11:26 -!- qubenix [~qubenix@user/qubenix] has quit [Quit: quit] 12:02 -!- qubenix [~qubenix@user/qubenix] has joined #c-lightning 12:55 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] 13:32 -!- jonatack [jonatack@user/jonatack] has joined #c-lightning 13:40 -!- jonatack [jonatack@user/jonatack] has quit [Quit: Connection closed] 13:49 -!- jonatack [jonatack@user/jonatack] has joined #c-lightning 23:19 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 252 seconds] --- Log closed Sun Sep 26 00:00:18 2021