--- Log opened Fri Oct 08 00:00:29 2021 02:03 -!- kexkey [~kexkey@static-198-54-132-172.cust.tzulo.com] has quit [Ping timeout: 245 seconds] 02:04 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has joined #c-lightning 06:15 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 06:20 -!- AdityaSharma[m] [~M1adityam@2001:470:69fc:105::c473] has quit [Remote host closed the connection] 06:20 -!- kon[m] [~konnixbit@2001:470:69fc:105::b9af] has quit [Remote host closed the connection] 06:20 -!- Dan[m]1234 [~drobertsm@2001:470:69fc:105::c80] has quit [Remote host closed the connection] 06:20 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Read error: Connection reset by peer] 06:20 -!- cdecker[m] [~cdeckerma@2001:470:69fc:105::2e8e] has quit [Remote host closed the connection] 06:20 -!- openoms[m] [~openomsma@2001:470:69fc:105::c2f] has quit [Read error: Connection reset by peer] 06:20 -!- merkle_noob[m] [~merklenoo@2001:470:69fc:105::bad0] has quit [Remote host closed the connection] 06:20 -!- kakolainen[m]1 [~kakolaine@2001:470:69fc:105::34f9] has quit [Remote host closed the connection] 06:20 -!- xenonfun[m] [~xenonfunm@2001:470:69fc:105::f992] has quit [Read error: Connection reset by peer] 06:20 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has quit [Write error: Connection reset by peer] 06:20 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has quit [Read error: Connection reset by peer] 06:22 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has joined #c-lightning 06:41 -!- merkle_noob[m] [~merklenoo@2001:470:69fc:105::bad0] has joined #c-lightning 06:41 -!- openoms[m] [~openomsma@2001:470:69fc:105::c2f] has joined #c-lightning 06:41 -!- kon[m] [~konnixbit@2001:470:69fc:105::b9af] has joined #c-lightning 06:41 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #c-lightning 06:41 -!- cdecker[m] [~cdeckerma@2001:470:69fc:105::2e8e] has joined #c-lightning 06:41 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has joined #c-lightning 06:41 -!- kakolainen[m] [~kakolaine@2001:470:69fc:105::34f9] has joined #c-lightning 06:41 -!- xenonfun[m] [~xenonfunm@2001:470:69fc:105::f992] has joined #c-lightning 06:41 -!- AdityaSharma[m] [~M1adityam@2001:470:69fc:105::c473] has joined #c-lightning 06:41 -!- Dan[m]1234 [~drobertsm@2001:470:69fc:105::c80] has joined #c-lightning 07:07 < mschmoock> I could need a pre-review on #4829. Still having 3 minor TODOs in, but the code should work. However I am stuck on a VALGRIND issue where it reads uninitialized data. See my comment on https://github.com/ElementsProject/lightning/pull/4829/files#diff-1ddaf09a87c650a7006230fdf4757bcc6cd56cb15b85950b338e8a9549670423R855-R880 07:09 < mschmoock> any help appreciated 07:35 < cdecker[m]> Quite an interesting one you got there, looks like a stale pointer to memory that was reallocated 07:36 < cdecker[m]> `tal_resize` or `tal_arr_expand` may have to create an entirely new copy of the original array, when there isn't enough room to do so in-place 07:39 < cdecker[m]> So I'm thinking `connect->addrs` is not being updated correctly, and points to the old, now freed copy, of the array when you call `try_connect_one_addr` however I fail to see why that's the case. Maybe stepping through and seeing what the pointer values are and when they change can help here 08:12 < cdecker[m]> Wow, I got CI backed up quiet nicely... I wish we could offload the `valgrind` tests to somewhere else 08:56 < mschmoock> cdecker[m]: thanks, will check that 08:56 < mschmoock> so at least I know I'm not stupid :D 08:58 < mschmoock> We can fade that PR in after the next release. I know t-bast has done the 'report remote IP' feature in acinq implementation. I assume we can do compat tests on both changes soon 10:11 < mschmoock> cdecker[m]: your right, it seems I was totally messing with the data 10:35 < mschmoock> a addr = &connect->addrs[connect->addrnum]; after the tal_arr_expand fixes this for the next iteration :D 10:36 < mschmoock> addr was pointing to the old (now freed) allocation 10:36 < mschmoock> -.- 10:43 < mschmoock> almost fixed --- Log closed Fri Oct 08 10:47:32 2021 --- Log opened Fri Oct 08 10:47:32 2021 11:50 -!- jarthur [~jarthur@2603-8080-1540-002d-84ec-26e7-f43c-0412.res6.spectrum.com] has joined #c-lightning 13:09 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 245 seconds] 13:28 < mschmoock> okay. now DNS works as intended. Just some final stuff on error handling and the PR is good to go 13:45 < cdecker[m]> Nice work 👍 If only you'd know how often that reallocation has bitten me in the past :-) 14:11 -!- jarthur_ [~jarthur@2603-8080-1540-002d-2945-239c-37f8-0688.res6.spectrum.com] has joined #c-lightning 14:13 -!- jarthur [~jarthur@2603-8080-1540-002d-84ec-26e7-f43c-0412.res6.spectrum.com] has quit [Ping timeout: 245 seconds] 16:22 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 268 seconds] 16:29 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 16:34 -!- belcher [~belcher@user/belcher] has joined #c-lightning 21:09 -!- rusty [~rusty@pa49-178-39-200.pa.nsw.optusnet.com.au] has joined #c-lightning 22:35 -!- Victorsueca [~Victorsue@user/victorsueca] has joined #c-lightning 23:00 -!- rusty [~rusty@pa49-178-39-200.pa.nsw.optusnet.com.au] has quit [Ping timeout: 265 seconds] --- Log closed Sat Oct 09 00:00:30 2021