--- Log opened Mon Nov 08 00:00:26 2021 00:08 -!- jarthur_ [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has quit [Quit: jarthur_] 01:11 -!- Guest6516 [~Guest65@bba415164.alshamil.net.ae] has joined #c-lightning 01:11 -!- Guest6516 [~Guest65@bba415164.alshamil.net.ae] has quit [Client Quit] 02:04 -!- kexkey_ [~kexkey@static-198-54-132-86.cust.tzulo.com] has quit [Ping timeout: 244 seconds] 02:05 -!- kexkey [~kexkey@static-198-54-132-150.cust.tzulo.com] has joined #c-lightning 02:27 -!- aechu [~major@gateway/tor-sasl/major] has quit [Remote host closed the connection] 02:33 -!- aechu [~major@gateway/tor-sasl/major] has joined #c-lightning 03:57 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning 03:59 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 276 seconds] 04:02 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 04:03 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning 05:03 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning 05:04 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 05:26 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning 05:27 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 276 seconds] 05:31 -!- michaelfolkson2 is now known as michaelfolkson 05:53 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 06:28 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning 06:29 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 07:18 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 07:18 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning 07:27 -!- Guest5411 [~Guest54@190.96.41.170] has joined #c-lightning 08:14 -!- Guest5411 [~Guest54@190.96.41.170] has quit [Quit: Client closed] 08:46 -!- denis2342 [~denis@p4fd22ebd.dip0.t-ipconnect.de] has joined #c-lightning 09:18 -!- Victorsueca [~Victorsue@user/victorsueca] has quit [Ping timeout: 268 seconds] 09:44 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 09:45 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning 10:02 -!- denis2342 [~denis@p4fd22ebd.dip0.t-ipconnect.de] has quit [Ping timeout: 244 seconds] 10:05 -!- denis2342 [~denis@p4fd2291a.dip0.t-ipconnect.de] has joined #c-lightning 10:14 -!- denis2342 [~denis@p4fd2291a.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds] 10:15 -!- denis2342 [~denis@p4fd22971.dip0.t-ipconnect.de] has joined #c-lightning 10:52 -!- niftynei [~niftynei@99-8-218-209.lightspeed.hstntx.sbcglobal.net] has joined #c-lightning 10:53 < niftynei> my calendar is telling me that we're having a spec meeting in 7 minutes 10:53 < niftynei> the agenda for the meeting is here https://github.com/lightning/bolts/issues/933 10:53 < niftynei> (ty t-bast!) 10:54 < niftynei> oh this was the wrong channel, should have posted this in #lightning-dev 10:58 -!- rusty [~rusty@203.217.90.66] has joined #c-lightning 11:11 < denis2342> the output of msats from paystatus command is doubled (amount_msat). possibly undetected because the prettyprinting of jq hides this 11:12 < denis2342> niftynei: so you are also confused with all the channels? ;) 11:13 -!- sr_gi [~sr_gi@static-43-117-230-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer] 11:15 -!- sr_gi [~sr_gi@static-43-117-230-77.ipcom.comunitel.net] has joined #c-lightning 11:20 < niftynei> denis2342, if by "all channels" you mean "two" then yes lol :P 11:20 < niftynei> denis2342, can you share an example of where you're getting the paystatus error? 11:21 < denis2342> I simply run “lightning-cli paystatus” 11:22 < denis2342> using latest version 0.10.2 11:24 < denis2342> ah, and I dont mean the value is doubled, I mean the entry is there two times! 11:29 < niftynei> ah haa 11:29 < niftynei> can you give me an example of a doubled field? 11:30 < niftynei> typically we print both a field {"amount": 888, "amt_msat": "888msat"} 11:31 < niftynei> there's a number type entry and a string type entry (with a unit type on it) 11:32 < denis2342> it looks like this: "amount_msat": "162090000msat","amount_msat": "162090000msat", 11:32 < denis2342> I only see two string type entries 11:33 < rusty> denis2342: can you give the full JSON output? Feel free to send privately if preferred. 11:38 < denis2342> got it: https://pastebin.com/hhV8Tybr 11:48 -!- DiemOneDiamond [~DiemOneDi@86-45-239-19-dynamic.agg2.sla.mvw-sla.eircom.net] has joined #c-lightning 11:50 -!- DiemOneDiamond [~DiemOneDi@86-45-239-19-dynamic.agg2.sla.mvw-sla.eircom.net] has quit [Client Quit] 11:51 -!- DiemOneDiamond [~DiemOneDi@86-45-239-19-dynamic.agg2.sla.mvw-sla.eircom.net] has joined #c-lightning 11:51 -!- DiemOneDiamond [~DiemOneDi@86-45-239-19-dynamic.agg2.sla.mvw-sla.eircom.net] has quit [Client Quit] 11:54 -!- DiemOneDiamond [~DiemOneDi@86-45-239-19-dynamic.agg2.sla.mvw-sla.eircom.net] has joined #c-lightning 11:55 -!- DiemOneDiamond [~DiemOneDi@86-45-239-19-dynamic.agg2.sla.mvw-sla.eircom.net] has quit [Client Quit] 11:55 -!- DiemOneDiamond [~DiemOneDi@86-45-239-19-dynamic.agg2.sla.mvw-sla.eircom.net] has joined #c-lightning 11:57 < rusty> denis2342: reproduced here, thanks! 11:59 < denis2342> ok, thanks for taking care 12:00 -!- denis2342 [~denis@p4fd22971.dip0.t-ipconnect.de] has quit [Quit: denis2342] 12:03 -!- DiemOneDiamond [~DiemOneDi@86-45-239-19-dynamic.agg2.sla.mvw-sla.eircom.net] has quit [Quit: Client closed] 12:10 -!- niftynei [~niftynei@99-8-218-209.lightspeed.hstntx.sbcglobal.net] has quit [Quit: Leaving] 12:13 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 12:14 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning 12:23 -!- jarthur [~jarthur@2603-8080-1540-002d-58a6-5967-745c-e63f.res6.spectrum.com] has joined #c-lightning 12:27 < vincenzopalazzo> rusty: I can take a look later this night to this if you have no time 12:28 < vincenzopalazzo> #4911 I was too slow :-P 12:29 -!- rusty [~rusty@203.217.90.66] has quit [Ping timeout: 244 seconds] 12:35 -!- jespada [~jespada@190.7.36.46] has joined #c-lightning 12:44 -!- denis2342 [~denis@p4fd2b0c5.dip0.t-ipconnect.de] has joined #c-lightning 12:50 < denis2342> regarding #4911. isnt it supposed to be one string and one number of the amount? 13:17 < vincenzopalazzo> denis2342: the amount in msat is a string because it has a msat as a suffix. Maybe I miss understood the question? 13:18 < denis2342> vincenzopalazzo: niftynei mentioned earlier that there should be one string and one integer field with the amount 13:21 -!- jespada [~jespada@190.7.36.46] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 13:24 < vincenzopalazzo> denis2342: I can't answer for sure because I think the doc paystatus is missing. For what I see in the code there is no amount in sat 13:24 < vincenzopalazzo> Usually whe int value it is reported when the unit it is satoshi 13:27 < denis2342> vincenzopalazzo: listsendpays says otherwise 13:28 < vincenzopalazzo> denis2342: what said? 13:29 < denis2342> the output of listsendpays has msatoshi as int 13:29 < denis2342> also msatoshi_sent is int 13:30 < denis2342> amount_msat and amount_sent_msat is a string 13:31 < vincenzopalazzo> Ah, I see your point now 13:32 < vincenzopalazzo> Yep the command looks like that has different convention, and I agree with your idea that the msat prefix it is already in the propriety name, so we can put a int like as value 13:34 < denis2342> maybe the code in the error is just the name for the key and not that it is a double entry 13:34 < denis2342> I mean the error in the code… 13:36 < vincenzopalazzo> I think that the double entry it is some refused, because c-lightning has a deprecated phase, and two type of serializzation in json (old and new) are supported. At the end of this deprecation phase, the code it is removed by hand. 13:38 < vincenzopalazzo> I think that the only point here can be the convention between commands, but I agree that there is some inconsistency across payloads with "*_msat" 14:07 < denis2342> maybe json_add_amount_msat_compat() is function which should be used 14:19 < denis2342> yes, both amount_msat lines can be removed and replaced with: json_add_amount_msat_compat(ret, p->amount, "msatoshi", "amount_msat"); 14:38 < denis2342> I made a comment with the codechange on #4911, I didnt want to open another pull request 14:53 -!- rusty [~rusty@203.217.90.66] has joined #c-lightning 14:56 < denis2342> rusty: I added a comment with a code proposal to #4911 15:15 -!- rusty [~rusty@203.217.90.66] has quit [Ping timeout: 240 seconds] 15:37 -!- jarthur_ [~jarthur@2603-8080-1540-002d-cce3-74e0-cf74-3ab2.res6.spectrum.com] has joined #c-lightning 15:38 -!- jarthur [~jarthur@2603-8080-1540-002d-58a6-5967-745c-e63f.res6.spectrum.com] has quit [Ping timeout: 240 seconds] 15:48 -!- rusty [~rusty@203.217.90.66] has joined #c-lightning 16:04 -!- rusty [~rusty@203.217.90.66] has quit [Ping timeout: 240 seconds] 16:31 -!- denis2342 [~denis@p4fd2b0c5.dip0.t-ipconnect.de] has quit [Quit: denis2342] 18:18 -!- sr_gi7 [~sr_gi@static-195-77-225-77.ipcom.comunitel.net] has joined #c-lightning 18:19 -!- sr_gi [~sr_gi@static-43-117-230-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer] 18:19 -!- sr_gi7 is now known as sr_gi 18:53 -!- rusty [~rusty@pa49-178-159-123.pa.nsw.optusnet.com.au] has joined #c-lightning 19:15 -!- rusty [~rusty@pa49-178-159-123.pa.nsw.optusnet.com.au] has quit [Ping timeout: 250 seconds] 19:32 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning 19:33 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 276 seconds] 20:06 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 20:44 -!- Netsplit *.net <-> *.split quits: Anorak 20:45 -!- Netsplit over, joins: Anorak 20:51 -!- Anorak [~Anorak@cpe-66-91-76-218.hawaii.res.rr.com] has quit [] 21:03 -!- TheWizardAnorak [~TheWizard@cpe-66-91-76-218.hawaii.res.rr.com] has joined #c-lightning 21:06 -!- TheWizardAnorak [~TheWizard@cpe-66-91-76-218.hawaii.res.rr.com] has quit [Client Quit] 21:09 -!- TheWizardAnorak [~TheWizard@cpe-66-91-76-218.hawaii.res.rr.com] has joined #c-lightning 21:27 -!- TheWizardAnorak [~TheWizard@cpe-66-91-76-218.hawaii.res.rr.com] has quit [] 22:10 -!- TheOasis [~TheOasis@cpe-66-91-76-218.hawaii.res.rr.com] has joined #c-lightning 22:10 -!- TheOasis is now known as Guest7461 22:10 -!- Guest7461 [~TheOasis@cpe-66-91-76-218.hawaii.res.rr.com] has quit [Client Quit] 22:22 -!- An0rak [~An0rak@user/an0rak] has joined #c-lightning 22:51 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 22:51 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #c-lightning 23:34 -!- An0rak [~An0rak@user/an0rak] has left #c-lightning [] 23:35 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 23:35 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 276 seconds] 23:35 -!- jarthur_ [~jarthur@2603-8080-1540-002d-cce3-74e0-cf74-3ab2.res6.spectrum.com] has quit [Quit: jarthur_] --- Log closed Tue Nov 09 00:00:27 2021