--- Log opened Sun Dec 05 00:00:52 2021
00:12 < vincenzopalazzo> nathanael: Can you link me also the version of python that you are working on?
01:41 < nathanael> vincenzopalazzo: python 3.8.12
01:42 < nathanael> it's the python3 version on openbsd 7.0
01:43 < vincenzopalazzo> nathanael: Thanks, pushed a fix on the PR, we try to remove the db in case of error for now, but I think there is somethings else
01:46 < nathanael> vincenzopalazzo: os.remove("summary.dat.db") worked on my end, not sure the glob is necessary - will try the new pr next time
01:47 < vincenzopalazzo> I use glob because I read that it is no olways the same extension of the file
01:47 < nathanael> ah i just read the stackoverflow answer
01:48 < nathanael> you're right, your solution is probably more future proof
01:48 < vincenzopalazzo> it is only a method to say "Remove all the file that start with summary.dat*"
01:48 < vincenzopalazzo> nathanael: for not it is just an hack :)
01:49 < nathanael> yeah - i will ack next time i restart the node, but the pr looks good
01:49 < vincenzopalazzo> nathanael: I will subscript to your event to receive feedback :) thanks for your time
01:52 < nathanael> vincenzopalazzo: a simple 'plugin stop' and 'plugin start' gives me the expected "plugin-summary.py: Error during db initialization: [Errno 79] Inappropriate file type or format: 'summary.dat'"
01:52 < nathanael> as said, will see if it works when restarting the whole node next time
01:54 < vincenzopalazzo> mh I need to check, if the summary plugin will close the db in case of stop command
01:54 < vincenzopalazzo> but there is somethings else under the hood
01:56 < nathanael> ah, you think maybe it was never closed?
01:57 < vincenzopalazzo> nathanael: this operation can cause a db error in some cases. With leveldb you can have some error if you never close the connection 
02:00 < nathanael> vincenzopalazzo: ok interesting
02:02 -!- kexkey [~kexkey@static-198-54-132-132.cust.tzulo.com] has quit [Ping timeout: 256 seconds]
02:05 -!- kexkey [~kexkey@static-198-54-132-84.cust.tzulo.com] has joined #c-lightning
02:12 < nathanael> vincenzopalazzo: ack #77cb358 of #308 pr in lightningd/plugins
02:13 < nathanael> vincenzopalazzo: maybe this helps https://tmp.dalliard.ch/61ac90c82133301a.txt
02:14 < nathanael> first stopped and restarted with 'plugin stop' and 'plugin start' second time stopped and started the whole node
02:14 < nathanael> both times creating a new summary.dat but the '[Errno 79]' only happens with the rpc call it seems
03:33 < michaelfolkson> mschmoock: Just writing up the transcript from last week's c-lightning call. A reminder to open an issue (marked to the milestone) for the empty error message (try next address loop, running out of known addresses) you brought up :)
03:55 < vincenzopalazzo> nathanael: Sorry, I was to the Gym :) So do you have this db error each time that you call some rpc method?
03:55 < vincenzopalazzo> michaelfolkson: Mh can you remember this issue to me? :)
04:45 < michaelfolkson> vincenzopalazzo: From the transcript...
04:45 < michaelfolkson> "There is one thing I noted, not really related to my change, when you run out of known addresses for a node, the try next address loop recursion thing, the CLI command to connect to a ID, it gives you code `41` with an empty error message which is somehow not really helpful. That is implemented in my tests as well, I could change it but didn’t. I think it would raise the same empty error message without DNS as well."
04:47 < nathanael> vincenzopalazzo: no - only when i stop and start the summary plugin with 'lightning-cli plugin stop ...' and 'lightning-cli plugin start ...'
04:50 < vincenzopalazzo> michaelfolkson: Ah got it, maybe it is already covered by this PR from rusty https://github.com/ElementsProject/lightning/pull/4955 but not sure because I have not 100% understanding of the issue
04:50 < vincenzopalazzo> nathanael: Cool, I will check if we need to close the db on the close event, thanks
04:54 -!- jonatack [jonatack@user/jonatack] has joined #c-lightning
05:49 < vincenzopalazzo> nathanael: I closed the db with the last commit, hopeful this operation will change somethings
06:12 < nathanael> vincenzopalazzo: that seems to have fixed the problem (but not tested with restarting, only with 'plugin stop' and 'plugin start'), but seems to run into a timeout now: https://tmp.dalliard.ch/61acc877d71f9f26.txt
06:12 < nathanael> and something about **kwargs parameter
06:13 < nathanael> but it new reopens the db just fine it seems
06:13 < nathanael> *now
06:14 < vincenzopalazzo> I will improve the API call for the python plugin, not familiar with it, but I will add the log suggestion
06:15 < vincenzopalazzo> in addition, I noted the following line Timeout on shutdown: killing anyway
06:15 < vincenzopalazzo> but I don't have a solution for now :)
06:18 < nathanael> ok thx for your work
06:18 < vincenzopalazzo> nathanael: thanks the testing time
06:36 < vincenzopalazzo> nathanael: ok last commit, lightningd will wait for and sys.exit() during the shoutdown notification. Cool.
06:39 < nathanael> vincenzopalazzo: nice, looks perfect now with stop and start rpc calls - will test next time on a restart of the node itself
06:39 < nathanael> but i think it should be fine then too
06:40 < vincenzopalazzo> Yep cool, hope to solve the issue :) the db during the close operation will flush last data that has in memory. Maybe this is the reason of the failure. Let see what happen with more testing
07:40 < mschmoock> michaelfolkson: thanks, I put that on my todo list
11:14 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
12:44 -!- jonatack [jonatack@user/jonatack] has joined #c-lightning
14:41 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 276 seconds]
14:42 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
21:26 -!- Netsplit *.net <-> *.split quits: jonasschnelli_, face, nathanael, plant-boy[m], RubenSomsen, vincenzopalazzo, berndj, roasbeef, jespada, achow101,  (+30 more, use /NETSPLIT to show all of them)
21:28 -!- Netsplit over, joins: _aj_, _0x0ff, RubenSomsen, michaelfolkson, kanzure, warren, ghost43, achow101, jonasschnelli_, ksedgwic (+30 more)
21:29 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has quit [Ping timeout: 252 seconds]
21:33 -!- ksedgwic [~ksedgwicm@2001:470:69fc:105::ce1] has joined #c-lightning
21:37 -!- Netsplit *.net <-> *.split quits: vincenzopalazzo, devrandom
21:44 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #c-lightning
21:46 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has joined #c-lightning
21:50 -!- Netsplit *.net <-> *.split quits: plant-boy[m]
21:59 -!- plant-boy[m] [~plant-boy@2001:470:69fc:105::1:23ce] has joined #c-lightning
22:05 -!- An0rak [An0rak@user/an0rak] has joined #c-lightning
--- Log closed Mon Dec 06 00:00:53 2021