--- Log opened Wed Feb 09 00:00:54 2022 00:08 < sr_gi> Hi guys. Quick question: re: plugins, is there any recommended (or even imposed) max time a plugin can block the node's main process? 00:11 < vincenzopalazzo> sr_gi: what is re:? 00:11 < vincenzopalazzo> c-lightning for some command will kill the plugin, for others no so the plugin can get stuck c-lightning 00:11 < sr_gi> ups, sorry, I meant regarding 00:14 < vincenzopalazzo> np, just to understend if the re was the name of one plugin :) 00:14 < sr_gi> In my case is for the commitment_revocation hook, but I was asking more in general terms. Wondering is there a "be kind and try not to block the process for longer than X" 00:16 -!- sr_gi [~sr_gi@47.61.62.163] has quit [Read error: Connection reset by peer] 00:19 -!- sr_gi [~sr_gi@47.61.62.163] has joined #c-lightning 01:03 -!- jonatack [jonatack@user/jonatack] has joined #c-lightning 01:16 -!- rusty [~rusty@203.221.55.113] has joined #c-lightning 01:52 -!- stonefox12 [~stonefox@user/stonefox] has quit [Quit: Ping timeout (120 seconds)] 01:52 -!- stonefox12 [~stonefox@user/stonefox] has joined #c-lightning 01:52 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Ping timeout: 256 seconds] 01:52 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #c-lightning 02:03 -!- kexkey [~kexkey@static-198-54-132-126.cust.tzulo.com] has quit [Ping timeout: 240 seconds] 02:05 -!- kexkey [~kexkey@static-198-54-132-94.cust.tzulo.com] has joined #c-lightning 02:26 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has quit [Ping timeout: 256 seconds] 02:26 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #c-lightning 03:48 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 03:49 < cdecker[m]> We don't have a timeout for that hook, no. But it's a good rule of thumb to be as quick as possible anyway. That being said, a hook doesn't fully lock up the processing of other things (exception: `db_write` hook which doesn't allow any concurrency in `lightningd`. 03:51 < cdecker[m]> There are some that may have implicit timeouts (htlc_accepted for example has the CLTV timeout, but that's hours if not days, and there you're holding onto funds along the entire route so my rule of thumb is <<1minute otherwise you're causing trouble to payers and recipients). 08:18 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 256 seconds] 08:35 -!- jonatack [jonatack@user/jonatack] has joined #c-lightning 08:56 < vincenzopalazzo> cdecker: when you have time, and if you have space in your TODO list can you help me to trace the following behaivord of the pay command in the test? I think this failure is unrelated to the scope of the PR https://github.com/ElementsProject/lightning/pull/5022#issuecomment-1033963081 08:57 < vincenzopalazzo> I clean up all the command in three commits basically and now I'm fall in this pay failure that is not able to find the route 11:03 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 260 seconds] 11:32 < sr_gi> cdecker[m] ok, great. It's mainly to account for posting and reading to slow connections, so my approach was on ~5s for connection timeouts and ~30s for read timeouts 11:33 < sr_gi> That felt kinda a bit longer than necessary but not sure if it may have caused an actual issue 12:11 -!- jonatack [jonatack@user/jonatack] has joined #c-lightning 12:42 -!- kexkey [~kexkey@static-198-54-132-94.cust.tzulo.com] has quit [Ping timeout: 240 seconds] 12:43 -!- kexkey [~kexkey@static-198-54-132-134.cust.tzulo.com] has joined #c-lightning 14:14 -!- rusty [~rusty@203.221.55.113] has quit [Ping timeout: 250 seconds] 14:26 -!- jarthur_ [~jarthur@2603-8080-1540-002d-c957-9c20-17fd-9646.res6.spectrum.com] has quit [Ping timeout: 250 seconds] 14:34 -!- jarthur [~jarthur@2603-8080-1540-002d-389f-e35a-ca14-7649.res6.spectrum.com] has joined #c-lightning 14:59 -!- rusty [~rusty@tro1759202.lnk.telstra.net] has joined #c-lightning 15:10 -!- rusty [~rusty@tro1759202.lnk.telstra.net] has quit [Ping timeout: 256 seconds] 15:30 -!- rusty [~rusty@203.221.55.113] has joined #c-lightning 16:42 -!- jarthur_ [~jarthur@2603-8080-1540-002d-115f-b340-192d-b12b.res6.spectrum.com] has joined #c-lightning 16:44 -!- jarthur [~jarthur@2603-8080-1540-002d-389f-e35a-ca14-7649.res6.spectrum.com] has quit [Ping timeout: 240 seconds] 16:56 -!- jarthur [~jarthur@2603-8080-1540-002d-89e3-b4c9-4809-69ad.res6.spectrum.com] has joined #c-lightning 16:57 -!- jarthur_ [~jarthur@2603-8080-1540-002d-115f-b340-192d-b12b.res6.spectrum.com] has quit [Ping timeout: 240 seconds] 17:16 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has quit [Ping timeout: 240 seconds] 17:16 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Ping timeout: 240 seconds] 17:17 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has joined #c-lightning 17:18 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #c-lightning 17:39 -!- rusty [~rusty@203.221.55.113] has quit [Ping timeout: 250 seconds] 18:33 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 250 seconds] 19:21 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning 20:07 -!- rusty [~rusty@203.221.55.113] has joined #c-lightning 20:42 -!- rusty [~rusty@203.221.55.113] has quit [Ping timeout: 240 seconds] 22:53 -!- opsec_x12 [~opsec_x12@44-25-143-42.ip.hamwan.net] has quit [Remote host closed the connection] 23:04 -!- opsec_x12 [~opsec_x12@44-25-143-42.ip.hamwan.net] has joined #c-lightning --- Log closed Thu Feb 10 00:00:55 2022