--- Log opened Mon Feb 21 00:00:05 2022
00:05 -!- darosior [~darosior@194.36.189.246] has quit [Quit: Ping timeout (120 seconds)]
00:06 -!- darosior [~darosior@194.36.189.246] has joined #c-lightning
01:23 -!- jespada [~jespada@148.252.132.52] has joined #c-lightning
02:04 < mschmoock> cdecker[m]: I think I fixed the nois plugin correctly   https://github.com/lightningd/plugins/pull/339  . The tests are failing because CI isn't able to come up with a usable python environment.  The next/last plungin that needs fixing is autopilot.  After that CI should be happy again
02:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
03:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
03:10 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
03:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
03:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
03:15 -!- jonatack [~jonatack@user/jonatack] has joined #c-lightning
03:19 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
03:37 -!- jonatack [jonatack@user/jonatack] has joined #c-lightning
04:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
04:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
04:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
04:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
04:56 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
06:17 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
06:19 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
06:52 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
06:52 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
07:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
07:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
07:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
07:24 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
08:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
08:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
08:18 < mschmoock> anyone a quick check and ack for  https://github.com/lightningd/plugins/pull/339  other wise i will merge as is later to get rid of some CI problems. Same for   https://github.com/lightningd/plugins/pull/340
08:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
08:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
08:22 < vincenzopalazzo> I was reading this PR before, I ack and add just a small question on noise side (not blocked :-P )
08:33 < mschmoock> vincenzopalazzo: I dont understand the question, can you reformulate?
08:34 < mschmoock> also the suggested change is identical :D
08:35 < vincenzopalazzo> bad one sec I miss the change request :D damnt
08:40 < vincenzopalazzo> basicaly the next_id now is calculated by the index for the for loop, but before was last_id + 1, and now just last_id. I'm missing this part here https://github.com/lightningd/plugins/pull/339#discussion_r811292863
08:43 < mschmoock> last_id + 1 was wrong and the previous 'fix' was to make an "<=" comparison from a "<" comparison. Now its basically just an int() cast or len(messages)
08:44 < mschmoock> because I found the code a bit hard to read I added a testcase that checks I didn't break anything else
08:44 < mschmoock> (not my code btw)
08:44 < vincenzopalazzo> mschmoock: ok got it, I will drive inside the full code to catch this part, but basically for me is an ack
08:45 < mschmoock> we could rename 'last_id' to just 'id' or something. and get rid of next_id  by doing:
08:45 < mschmoock> id = int(id) if id is not None else len(plugin.messages)
08:45 < mschmoock> that would be more readable I guess
08:45 < mschmoock> this last and next I didnt understand either :D
08:46 < mschmoock> or call it "msg_id" as "id" seems is a buildin python
08:48 < mschmoock> ... testing that right now
08:49 < vincenzopalazzo> looks like a function https://www.programiz.com/python-programming/methods/built-in/id
08:51 < mschmoock> yup, better now. I'll append another commit. can you check?  
08:51 < mschmoock> https://github.com/lightningd/plugins/pull/339/commits/d26cd5d65a4a51947302b53e5ac9b51dfc119b8c 
08:51 < mschmoock> ah, and we now can also remove the int-cast from   res = plugin.messages[int(msg_id)].to_dict()
08:52 < mschmoock> replaced that commit with fix https://github.com/lightningd/plugins/pull/339/commits/e767d16030da69ab159c0fe514a73d1900ad08dc
08:52 < mschmoock> vincenzopalazzo: is this better?
08:53 < vincenzopalazzo> mschmoock: imho yes, looks very clean
08:53 < mschmoock> 'very'  :D at least better
08:53 < mschmoock> kk. lets merge that. CI has better things todo and will likely fail because of autopilot and python env foo
08:54 < vincenzopalazzo> mschmoock: yep I agree
08:55 < mschmoock> I rebase the autopilot branch now, lets see if CI thinks its a bit better now
08:55 < mschmoock> (you need to re-ack because of rebase)
08:56 < mschmoock> btw, do you know why github actions cant always get a working python for us ?
09:00 < vincenzopalazzo> mschmoock: can you share the link of the Ci failure about the github env? I guess that we are building a virtual env on top another virtual env(github action)? :)
09:01 < mschmoock> sometimes it works, often it doesn't. will share the next fail we will see soon
09:01 < mschmoock> the result often is that python does not have the required modules and requirements
09:01 < vincenzopalazzo> yep, I read somethings and can be also the python image used inside the ci
09:02 < mschmoock> here is one
09:02 < mschmoock> https://github.com/lightningd/plugins/runs/5276890544?check_suite_focus=true 
09:02 < mschmoock> it fails all the tests because it cant load modules
09:08 < vincenzopalazzo> mschmoock: not an expert of python import system, but can be that python test use the __init__.py file to import the module to test? and in the cause of autopilog it is empty https://github.com/lightningd/plugins/blob/master/autopilot/__init__.py
09:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
09:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
09:08 < mschmoock> when CI fails like that it fails for all plugins
09:08 < mschmoock> its something about the CI init/setup routine
09:10 < vincenzopalazzo> i will try to look more careful to it after
09:11 -!- stonefox12 [~stonefox@user/stonefox] has joined #c-lightning
09:11 -!- bfsfhkacjzgcytf [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #c-lightning
09:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
09:12 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
09:14 < mschmoock> vincenzopalazzo: also maybe you understand the code at https://github.com/lightningd/plugins/pull/340/commits/89a3092c8b5e7f60a00d5e916a4afbf031d6cc9e  to fix it properly. I dont :D
09:14 < mschmoock> and CI failed again for described reasons :]
09:15 < vincenzopalazzo> path_pdf = {k: v / s for k, v in path_pdf.items()}
09:15 < vincenzopalazzo> do you means this code? 
09:18 < mschmoock> yes
09:20 < mschmoock> I think one of the CI issues is because of a deprecation "DeprecationWarning: Importing 'itsdangerous.json' is deprecated and will be removed in ItsDangerous 2.1. Use Python's 'json' module instead"
09:21 < cdecker[m]> Heya mschmoock and vincenzopalazzo , sorry for jumping in so late, was stuck on the phone and the cln code all day. What's the current status? Looking into 339 and 340 as we speak
09:21 < mschmoock> 339 is done we think
09:21 < mschmoock> 340 has a fixme comment which I didnt fix, just 'found'
09:22 < mschmoock> also CI has issues because it often (not always) does not come up with a working environment.
09:22 < mschmoock> if so all tests fail
09:22 < cdecker[m]> Ok, I'll lookl through it anyway so I know whats going on ^^
09:22 < mschmoock> https://github.com/lightningd/plugins/runs/5277596617?check_suite_focus=true  
09:22 < mschmoock> one worked, 4 broke all tests because of json imports and other basic stuff
09:23 < mschmoock> I thnk its maybe because of deprecations i.e. itsdangerous.json that are not available
09:25 < cdecker[m]> Oh such fun :-) I'm starting to see whjy everybody keeps complaining about python's dependency management
09:26 < mschmoock> I think we need to be more clean on our CI and fix issues before they get annyoing to everyone and nobody cares for CI and instead pushing bad commits :D
09:27 < cdecker[m]> Yeah, agreed
09:27 < mschmoock> (@ #332)
09:27 < mschmoock> today is clean up day
09:27 < cdecker[m]> Fwiw it seems Flask has a lose dependency definition on itsdangerous which changed underneath it. I'll see if we can fix it on the plugins repo, without going through pyln-testing.
09:28 < mschmoock> afk. cu later. meeting today?
09:29 < cdecker[m]> I'm pretty much drained and I'd fall asleep during the call, so I think I'll skip today
09:35 < mschmoock> I want to see that :D
09:36 < mschmoock> is it a problem for CI that the plugin 'request-invoice' has a flask==1.1.4 in the requirements?
09:39 < mschmoock> I merged 340. Further CI issues and div by zero (not happening in CI) can be fixed as a follow up. I just can't see all this CI failures anymore
10:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
10:07 < cdecker[m]> Agreed, I think we'll switch to PEP 517 (poetry Et al) for the libraries, since that is more robust than the legacy setup.py stuff
10:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
10:07 < cdecker[m]> (relative dependencies, locking support, etc) that'll also tell us during dependency resolution whether we can satisfy all the constraints.
10:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
10:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
10:56 < vincenzopalazzo> <cdecker[m]> "Agreed, I think we'll switch..." <- I use this only to said that with poetry in lnprototest I have a recursion dependeces that I'm trying to solve with this PR in cln https://github.com/ElementsProject/lightning/pull/5033
10:57 < vincenzopalazzo> but not sure that this case the recursion, maybe it is the x.x.postx convention, but not sure either
11:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
11:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
11:16 -!- rusty [~rusty@203.214.146.24] has joined #c-lightning
11:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
11:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
11:54 -!- jespada [~jespada@148.252.132.52] has quit [Ping timeout: 260 seconds]
12:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
12:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
12:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
12:18 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
12:27 -!- rusty [~rusty@203.214.146.24] has quit [Ping timeout: 256 seconds]
13:14 -!- jespada [~jespada@148.252.132.52] has joined #c-lightning
13:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
13:17 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
14:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
14:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
14:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
14:29 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
14:31 -!- rusty [~rusty@pa49-178-84-163.pa.nsw.optusnet.com.au] has joined #c-lightning
14:49 -!- jespada [~jespada@148.252.132.52] has quit [Read error: Connection reset by peer]
14:50 -!- Guest43 [~Guest43@98.52.25.254] has joined #c-lightning
14:50 -!- Guest43 [~Guest43@98.52.25.254] has quit [Client Quit]
15:01 -!- jespada [~jespada@148.252.132.52] has joined #c-lightning
15:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
15:08 -!- jespada [~jespada@148.252.132.52] has quit [Read error: Connection reset by peer]
15:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
15:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
15:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
15:33 -!- rusty [~rusty@pa49-178-84-163.pa.nsw.optusnet.com.au] has quit [Ping timeout: 256 seconds]
15:38 -!- rusty [~rusty@203.214.146.24] has joined #c-lightning
16:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
16:27 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
16:33 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
16:33 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
17:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
17:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
17:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
17:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
17:48 -!- rusty [~rusty@203.214.146.24] has quit [Ping timeout: 272 seconds]
18:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
18:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
18:10 -!- rusty [~rusty@203.221.41.134] has joined #c-lightning
18:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
18:11 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
19:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
19:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
19:23 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
19:26 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
20:08 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
20:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
20:10 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
20:21 -!- rusty [~rusty@203.221.41.134] has quit [Ping timeout: 240 seconds]
20:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
20:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
21:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
21:07 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
21:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
21:08 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
21:13 -!- rusty [~rusty@203.214.146.24] has joined #c-lightning
21:51 -!- rusty [~rusty@203.214.146.24] has quit [Ping timeout: 256 seconds]
22:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
22:02 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
22:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
22:21 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
22:51 -!- mschmoock [~will@schmoock.net] has quit [Ping timeout: 240 seconds]
23:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
23:03 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
23:03 -!- mschmoock [~will@schmoock.net] has joined #c-lightning
23:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
23:13 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #c-lightning
--- Log closed Tue Feb 22 00:00:06 2022