--- Log opened Sun Apr 24 00:00:03 2022
00:02 -!- rusty [~rusty@210.185.125.71] has joined #c-lightning
00:54 -!- jarthur [~jarthur@user/jarthur] has joined #c-lightning
01:24 < mschmoock> rusty: hi, I figured that ip address detection mainly works for IPv4 as the vast majority of nodes that have an IPv6 address also have an IPv4 address, and we 'prefer'
01:24 < mschmoock> IPv4 by trying that first
01:25 < mschmoock> I suggest we can optimize the connect try loop in a way that it tries both IPv4 and IPv6 first depending on when we have last discovered an address of ours and then try the other protocol first
01:25 < mschmoock> (for example)
01:26 < vincenzopalazzo> mschmoock: I like the idea also to take the type of address randomly
01:27 < mschmoock> yes also thought about that, but we should then store information on what we have tried so far, or make it pseudorandom
01:29 -!- rusty [~rusty@210.185.125.71] has quit [Ping timeout: 276 seconds]
01:59 < vincenzopalazzo> yeah true
02:44 < cdecker[m]> Fwiw we could use the data store API for experimental stuff that requires storing data but we're not sure enough to actually wire everything through to the DB layer
05:04 < mschmoock> I wouldnt want to use the DB for that
05:04 < mschmoock> its not required beyond restart
05:06 < vincenzopalazzo> mschmoock: can you point me on the part of the code that we should take this decision?
05:17 -!- rusty [~rusty@210.185.125.71] has joined #c-lightning
05:22 -!- rusty [~rusty@210.185.125.71] has quit [Ping timeout: 246 seconds]
05:28 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
05:35 < mschmoock> vincenzopalazzo: connectd/connectd.c:839    try_connect_one_addr
05:35 < mschmoock> it iterates using the connect->addrnum++;
05:35 < vincenzopalazzo> mschmoock: Thanks!
05:35 < mschmoock> (line 1016)
05:36 < mschmoock> we could think about about a pre-sort of that addrs so that the loop must not be touched
05:36 < mschmoock> depending on if we already know an IPv4 it can be sorted so that it will try IPv6 first
05:38 < vincenzopalazzo> yeah I was thinking to that, if we keep and array of address [{IPV4, tried: bool}, {IPV6, tried: bool}, ...], should be trivial the random choice right?
05:38 < vincenzopalazzo> and also build the array should be trivial
05:39 < mschmoock> and in order to know that we need to have some wire communication and add a timestamp of the discovered addrs to lightningd/lightningd.h:161  maybe
05:39 < mschmoock> I would not add a tried true/fals array
05:39 < mschmoock> just pre order the addresses in a way and let the try_connect_one_addr more or less untouched
05:40 < mschmoock> currently it just goes through all addresses one after another
05:40 < mschmoock> if you (conditionally) preorder it when you already discovered an IPv4 (or 6) address more recently
05:41 < mschmoock> then it tries the one first that can give you the other missing address
05:42 < mschmoock> ah, I see you think more about making it random
05:42 < mschmoock> I currently don't see a benefit of trying it random
05:43 < mschmoock> see for example TOR addresses are tried at last for a reason, because if you can make an IP connection, its higly likely that it is more reliable and you will experience less disconnects (and hence less channel active/inactive gossip messages for everyone else)
05:44 < vincenzopalazzo> yes my idea was take it randomly
05:44 < mschmoock> you can make it random for IPv4 and IPv6
05:44 < vincenzopalazzo> mschmoock: and yes with random choice you have a tor address error
05:44 < mschmoock> but that is less helpful than using the stuff already known by address discovery
05:44 < mschmoock> so anyway, thats my 2 satoshis :D
05:45 < mschmoock> currently we have IPv4 in 99% of the cases
05:45 < vincenzopalazzo> mschmoock: yep! but with too many condition he start to be a little bit messy
05:45 < vincenzopalazzo> mschmoock: Yep! because we all have a Ipv4 configured most of the case
05:46 < mschmoock> thats why a pre-sort without really touching the connect loop is less messy
05:46 < vincenzopalazzo> yes I agree
06:09 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
06:35 -!- shesek [~shesek@user/shesek] has joined #c-lightning
07:02 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
07:03 -!- shesek [~shesek@user/shesek] has joined #c-lightning
07:44 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
07:45 -!- shesek [~shesek@user/shesek] has joined #c-lightning
08:16 -!- An0rak [An0rak@user/an0rak] has quit [Ping timeout: 240 seconds]
08:20 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
08:21 -!- shesek [~shesek@user/shesek] has joined #c-lightning
09:46 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
09:46 -!- shesek [~shesek@user/shesek] has joined #c-lightning
10:12 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
10:13 -!- shesek [~shesek@user/shesek] has joined #c-lightning
10:20 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
10:21 -!- shesek [~shesek@user/shesek] has joined #c-lightning
10:30 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
10:30 -!- shesek [~shesek@user/shesek] has joined #c-lightning
10:47 -!- evanlinjin [evanlinjin@gateway/vpn/protonvpn/evanlinjin] has joined #c-lightning
11:01 -!- bfsfhkacjzgcytf9 [~bfsfhkacj@user/bfsfhkacjzgcytf] has joined #c-lightning
11:17 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #c-lightning
11:42 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
11:43 -!- shesek [~shesek@user/shesek] has joined #c-lightning
11:58 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
11:58 -!- evanlinjin [evanlinjin@gateway/vpn/protonvpn/evanlinjin] has quit [Quit: Konversation terminated!]
11:59 -!- shesek [~shesek@user/shesek] has joined #c-lightning
11:59 -!- evanlinjin [evanlinjin@gateway/vpn/protonvpn/evanlinjin] has joined #c-lightning
12:43 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
12:43 -!- shesek [~shesek@user/shesek] has joined #c-lightning
12:57 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
12:58 -!- shesek [~shesek@user/shesek] has joined #c-lightning
13:25 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
13:25 -!- shesek [~shesek@user/shesek] has joined #c-lightning
13:45 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
13:46 -!- shesek [~shesek@user/shesek] has joined #c-lightning
14:04 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
14:04 -!- shesek [~shesek@user/shesek] has joined #c-lightning
14:08 -!- An0rak [An0rak@user/an0rak] has joined #c-lightning
15:16 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
15:16 -!- shesek [~shesek@user/shesek] has joined #c-lightning
15:29 -!- evanlinjin [evanlinjin@gateway/vpn/protonvpn/evanlinjin] has quit [Ping timeout: 240 seconds]
15:37 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
15:38 -!- shesek [~shesek@user/shesek] has joined #c-lightning
15:43 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
15:44 -!- shesek [~shesek@user/shesek] has joined #c-lightning
16:26 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
16:27 -!- shesek [~shesek@user/shesek] has joined #c-lightning
16:37 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
16:37 -!- shesek [~shesek@user/shesek] has joined #c-lightning
16:52 -!- An0rak [An0rak@user/an0rak] has quit [Ping timeout: 272 seconds]
17:04 -!- shesek [~shesek@user/shesek] has quit [Remote host closed the connection]
17:04 -!- shesek [~shesek@user/shesek] has joined #c-lightning
17:11 -!- shesek_ [~shesek@user/shesek] has joined #c-lightning
17:12 -!- shesek [~shesek@user/shesek] has quit [Read error: Connection reset by peer]
17:27 -!- evanlinjin [~evanlinji@2001-b400-e7dd-31d2-a16b-2e43-32cb-139f.emome-ip6.hinet.net] has joined #c-lightning
17:35 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
17:35 -!- shesek_ [~shesek@user/shesek] has joined #c-lightning
17:49 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
17:49 -!- shesek_ [~shesek@user/shesek] has joined #c-lightning
18:01 -!- shesek_ [~shesek@user/shesek] has quit [Remote host closed the connection]
18:01 -!- shesek_ [~shesek@user/shesek] has joined #c-lightning
18:12 -!- shesek_ [~shesek@user/shesek] has quit [Quit: Leaving]
18:49 -!- evanlinjin [~evanlinji@2001-b400-e7dd-31d2-a16b-2e43-32cb-139f.emome-ip6.hinet.net] has quit [Ping timeout: 260 seconds]
18:52 -!- evanlinjin [~evanlinji@2001-b400-e453-a94f-b61f-bef6-42fc-907f.emome-ip6.hinet.net] has joined #c-lightning
19:03 -!- evanlinjin [~evanlinji@2001-b400-e453-a94f-b61f-bef6-42fc-907f.emome-ip6.hinet.net] has quit [Ping timeout: 260 seconds]
19:39 -!- evanlinjin [evanlinjin@gateway/vpn/protonvpn/evanlinjin] has joined #c-lightning
20:08 -!- evanlinjin [evanlinjin@gateway/vpn/protonvpn/evanlinjin] has quit [Ping timeout: 272 seconds]
20:35 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity]
21:03 -!- Guest50 [~Guest50@27.58.5.74] has joined #c-lightning
21:05 -!- Guest50 [~Guest50@27.58.5.74] has quit [Client Quit]
21:10 -!- rusty [~rusty@210.185.125.71] has joined #c-lightning
21:10 -!- rusty [~rusty@210.185.125.71] has quit [Remote host closed the connection]
22:08 -!- cryptoquick0 [~cryptoqui@8.46.89.33] has joined #c-lightning
22:09 -!- cryptoquick [~cryptoqui@8.46.89.33] has quit [Ping timeout: 240 seconds]
22:09 -!- cryptoquick0 is now known as cryptoquick
23:53 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 240 seconds]
--- Log closed Mon Apr 25 00:00:04 2022