--- Log opened Wed Nov 23 00:00:25 2022
00:01 -!- sandipndev [~sandipnde@shindig.notmandatory.org] has joined #c-lightning
00:02 -!- yakshaver [~yakshaver@shindig.notmandatory.org] has joined #c-lightning
00:14 -!- kimo [~kimo@222.190.127.25] has quit [Ping timeout: 260 seconds]
00:25 -!- sandipndev [~sandipnde@shindig.notmandatory.org] has quit [Ping timeout: 260 seconds]
00:25 -!- yakshaver [~yakshaver@shindig.notmandatory.org] has quit [Ping timeout: 260 seconds]
00:29 -!- sandipndev [~sandipnde@shindig.notmandatory.org] has joined #c-lightning
00:32 -!- yakshaver [yakshaver@2600:3c00::f03c:92ff:fe8e:dce6] has joined #c-lightning
00:33 -!- kimo [~kimo@222.190.127.25] has joined #c-lightning
01:03 -!- RubenSomsen [sid301948@user/rubensomsen] has quit [Read error: Software caused connection abort]
01:03 -!- RubenSomsen [sid301948@user/rubensomsen] has joined #c-lightning
01:06 -!- jespada [~jespada@nmal-24-b2-v4wan-166357-cust1764.vm24.cable.virginm.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
01:07 -!- NorrinRadd [~me@185.238.231.43] has quit [Ping timeout: 260 seconds]
01:19 -!- NorrinRadd [~me@105.112.154.106] has joined #c-lightning
01:19 -!- NorrinRadd [~me@105.112.154.106] has quit [Client Quit]
01:21 -!- NorrinRadd [~me@98.159.224.221] has joined #c-lightning
01:35 -!- NorrinRadd [~me@98.159.224.221] has quit [Ping timeout: 260 seconds]
01:38 -!- kimo_ [~kimo@222.190.127.25] has joined #c-lightning
01:41 -!- kimo [~kimo@222.190.127.25] has quit [Ping timeout: 248 seconds]
01:50 -!- jespada [~jespada@85.255.232.189] has joined #c-lightning
02:04 -!- kexkey [~kexkey@static-198-54-132-142.cust.tzulo.com] has quit [Ping timeout: 255 seconds]
02:04 -!- jespada [~jespada@85.255.232.189] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
02:05 -!- kexkey [~kexkey@static-198-54-132-142.cust.tzulo.com] has joined #c-lightning
02:05 -!- jespada [~jespada@85.255.232.189] has joined #c-lightning
02:05 -!- jespada [~jespada@85.255.232.189] has quit [Client Quit]
02:27 -!- kimo_ [~kimo@222.190.127.25] has quit [Read error: Connection reset by peer]
02:46 -!- jespada [~jespada@85.255.232.189] has joined #c-lightning
05:03 -!- jon_atack [~jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
05:06 -!- jespada [~jespada@85.255.232.189] has quit [Ping timeout: 260 seconds]
05:57 < denis2342> has someone succesfully upgraded to 22.11rc2 with a postgresql DB?
05:58 -!- jespada [~jespada@185.69.144.56] has joined #c-lightning
06:04 -!- endothermicdev_ [~endotherm@2600:1700:8481:8900:e7d8:1b10:eb25:141f] has joined #c-lightning
06:04 -!- endothermicdev [~endotherm@2600:1700:8481:8900:9989:d7c8:52e1:7096] has quit [Ping timeout: 260 seconds]
06:15 -!- NorrinRadd [~me@64.64.116.142] has joined #c-lightning
06:21 -!- jon_atack [~jonatack@user/jonatack] has joined #c-lightning
06:26 < vincenzopalazzo> <Rodicurus> "Does anyone know where I can get..." <- you can create an empty file and add the cln conf into it, but how you install tor? 
06:26 < vincenzopalazzo> <denis2342> "has someone succesfully upgraded..." <- What error are you see? all my node are without postgresql
06:26 < denis2342> I tried to upgrade and the DB migrate throw an error
06:27 < denis2342> is DB version 199 the right one for cl version 12.1?
06:29 < vincenzopalazzo> denis2342: what kind of error? can you post it?
06:29 < denis2342> Error executing statement: ERROR:  null value in column "in_htlc_id" of relation "forwards" violates not-null constraint
06:29 < denis2342> DETAIL:  Failing row contains (793804514405842945, null, 793781424651567105, 730, 69046565, 69045253, 2, 1648834777358890709, 1648834778291821603, null, null).
06:31 < vincenzopalazzo> I think this is a bug could you feel a issue?
06:32 < vincenzopalazzo> fill*
06:34 < denis2342> maybe, first I will digg deeper in to it
06:35 < vincenzopalazzo> there is no much to digger into it, is a schema violation this should never happens
06:45 < denis2342> vincenzopalazzo: I must admit that I started last year with sqlite3 and then used a script to convert to postgresql. maybe this generated somehow a wrong version for the schema
06:45 < denis2342> Refusing to irreversibly upgrade db from version 199 to 212 in non-final version v22.11rc2
06:45 < denis2342> so I need to know what the version of 12.1 should be
06:46 < vincenzopalazzo> ah, you touch the db with additional script!
06:46 < vincenzopalazzo> make sense
06:46 < denis2342> just once, that was last year november and I had no errors at all with the DB
06:47 < vincenzopalazzo> cln now protect the user to automate upgrade the db with the flag
06:47 < vincenzopalazzo> maybe there is something else in your log
06:48 < vincenzopalazzo> however I think that but is introduced here https://github.com/ElementsProject/lightning/commit/63457229cbe287cb04ddf907898794a12288d721 but not sure how
06:49 < vincenzopalazzo> if you want share with me some more log we can try to debug it
06:50 < vincenzopalazzo> also in DM is you prefer or by emaill
06:51 < denis2342> let me log at the logs first
06:52 < denis2342> good thing is that I could easily reinstall 12.1 and all is running fine again.
06:52 < vincenzopalazzo> the log should contains a stacktrace
06:53 < vincenzopalazzo> denis2342: yep, but maybe we can fix the bug before the rc3
06:59 < denis2342> nothing to see in the logs about migrating
06:59 < vincenzopalazzo> no stacktrace?
07:01 < denis2342> no
07:01 < denis2342> it didnt crash, it just stopped because it could not finish the db migrate
07:02 < vincenzopalazzo> ok so you had just the DB error inside it?
07:04 < denis2342> yes
07:05 < vincenzopalazzo> I see
07:10 < denis2342> what I not understand is that lightning wanted to migrate from db version 199 to 203, but I see 208 migration statements in wallet/db.c
07:16 < vincenzopalazzo> no idea about the db version
07:16 < vincenzopalazzo> but there is a upgrade that can cause this crash with the new 22.11
07:17 < denis2342> there is a version table inside the db with only one row. this has the db version
07:18 < denis2342> and the migration code has all statements in order and the version says how many of these statements you already have
07:18 < denis2342> the code is in wallet/db.c line 70 to 940
07:34 < vincenzopalazzo> Yeah I know, but just I'm just trying to saying it that it is a but in the migration, I assume from the code that the 0.12.1 version is 199
07:35 < vincenzopalazzo> I think also it is a bug because the filed is nullable at line 902 and add it as the primary key 912. And this is a violation because a primary key is not null
07:43 < denis2342> right now I creating a testbed and try that with a node which is not in production
07:44 < vincenzopalazzo> yep
07:44 < vincenzopalazzo> good move
07:51 -!- jespada [~jespada@185.69.144.56] has quit [Read error: Connection reset by peer]
08:19 -!- jespada [~jespada@185.69.144.56] has joined #c-lightning
08:39 -!- opsec_x122 [~opsec_x12@44-25-143-46.ip.hamwan.net] has joined #c-lightning
08:39 -!- opsec_x12 [~opsec_x12@44-25-143-46.ip.hamwan.net] has quit [Remote host closed the connection]
08:44 < denis2342> ok, version 199 for 12.1 is correct.
08:45 < vincenzopalazzo> yes because cln if fails do not update
08:45 < vincenzopalazzo> the db
08:47 -!- NorrinRadd [~me@64.64.116.142] has quit [Ping timeout: 256 seconds]
08:49 < denis2342> upgrading the empty database was no problem
08:50 < denis2342> lightningd: Updating database from version 199 to 212
08:50 < vincenzopalazzo> yep I'm opening a pr to fix the primary key stuff
08:50 -!- NorrinRadd [~me@188.215.95.113] has joined #c-lightning
08:55 < denis2342> UNUSUAL plugin-bookkeeper: Snapshot balance does not equal ondisk reported 0msat, off by (+0msat/-0msat) (account wallet) Logging journal entry.
08:55 < denis2342> this also doesnt look right
08:55 < denis2342> also on the empty node, no channels nothing
08:56 < vincenzopalazzo> yeah I see this time to time too
08:56 < vincenzopalazzo> I assume that it is why there is no db?
08:56 < denis2342> no, on the testbed there is now running a 22.11rc2
08:57 < denis2342> the message came after upgrading from 12.1 to 22.11rc2
08:58 < denis2342> ok, this message comes every time now when I start 22.11rc2
08:58 < denis2342> but that is maybe only cosmetical
08:58 < denis2342> I need to got now, will come back later
08:59 < denis2342> I will keep this open..
09:00 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has joined #c-lightning
09:04 -!- jespada [~jespada@185.69.144.56] has quit [Read error: Connection reset by peer]
09:05 -!- jespada [~jespada@185.69.144.56] has joined #c-lightning
09:39 -!- yashraj [yashraj@gateway/vpn/protonvpn/yashraj] has quit []
10:09 < vincenzopalazzo> denis2342: https://github.com/ElementsProject/lightning/pull/5733
10:12 -!- jespada [~jespada@185.69.144.56] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
10:30 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
10:37 -!- jon_atack [~jonatack@user/jonatack] has quit [Quit: WeeChat 3.7.1]
10:41 -!- jonatack [~jonatack@user/jonatack] has joined #c-lightning
11:01 -!- NorrinRadd [~me@188.215.95.113] has quit [Ping timeout: 268 seconds]
11:15 -!- jespada [~jespada@185.69.144.56] has joined #c-lightning
11:29 -!- jespada [~jespada@185.69.144.56] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
11:33 -!- jespada [~jespada@185.69.144.56] has joined #c-lightning
11:38 -!- jespada [~jespada@185.69.144.56] has quit [Client Quit]
12:14 -!- jespada [~jespada@nmal-24-b2-v4wan-166357-cust1764.vm24.cable.virginm.net] has joined #c-lightning
13:48 -!- jb55 [~jb55@user/jb55] has quit [Ping timeout: 248 seconds]
14:24 < denis2342> vincenzopalazzo: maybe it would make more sense to not fix the old conversion but to make it a noop and add the correct one like cdecker did
14:25 < denis2342> so the db does not need to do the work twice
14:25 < denis2342> my forwarded_payments table has nearly one million entries
14:29 < vincenzopalazzo> denis2342: what is mean make it a noop?
14:34 < denis2342> vincenzopalazzo: an operation which does nothing, it is needed because it is all numbered and you cant simply remove it
14:34 < denis2342> noop for “no operation”
14:36 < denis2342> replace it with “select * from version”. thats fast and changes nothing
14:37 < denis2342> but this code needs to be perfect, because if it destroys the DB the users are fucked
14:39 < vincenzopalazzo> I do preferer change remove the id to be not primary key I think it is cleaner. However, I'm not at my desk so I need to look into it more in deep
14:40 < vincenzopalazzo> regargin the migration, I think it is not a big deal because you need to do this only one time.
14:41 < vincenzopalazzo> I was just courius why this field is null in your node, and why rusty choose it as primary key. Maybe it is an older item?
15:02 < denis2342> 1. of april
15:03 < vincenzopalazzo> well not an old one
15:11 < denis2342> "forwarded_payments_in_htlc_id_fkey" FOREIGN KEY (in_htlc_id) REFERENCES channel_htlcs(id) ON DELETE SET NULL
15:11 < denis2342> the Foreign-key constraints of forwarded_payments clearly state what to do in case of DELETE
15:12 < denis2342> so if the entry with the ID in channel_htlc is removed, then the entry in forwarded_payments is set to NULL
15:19 -!- rusty [~rusty@203.221.41.134] has joined #c-lightning
15:50 -!- NorrinRadd [~me@188.215.95.221] has joined #c-lightning
15:58 -!- NorrinRadd [~me@188.215.95.221] has quit [Ping timeout: 260 seconds]
16:01 -!- NorrinRadd [~me@188.215.95.221] has joined #c-lightning
16:09 -!- jon_atack [~jonatack@user/jonatack] has joined #c-lightning
16:11 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 260 seconds]
16:48 -!- NorrinRadd [~me@188.215.95.221] has quit [Ping timeout: 260 seconds]
18:03 -!- qubenix [~qubenix@user/qubenix] has joined #c-lightning
18:05 -!- qubenix [~qubenix@user/qubenix] has quit [Client Quit]
18:06 -!- qubenix [~qubenix@user/qubenix] has joined #c-lightning
20:44 -!- rusty [~rusty@203.221.41.134] has quit [Ping timeout: 260 seconds]
22:42 -!- Guest23 [~Guest23@194.191.241.111] has joined #c-lightning
22:47 -!- Guest23 [~Guest23@194.191.241.111] has left #c-lightning []
23:33 -!- Netsplit *.net <-> *.split quits: warren
23:35 -!- Netsplit over, joins: warren
--- Log closed Thu Nov 24 00:00:26 2022