--- Log opened Fri May 14 00:00:54 2021 01:30 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 01:32 -!- belcher [~belcher@unaffiliated/belcher] has joined ##coinswap 02:39 < belcher> mojo_ rather than just counting swapcoins, count the number of swapcoins which have other_privkey be Some 02:39 < belcher> the signal is transferred via the wallet, which is already swapped into a Arc pointer 02:40 < belcher> or yes if you want you could just use signals instead 02:49 <+JoinMarketRelay> [hackint/mojo_] JoinMarketRelay, Hmm probably that might work, but I have already pivoted to explicit signaling. Because thats communication independent and seems much cleaner. And got it working too. Was little tricky, but at least this will give us better control in future to kill maker whenever we want. We can even kill while it is already talking to taker and 02:49 <+JoinMarketRelay> use it to simulate edge cases. 02:51 < belcher> ok sounds good 08:06 <+JoinMarketRelay> [hackint/mojo_] Hi. Just to let you know the testing basic framework is ready. Making final changes and asserts. Will be opening PR possibly by tomorrow. If in the mean time if you can merge the previous PRs, if there is no remaining comments, I will be able to rebase before creating this one. 08:06 < belcher> yes no problem 08:07 < belcher> merged 14 08:08 < belcher> merged 15 08:08 < belcher> ill give you editing permissions on the github soon, in the middle of something right now 11:42 < belcher> mojo if you're still here, iv sent an invite on github which should allow you to merge pull requests and other permissions (though once you accept we should check because the github interface was slightly unclear to me) 11:44 < belcher> it looks like after you accept the invitation im meant to change your permissions to "write" 19:30 -!- belcher_ [~belcher@unaffiliated/belcher] has joined ##coinswap 19:33 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 252 seconds] --- Log closed Sat May 15 00:00:56 2021