--- Day changed Sat Feb 16 2019
00:53 <@provoostenator> Importing (2x) 1000 keys in QT is unbearably slow by the way.
00:54 <@provoostenator> I was thinking adding a "deletekeymetaforkey" command to the new wallet-tool
00:54 <@provoostenator> To remove specific metadata entries
00:58 < warren> slow because of rescanning?
01:00 < gmaxwell> provoostenator: is it not batching the rescan?
01:03 < warren> I don't know how the current import code works, but years ago I would import keys with rescan disabled then rescan only after importing everything.
01:06 <@provoostenator> It's slow without a rescan, just the (equivalent of) importmulti.
01:07 <@provoostenator> Rescan has a nice progress bar in the UI.
01:08 <@provoostenator> I haven't thoroughly tested this yet, but I think QT is slower than bitcoind with this, so maybe it's sending a bunch of notifications to the GUI along the way.
01:08 <@provoostenator> The import isn't atomic, so it could just be a lot of read / write activity.
01:11 < gmaxwell> oh man, gui notices...
01:11 < gmaxwell> the wallet updates may fsync too if it opens and closes the wallet between each one.
06:24 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
06:24 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined ##hwi     
11:04 < instagibbs> I did 10k keys, it's not that bad?
11:05 < instagibbs> :D     
11:05 < instagibbs> achow101, hmm I'm having issues with your --stdin PR, can't tell if I'm just derping
11:05 < instagibbs> would be really nice to have some examples
11:06 < instagibbs> it never seems to actually take --stdin in place of positional args and just complains about lack of args
11:28 < achow101> instagibbs: --stdin isn't used in place of positional arguments. it's a switch that means that some arguments will be enetered over stdin
11:28 < achow101> e.g. you can do `hwi --stdin` and enter everything
11:29 < achow101> or you could do `hwi --stdin -f 00000000` and then enter the command you want over stdin
11:50 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds]     
11:55 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined ##hwi     
12:52 <@provoostenator> I suspect this breaks descriptor based displayaddress, will check & fix later next week: https://github.com/bitcoin/bitcoin/pull/15368
12:56 <@provoostenator> instagibbs achow101: this could be an alternative to nuking from orbit: https://github.com/bitcoin/bitcoin/pull/15424
12:56 <@provoostenator> I also raised some questions about the use of keymeta vs. watchmeta entries that shoudl probably be clarified before we tag 0.18
12:57 <@provoostenator> TIL that if you don't know how a metadata entry was serialized, then you're screwed :-)
12:58 <@provoostenator> Because we're not encoding the data type, just inferring it from the version number.
13:08 < achow101> provoostenator: eh, bit late for that