--- Day changed Tue Apr 23 2019 01:45 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds] 01:49 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined ##hwi 03:50 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection] 04:19 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined ##hwi 04:20 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Read error: Connection reset by peer] 04:28 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined ##hwi 04:36 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 04:59 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined ##hwi 06:10 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 06:24 < provoostenator> instagibbs: I'm working on signerbumpfee RPC... 06:24 < provoostenator> How do I make coin selection deal with watch-only? 06:24 < provoostenator> https://github.com/bitcoin/bitcoin/pull/15876 10:53 < instagibbs> provoostenator, in which scope? 10:53 < instagibbs> CreateTransaction? 11:02 < gwillen> provoostenator: I did a bunch of work on that for my big offline signing PR, let me look 11:03 < gwillen> there is a 'watchonly' flag in the coin selection struct, but normal coin selection ignores it, I had to make a small change 11:08 < provoostenator> instagibbs: this commit is where the action is at, it's mostly copy-paste from the bumpfee RPC call: https://github.com/bitcoin/bitcoin/pull/15876/commits/9c4d9702754d2a6d065c2d3405d7835457e66bca 11:08 < gwillen> this is when calling CreateTotalBumpTransaction or CreateRateBumpTransaction? 11:09 < provoostenator> Either. I'm happy to drop one though.. 11:09 < provoostenator> I think feeRate should be enough 11:10 < provoostenator> Although feeRate isn't a param. 11:10 < provoostenator> It's inferred from confTarget but I generally prefer setting it manually 11:10 < provoostenator> Eyeballing the mempool weather 11:10 < gwillen> so when I had to deal with this, I had to change listCoins on interfaces::Wallet, to pass through allowWatchOnly to ListCoins on CWallet, which I had to modify to call the version of AvailableCoins that takes a coincontrol object 11:11 < gwillen> I _assume_ it's something like that, inside Create*BumpTransaction 11:14 < gwillen> hmm, it calls CWallet::CreateTransaction, which calls AvailableCoins with the coin_control parameter 11:14 < gwillen> so it shouldn't run into the stuff I hit 11:35 < instagibbs> total bump is lame 11:35 < instagibbs> i only didn't remove it because i would have had to replace a bunch of tests 11:37 < instagibbs> it's really just used in the tests to be very precise with how much you're taking from the change output 21:02 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 245 seconds]