--- Day changed Tue Oct 29 2019
00:11 -!- ThomasV [~thomasv@unaffiliated/thomasv] has quit [Ping timeout: 276 seconds]     
01:01 -!- ThomasV [~thomasv@unaffiliated/thomasv] has joined ##hwi     
01:41 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has quit [Ping timeout: 245 seconds]     
02:37 -!- jonatack [~jon@213.152.162.15] has joined ##hwi     
03:41 -!- ThomasV [~thomasv@unaffiliated/thomasv] has quit [Ping timeout: 276 seconds]     
05:26 -!- jonatack [~jon@213.152.162.15] has quit [Ping timeout: 240 seconds]     
05:27 -!- ThomasV [~thomasv@unaffiliated/thomasv] has joined ##hwi     
08:31 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has quit [Read error: Connection reset by peer]     
08:33 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has joined ##hwi     
08:46 -!- ThomasV [~thomasv@unaffiliated/thomasv] has quit [Ping timeout: 276 seconds]     
08:51 -!- jonatack [~jon@2a01:e35:8aba:8220:6627:dad:d967:649d] has joined ##hwi     
10:37 < provoostenator> Is it just me or does the ColdCard simulator auto-approve any transaction HWI throws at it?
10:38 < achow101> what do you mean by "auto-approve"
10:38 < provoostenator> It just sigs it
10:38 < achow101> there are things it won't sign for
10:38 < provoostenator> Display doesn't ask anything.
10:38 < provoostenator> Yeah, I'm sure it'll reject bad stuff
10:38 < achow101> oh yeah, there's a work around in HWI to auto-click yes for the simulator
10:39 < achow101> had to make the tests work lol
10:39 < provoostenator> Ah     
10:39 < provoostenator> Also, more ACKs on https://github.com/bitcoin/bitcoin/pull/16944 (PSBT send) would be awesome.
10:40 < achow101> provoostenator: https://github.com/bitcoin-core/HWI/blob/master/hwilib/devices/coldcard.py#L99
10:40 < provoostenator> achow101: good to know, I added a note here: https://github.com/bitcoin/bitcoin/pull/16895#issuecomment-547478291
10:42 < provoostenator> The createmutlisigwallet RPC that I introduce in that PR can also be used standalone (without my code that calls HWI), by dropping the last commit.
10:42 < provoostenator> But then you have to manually feed it the right xpubs which is probably too tedious for a human to not screw up.
10:43 < provoostenator> (last commit and third to last commit)
10:45 < provoostenator> (uhh, i.e. just by keeping the first two commits, I'll make a seperate PR by the time descriptor wallets have landed.
10:45 < achow101> maybe we should add a createmultisig command to HWI that makes a multisig out of the specified devices
10:45 < provoostenator> achow101: yes, that would be handy
10:46 < achow101> it could return a descriptor (sorted or not, determine by option?)
10:46 < provoostenator> I would default to BIP67 and "BIP" 48, if anyone wants something else they can PR the option :-)
10:46 < achow101> I'm working on some other HWI changes so i might do that this week. after I rebase a billion wallet PRs
10:46 < provoostenator> This is only useful when both devices are connect though
10:47 < provoostenator> The createmutlisigwallet RPC call I have in mind is a bit more flexible; it can take manual  xpubs for one or more of the devices.
10:48 < provoostenator> Rebasing billion wallet PRs is definately higher on my wish list.
10:50 < provoostenator> I hate it when I have two PRs, the first one is fine, but the one on top of it needs a rebase.
10:50 < achow101> we should consider not writing so many PRs on top of each other
10:52 < provoostenator> I try to make to make them orthogonal where possible
11:46 < instagibbs> "we" I hate stacking PRs and never do it :P
12:05 < achow101> instagibbs: it helps that you rarely write prs anyways :p
12:45 < provoostenator> HWI feature request: enumerate should return a friendly_name field (that I can use in the GUI)
12:46 < provoostenator> E.g. "Trezor Model T"
12:46 < achow101> Just parse the device type and make your own mapping to a friendly name :)
12:47 < provoostenator> And hardcode that into Bitcon Core?
12:47 < achow101> oh     
12:48 < achow101> you should be able to replace hyphens/underscores with spaces and just capitalize each word to get a friendly name
12:48 < provoostenator> Yeah that's another option.
12:48 < provoostenator> Anyway, I'm using the model field for now.
12:48 < provoostenator> Will polish in ~100 commits :-)
13:06 < provoostenator> 36 bottles of beer on the wall.... 20 bottles of beer on the wall (re splitting out  https://github.com/bitcoin/bitcoin/pull/17304)
13:16 < achow101> I don't think drinking 16 bottles of beer in one sitting would be good for you
13:25 < instagibbs> achow101, stop PR shaming. unlike some people I don't get paid to do it ;)
13:40 < instagibbs> https://twitter.com/BtcpayServer/status/1189143210062311429
23:54 -!- ThomasV [~thomasv@unaffiliated/thomasv] has joined ##hwi