--- Day changed Tue Jan 21 2020 04:34 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 06:37 < provoostenator> Haven't had a chance yet. Next step is to create a PSBT in that test and see if it's sane. 06:53 < instagibbs> ship it ;) 06:55 < instagibbs> https://blog.btcpayserver.org/btcpay-vault/ HWI-based wallet thing 07:29 -!- jonatack [~jon@82.102.27.171] has joined ##hwi 08:08 -!- jonatack [~jon@82.102.27.171] has quit [Ping timeout: 265 seconds] 09:03 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined ##hwi 09:39 < provoostenator> Still not able to reproduce, but at least it's maybe a useful test... https://github.com/Sjors/bitcoin/commit/04610844704aee8fb7cd6f94167a767f5473d281 09:56 < instagibbs> is it just me or is core way faster at descriptor import now 09:56 < instagibbs> on master at least 09:57 < provoostenator> Caching was added a few months ago 09:57 < provoostenator> Or batching 09:57 < instagibbs> mmmm it's very nice 09:57 < instagibbs> < 2 secs for 1k records 10:01 < provoostenator> 1 million records is still a bit slow :-) 10:03 < instagibbs> I think you're going to hit some architectual limits not related to cold wallets :P 10:11 < achow101> it was probably the general wallet writing improvements 10:12 < instagibbs> provoostenator, could you review https://github.com/bitcoin-core/HWI/pull/291 ? My inclination is to merge sooner rather than later. 10:12 < achow101> I still can't figure out what the hell is wrong with it. from inspection, it seems like there shouldn't be any problem 10:13 < provoostenator> I'm starting to think I was chasing a ghost. Back to debugging my own app, hopefully there's a clear bug there. 10:14 < provoostenator> instagibbs: I'll add that QT PR to my review list 10:16 < achow101> provoostenator: I mean, there's definitely the wrong inferred descriptor for sortedmulti addresses 10:16 < achow101> so it would be reasonable to assume that incorrect origin info is ending up in PSBTs too 10:17 < achow101> I've at least figured that GetKeyOrigin is returning the wrong origin info for a particular pubkey 10:26 < achow101> actually, I think there isn't. Double checked the xpubs again and it seems right, not sure what I did yesterday that confused me 10:47 < provoostenator> Ok, so the ghost I was chasing was that I called HWI with getxpub "m/48'/0'/0'/2'/0" instead of "m/48'/0'/0'/2' 10:47 < provoostenator> That resulted in a xpub with the wrong depth 10:47 < provoostenator> Which tripped up my change detection code. 10:47 < instagibbs> error lies somewhere between chair and keyboard? 10:47 < instagibbs> or is there a lesson here 10:48 < provoostenator> Lesson: this stuff is tedious 10:48 < instagibbs> what were you doing with 2' 10:48 < instagibbs> just curious 10:48 < provoostenator> Manually setting up a multisig wallet is dangerous, but fine on testnet :-) 10:48 < provoostenator> That's the conversion for native SegWit multisig, at least what ColdCard uses 10:49 < provoostenator> And Electrum too I believe: m/48'/0'/0'/2 10:49 < provoostenator> https://walletsrecovery.org 10:49 < provoostenator> It's a mess, someone needs to standardize this. 10:50 < instagibbs> ah right, multisig standards are super non-standard 10:51 < instagibbs> because the tooling is so impossible still 11:20 < provoostenator> sed: 1: "ui_displayaddressdialog.py": invalid command code u 11:21 < provoostenator> It works when I replace sed with gsed, so it's one of those BSD/macOS sed nonsense problems 11:22 < instagibbs> :grimace: I guess my review should state I'm on ubuntu 11:24 < provoostenator> Also when signing takes a while I get a Connection Refused error. 11:24 < provoostenator> (on a Trezor simulator) 11:25 < provoostenator> I don't know why that needs a minute to sign a 2-of-3 multisig. 11:26 < provoostenator> Actually that happens without QT too. 18:36 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Quit: No Ping reply in 180 seconds.] 18:38 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined ##hwi 18:56 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 19:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined ##hwi 19:16 -!- davterra [~dulyNoded@195.206.105.106] has joined ##hwi