--- Day changed Wed Sep 14 2016
00:11 -!- q-biq [q-biq@unaffiiliated/q-biq] has quit [Ping timeout: 244 seconds]
00:12 -!- q-biq [q-biq@153.92.126.244] has joined #joinmarket
00:12 -!- q-biq [q-biq@153.92.126.244] has quit [Changing host]
00:12 -!- q-biq [q-biq@unaffiiliated/q-biq] has joined #joinmarket
00:24 -!- Einherjer [~einherjer@69.64.40.177] has quit [K-Lined]
00:41 -!- BigTrouble [Elite16197@gateway/shell/elitebnc/x-lycenyyczytoqlva] has quit [Excess Flood]
00:41 -!- BigTrouble [Elite16197@gateway/shell/elitebnc/x-nbauqfimwkhrhmbt] has joined #joinmarket
02:08 -!- fqtw_ [~me@x590c71e2.dyn.telefonica.de] has joined #joinmarket
02:11 -!- fqtw [~me@x590c71e2.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
02:11 -!- fqtw_ is now known as fqtw
03:58 -!- mol [~molly@unaffiliated/molly] has joined #joinmarket
04:02 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 276 seconds]
04:13 <@waxwing> OverlordQ: i'm going to push that fix now, no worries, it was just one line
04:14 <@waxwing> starting to look at the BitcoinCoreWallet issue now, although i have no idea what the exception/error is - i hope i'll find out.
04:15 <@waxwing> we never had a test case for that; this is the issue, the scope of functionality is so wide, i've done my best to cover as much as possible, but never got round to testing that way of using joinmarket, i always left it to other people.
04:15 <@waxwing> because i never used it myself.
04:18 < GithubBot5678> [joinmarket] AdamISZ pushed 1 new commit to develop: https://git.io/viV82
04:18 < GithubBot5678> joinmarket/develop 9c954d7 Adam Gibson: removed nick_pkh_raw (binary) and nick_priv from debug dump
04:31 <@waxwing> is there anyone here who's used sendpayment with the --rpcwallet flag? what do you generally use as the "wallet name" argument on the command line (which is actually going to be the account name). do you use the default "" account?
04:31 <@waxwing> just trying to figure out the most sensible test case
04:46 <@waxwing> belcher: bitcoincorewallet returns a wif key from get_key_from_addr - coming from dumpprivkey, whereas Wallet (i.e. JM wallet) returns hex (from bip32_extract_key). i'll prob figure it out over time, but if you remember why that is, let me know.
05:02 <@waxwing> well, fixing it to return a hex key makes tests pass OK. i've been rooting around in old versions of the code, but even back in the "master-historical" branch this discrepancy exists, and so i'm quite confused as to how it ever worked.
05:02 <@waxwing> because i checked, and btc.sign() never accepted wif keys, only hex or binary raw keys, even in the original pybitcointools code
05:12 <@waxwing> i guess --rpcwallet was not intended to work with sweep?
05:13 <@waxwing> yeah makes sense, just a peculiarity of my test setup that it tried to do that, of course it doesn't make sense :)
05:13 < arubi> waxwing, I think decode_privkey from bybitcointools is run when ecdsa_raw_sign() happens and it accepts wif
05:13 <@waxwing> arubi: ah, that would make sense
05:15 < arubi> I guess the only reason you'd ever actually want a wif is for not accidentally mixing privkeys from different networks.. oh well
05:15 <@waxwing> arubi: thanks, that clears up the mystery. new code accepts only "expected" formats.
05:15 < arubi> oh no problem
05:16 <@waxwing> in my code there is "from wif privkey" that complains if the network is wrong.
05:18 < arubi> mhm, does not look like pybitcointools care so much :)
05:18 <@waxwing> problem with the "easy going approach" is that code is built using it where all the different instances all over the code are different formats, not good long term.
05:19 < arubi> right, you'd probably only "get" wif if it's coming from outside jm wallet right?  no reason for internal stuff to mess with wif once it's inside
05:20 <@waxwing> yeah no problem with wif, or with different formats, just some consistency so you know what's going on at one particular layer.
05:20 <@waxwing> anyway it's all good now, very simple to fix and tests seem to be passing.
05:21 < arubi> nice
05:40 -!- ThisIsZenified [~ImCool@176.123.26.59] has quit [Ping timeout: 244 seconds]
05:41 -!- ThisIsZenified [~ImCool@176.123.26.59] has joined #joinmarket
05:49 <@waxwing> should i just remove patientsendpayment from the repo until we finally get around to fixing it? seems like we should have done that by now. i haven't had time to look into it, maybe the fix is very simple.
06:06 < GithubBot5678> [joinmarket] AdamISZ pushed 1 new commit to develop: https://git.io/viVw3
06:06 < GithubBot5678> joinmarket/develop 6a86338 Adam Gibson: Fix bug in --rpcwallet option; BitcoinCoreWallet.get_key_from_addr now returns hex, not wif privkey....
06:13 <@waxwing> whoever that guest was, they can retry now, should be fixed
06:34 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has joined #joinmarket
07:11 -!- lnostdal [~lnostdal@89.10.138.150] has quit [Ping timeout: 244 seconds]
07:51 -!- fqtw_ [~me@x4db07b2c.dyn.telefonica.de] has joined #joinmarket
07:54 -!- fqtw [~me@x590c71e2.dyn.telefonica.de] has quit [Ping timeout: 250 seconds]
07:55 -!- grubles [~grbs@unaffiliated/grubles] has joined #joinmarket
08:06 -!- fqtw_ is now known as fqtw
09:16 < GithubBot5678> [joinmarket] AdamISZ pushed 1 new commit to develop: https://git.io/viwI3
09:16 < GithubBot5678> joinmarket/develop e0543d2 Adam Gibson: add release notes for 0.2.1
09:27 < GithubBot5678> [joinmarket] AdamISZ force-pushed develop from e0543d2 to 8fed0da: https://git.io/vauH1
09:27 < GithubBot5678> joinmarket/develop 8fed0da Adam Gibson: add release notes for 0.2.1, update readme
09:43 -!- lnostdal [~lnostdal@48-79-11.connect.netcom.no] has joined #joinmarket
09:44 -!- lnostdal [~lnostdal@48-79-11.connect.netcom.no] has quit [Read error: Connection reset by peer]
09:48 -!- lnostdal [~lnostdal@48-79-11.connect.netcom.no] has joined #joinmarket
09:53 < GithubBot5678> [joinmarket] AdamISZ merged develop into master: https://git.io/viwOn
10:01 <@waxwing> https://bitcointalk.org/index.php?topic=919116.msg16249012#msg16249012
10:08 <@waxwing> ok reddit, IRC /topic and bitcointalk done for that. belcher if you can tweet at some point, thanks.
10:31 <@waxwing> i can't seem to add the "check for timedout counterparties" button to the website orderbook because django wants a csrf token, oh well. should fix that at some point.
10:38 <@waxwing> is anyone up for running through the tailsjoin install and updating it for the new version? https://github.com/JoinMarket-Org/tailsjoin
10:38 <@waxwing> this may be a good starting point for whatever the delta is: https://github.com/JoinMarket-Org/joinmarket/wiki/Installing-the-libsecp256k1-binding#installing-the-libsecp256k1-binding-on-tails
10:56 -!- raedah [~x@c-67-166-81-79.hsd1.or.comcast.net] has joined #joinmarket
10:58 < nkuttler> ah, just had to reduce the counterparties for my faucet to work again... should have done that sooner
10:58 < nkuttler> actually, i should catch that error and reduce the required counterparties on the fly
11:48 <@waxwing> nkuttler: prob is no one really has motivation to run them on testnet, i still have 2 of mine up I think.
11:52 < nkuttler> waxwing: thank you!
11:52 < nkuttler> worst case i'll just run more myself
12:14 -!- anybodyhere [6b4dcdbb@gateway/web/freenode/ip.107.77.205.187] has joined #joinmarket
12:18 -!- lnostdal [~lnostdal@48-79-11.connect.netcom.no] has quit [Quit: https://QuantAtaraxia.pw/]
12:32 < OverlordQ> What is txfee again, amount you're announcing you're covering?
12:33 -!- anybodyhere [6b4dcdbb@gateway/web/freenode/ip.107.77.205.187] has quit [Ping timeout: 240 seconds]
12:36 <@waxwing> OverlordQ: yes it's your contribution. as has been observed often, the process as a whole is a bit broken, but in principle the taker will take how much you offer to contribute into account when deciding which order to choose
12:36 < OverlordQ> Yeahh, just wanted to double check, half tempted to try and make a YG and didn't want to get that backwards lol
12:38 <@waxwing> well go for it if you like; just need to implement the 4 abstract methods in joinmarket/yieldgenerator, in principle.
12:40 < OverlordQ> still supports multiple offers right? Havent paid too much attention to the protocol changes
12:40 <@waxwing> sure, yes, it does
12:42 <@waxwing> nothing has really changed at that level of the code; the motivation of -pe.py is to try to minimizing the number of times you reannounce, as that makes it harder for a spy, hopefully. but i think there are all sorts of things you could do.
12:43 <@waxwing> if you wanted to, you could start a repo with custom scripts maybe. we discussed that at one point, amongst various options.
12:44 < OverlordQ> I just wasn't sure if the hp2/podle stuff was at a lower level and those changes could be ignored or not
12:48 <@waxwing> yes it doesn't have any effect at that level
12:48 <@waxwing> the checks are in Maker and CoinjoinOrder
13:06 -!- raedah [~x@c-67-166-81-79.hsd1.or.comcast.net] has quit [Quit: WeeChat 1.5]
13:51 -!- fqtw_ [~me@x4db07b2c.dyn.telefonica.de] has joined #joinmarket
13:54 -!- fqtw [~me@x4db07b2c.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
14:07 -!- fqtw__ [~me@x4db18f86.dyn.telefonica.de] has joined #joinmarket
14:09 -!- fqtw_ [~me@x4db07b2c.dyn.telefonica.de] has quit [Ping timeout: 265 seconds]
14:35 -!- rdbell [~rdbell@99-100-152-93.lightspeed.irvnca.sbcglobal.net] has joined #joinmarket
15:00 < belcher> "<waxwing> because i checked, and btc.sign() never accepted wif keys, only hex or binary raw keys, even in the original pybitcointools code" <---- thats odd im 90% sure it _did_ accept wif
15:01 -!- rdbell [~rdbell@99-100-152-93.lightspeed.irvnca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:10 -!- rdbell [~rdbell@99-100-152-93.lightspeed.irvnca.sbcglobal.net] has joined #joinmarket
15:18 -!- fqtw__ [~me@x4db18f86.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
15:18 -!- fqtw__ [~me@x4db18f86.dyn.telefonica.de] has joined #joinmarket
15:21 -!- lnostdal [~lnostdal@48-79-11.connect.netcom.no] has joined #joinmarket
16:15 < belcher> definitely not to do with the shift from pybtctools to secp256k1 ?
16:15 < belcher> the original pybtctools btc.sign() function accepted any format
16:32 < belcher> here's the tweet https://twitter.com/joinmarket/status/776201910902743040
17:57 -!- btcdrak [uid165369@gateway/web/irccloud.com/x-uuiottdcbxbvfyyh] has quit [Quit: Connection closed for inactivity]
19:03 < pigeons> i've confused the vitalik pybitcoin with the petertodd pybitcoin before
19:08 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds]
19:48 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #joinmarket
19:52 -!- fqtw_ [~me@x4db24cc9.dyn.telefonica.de] has joined #joinmarket
19:56 -!- fqtw__ [~me@x4db18f86.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20:24 -!- fqtw__ [~me@x4db128b7.dyn.telefonica.de] has joined #joinmarket
20:27 -!- fqtw_ [~me@x4db24cc9.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20:35 -!- rdbell [~rdbell@99-100-152-93.lightspeed.irvnca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:46 -!- Giszmo [~leo@pc-40-227-45-190.cm.vtr.net] has quit [Quit: Leaving.]
22:25 -!- coins123 [~coins123@unaffiliated/coins123] has quit [Read error: Connection reset by peer]
22:25 -!- coins123_ [~coins123@ip-244-225.sn1.clouditalia.com] has joined #joinmarket
22:32 -!- rdbell [~rdbell@99-100-152-93.lightspeed.irvnca.sbcglobal.net] has joined #joinmarket
22:50 <@waxwing> belcher: yah arubi already told me, indeed it did accept any format and that was the solution :)
22:51 <@waxwing> thanks
23:15 -!- rdbell [~rdbell@99-100-152-93.lightspeed.irvnca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:30 -!- coins123_ [~coins123@ip-244-225.sn1.clouditalia.com] has quit []
23:30 -!- coins123 [~coins123@unaffiliated/coins123] has joined #joinmarket
23:33 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 250 seconds]