--- Day changed Sat Nov 26 2016 00:10 -!- coins123 [~coins123@unaffiliated/coins123] has joined #joinmarket 00:47 -!- Taek [~quassel@2001:41d0:1:472e::] has quit [Ping timeout: 260 seconds] 01:03 -!- JJ_ [1b3e5610@gateway/web/freenode/ip.27.62.86.16] has joined #joinmarket 01:13 -!- coins123 [~coins123@unaffiliated/coins123] has quit [Remote host closed the connection] 02:46 -!- coins123 [~coins123@37.177.89.247] has joined #joinmarket 02:46 -!- coins123 [~coins123@37.177.89.247] has quit [Changing host] 02:46 -!- coins123 [~coins123@unaffiliated/coins123] has joined #joinmarket 03:47 < JM-IRCRelay> [AlexCato1] about #665 ( https://github.com/JoinMarket-Org/joinmarket/pull/665 ): waxwing, you suggested to put the check whether the target block is >144 into the base class. Thinking about it, I dont see how it really solves the problem: you still need to edit every inherited estimate_fee_per_kb() to call the parent's method. The only thing gained is that it's 03:47 < JM-IRCRelay> only defined at one point in the code where the cutoff-point is to interpret the value as fee/kb 03:47 < JM-IRCRelay> [AlexCato1] was that the intention? Or maybe i'm missing something? 04:07 <@waxwing> alexcato i think i meant something like - make a common function in the parent class that each derived class calls, so like wrap it. but i wasn't paying a huge amount of attention, i just made a comment on a discussion you were having. 04:10 < JM-IRCRelay> [AlexCato1] ah, great. That's the path i've been following the last 20 minutes as well, nearly done 04:10 <@waxwing> found my earlier comment: "it would need rejigging, but base class being abstract doesn't mean you can't do it, just have something like estimate_tx_fee be callable and then some subsidiary call within the instantiated classes" 04:41 < JM-IRCRelay> [AlexCato1] updated the PR. afk a bit 04:42 <@waxwing> alexcato ; thanks, looks good from here 04:43 <@waxwing> belcher does it look OK? iirc it was your idea, i haven't thought about it so much, apart from just, it seems like a good idea 04:44 <@waxwing> alexcato did you remove the warning part to cut down the size of the comment? i thought that warning was useful, albeit of course mostly people won't read all that stuff. 04:47 < JM-IRCRelay> [AlexCato1] i've fixed that problem in the code. If N=1 doesnt work, N=2 will be used instead automatically. So that warning makes no sense any more 04:47 <@waxwing> oh good. but, i do find that N=1 is very often insane, but then it'll be caught by absurd_fee, so that's fine. thanks. 04:48 <@waxwing> yeah didn't notice, see it now, sorry 04:48 < JM-IRCRelay> [AlexCato1] thought its just a minor change which doesnt justify its own PR 05:45 -!- JJ_ [1b3e5610@gateway/web/freenode/ip.27.62.86.16] has quit [Quit: Page closed] 09:09 -!- molz [~molly@unaffiliated/molly] has quit [Read error: Connection reset by peer] 09:11 -!- lton [253074b8@gateway/web/freenode/ip.37.48.116.184] has joined #joinmarket 10:07 < pigeons> I think it would be nice if joinmarket told you the error when it gets a JsonRpcError from bitcoind 10:08 <@waxwing> pigeons: yeah, good point. if we didn't fix that yet we should have. i remember asking someone to add a line to see it once. 10:08 <@waxwing> it turned out that he had an imported key from the same Core instance and so it couldn't import the address because it was already in the default account. 10:08 <@waxwing> you couldn't guess that without seeing the error 10:08 < pigeons> wow that's actually my problem 10:09 <@waxwing> PRs welcome :) 10:09 < pigeons> joinmarket wasn't working for me so i imported the address to my core wallet 10:09 * waxwing knows he should have done it already :) 10:09 <@waxwing> use direct send 10:09 < pigeons> yeah i feel guilty mentioning features i like in an open source project 10:10 <@waxwing> i mean i know some people are comfortable with importing keys but it's a habit i am personally happy i have not become comfortable with yet :) 10:10 < pigeons> yeah i didnt know about direct send 10:10 <@waxwing> see 0.2.2 release notes 10:10 < pigeons> i've since seen you guys mention it yeah 10:11 <@waxwing> i personally would prefer it if we didn't have importing available (importing *into* joinmarket), just because it's a headache. but, i'm not going to remove it :) 10:11 <@waxwing> exporting of course is different 10:14 < pigeons> i didnt notice that was available either 10:22 <@waxwing> pigeons: which? exporting? 10:23 < pigeons> importing 10:23 <@waxwing> importing you mean 10:23 <@waxwing> yeah that makes sense. i got confused parsing what you said had happened, yes, you would have exported. 10:24 < pigeons> i used to use jm every day for at least a year and havent been able to get it to work when i try over the past few months for various reasons 10:24 < pigeons> starting over now fresh wallets etc 10:25 < pigeons> yeah i wouldnt see how it would be a good iea to import since how would it manage key alongside the bi32 or whatever structure 10:37 -!- moli [~molly@unaffiliated/molly] has joined #joinmarket 11:15 -!- lnostdal [~lnostdal@62.90-149-73.nextgentel.com] has quit [Read error: Connection reset by peer] 11:15 -!- lnostdal [~lnostdal@62.90-149-73.nextgentel.com] has joined #joinmarket 11:19 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 244 seconds] 11:22 -!- moli [~molly@unaffiliated/molly] has joined #joinmarket 11:24 -!- molz [~molly@unaffiliated/molly] has joined #joinmarket 11:27 -!- moli [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 12:03 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has quit [Ping timeout: 258 seconds] 12:39 < tergi> mem pool is clearing out getting more joins going on now 12:53 -!- Empty2k12 [~Empty2k12@p5B10442A.dip0.t-ipconnect.de] has joined #joinmarket 12:55 < Empty2k12> Any very python savy people here? 13:24 -!- mol [~molly@unaffiliated/molly] has joined #joinmarket 13:28 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 13:44 -!- mrkent [~textual@unaffiliated/mrkent] has joined #joinmarket 13:48 <@waxwing> Empty2k12: nobody'll probably say yes, but if you have a question, it doesn't hurt to ask :) 13:48 < Empty2k12> waxwing: I'm creating a pull request for Joinmarket ATM, not sure if one feature is best practice. You can take a look later 14:06 -!- puddinpop [~puddinpop@unaffiliated/puddinpop] has joined #joinmarket 14:32 < adlai> in other news, http://adlai.uncommon-lisp.org:5000/block?id=440661 14:34 <@waxwing> interesting. not us of course :) 14:35 < adlai> still odd to see what driftwood gets caught in the net 14:35 < GithubBot5678> [joinmarket] Empty2k12 opened pull request #670: Allow execution from any filepath (develop...develop) https://git.io/v1kY1 14:35 <@waxwing> absolutely. there's at least one wallet that claims to be doing fakes (samourai). at least, so i heard. 14:36 < adlai> actually, how do you know these aren't JM? 14:36 <@waxwing> huh, why don't i install it and take a look. tomorrow :) 14:36 < Empty2k12> waxwing: see this pull to see my style concerns 14:36 <@waxwing> i don't know for sure actually, just from the tx fee seems ultra unlikely. i should check the +/- (potential cjfee) too. 14:36 < adlai> just inspecting them visually, they don't stick out as badly as the style of FP that kept popping up when i first started working on cjhunt 14:36 <@waxwing> right 14:37 -!- mrkent [~textual@unaffiliated/mrkent] has quit [] 14:37 -!- mrkent [~textual@unaffiliated/mrkent] has joined #joinmarket 14:38 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Client Quit] 14:38 -!- mrkent [~textual@unaffiliated/mrkent] has joined #joinmarket 14:38 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Client Quit] 14:39 -!- mrkent [~textual@unaffiliated/mrkent] has joined #joinmarket 14:39 <@waxwing> just a random number: http://adlai.uncommon-lisp.org:5000/block?id=438724 14:39 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Client Quit] 14:39 <@waxwing> cool too see cjhunt working :) 14:39 -!- mrkent [~textual@unaffiliated/mrkent] has joined #joinmarket 14:40 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Client Quit] 14:40 <@waxwing> appears to be part of the same pattern i think. but, would take a bit of investigation. 14:40 < adlai> didja find this by hand? searching through the web interface is quite sluggish... 14:40 -!- mrkent [~textual@unaffiliated/mrkent] has joined #joinmarket 14:41 <@waxwing> it was like the 4th random one i tried :) just lucky i guess. and for some reason it's ultra-fast. 14:41 -!- mrkent [~textual@unaffiliated/mrkent] has quit [Client Quit] 14:41 <@waxwing> https://blockchain.info/address/1ALCLzZxnp67UrEm2ALvXJQEXFv6bJ6zhT 14:41 <@waxwing> i wonder if this 1Bet is some gambling thing :) 14:42 < adlai> ok, i've figured out the "pattern" for the first tx from blk 440661: 14:42 < adlai> each input is split into two outputs, one out of each pair of outputs has the common size, and each output pair sums to 2000sat less than the input 14:42 < adlai> so each "participant" is contributing equally to the tx fee 14:43 < adlai> ah cjhunt is quick for blocks it's already analyzed 14:44 <@waxwing> great 14:45 < adlai> no db though, so if accident or incident force me to restart it, it has to reanalyze everything 14:45 < adlai> it only analyzes blocks as they come in though, so if you go hunting in very old blocks, it might take entire minutes to analyze 14:46 < adlai> maybe once this semester has winded down i can make it a more useful tool... 14:46 < adlai> waxwing, belcher, what setting a time for our meeting? 14:47 < adlai> here's another busy one: http://adlai.uncommon-lisp.org:5000/block?id=440670 14:48 < adlai> also http://adlai.uncommon-lisp.org:5000/block?id=440423 14:48 -!- moli [~molly@unaffiliated/molly] has joined #joinmarket 14:49 <@waxwing> i'll let you two guys decide, just not as late as now, i should be in bed :) preferably no later than three hours ago :) 14:49 < adlai> that's better for me too 14:50 * adlai is only up now because he woke up a couple hours ago; but this sleep schedule is not sustainable during the schoolweek 14:50 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 15:29 -!- Good [64084466@gateway/web/freenode/ip.100.8.68.102] has joined #joinmarket 15:29 -!- Good is now known as Guest8344 15:29 -!- Guest8344 is now known as Goood 15:30 < Goood> hey, so I believe I was able to install JoinMarket onto Heroku, because it said 'Released V4' 15:30 < Goood> is there any way I can test to make sure its running properly? 15:30 < Goood> I'm new to Heroku and JoinMarket, but figured this would be decent place to ask 15:31 < Goood> well, check if it installed properly at this point. 15:58 -!- Empty2k12 [~Empty2k12@p5B10442A.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 16:57 -!- coins123 [~coins123@unaffiliated/coins123] has quit [Ping timeout: 258 seconds] 17:23 -!- mrkent [~textual@unaffiliated/mrkent] has joined #joinmarket 17:33 -!- mrkent [~textual@unaffiliated/mrkent] has quit [] 17:48 -!- juscamarena [~justin@47.148.176.74] has quit [Ping timeout: 248 seconds] 17:50 -!- juscamarena [~justin@47.148.176.74] has joined #joinmarket 21:03 -!- gijensen [~gijensen@gijensen.xyz] has quit [Ping timeout: 264 seconds]